diff for duplicates of <1533692892.2513.16.camel@realtek.com> diff --git a/a/1.txt b/N1/1.txt index 74f76c7..18c8bda 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,57 +1,66 @@ -T24gVHVlLCAyMDE4LTA4LTA3IGF0IDA5OjIzIC0wNTAwLCBMYXJyeSBGaW5nZXIgd3JvdGU6DQo+ -IE9uIDA4LzA2LzIwMTggMDQ6NDIgUE0sIHZhbGRpcy5rbGV0bmlla3NAdnQuZWR1IHdyb3RlOg0K -PiA+IE9uIE1vbiwgMDYgQXVnIDIwMTggMTI6NTQ6NDAgKzA4MDAsIFl1ZUhhaWJpbmcgc2FpZDoN -Cj4gPj4gRml4IGZvbGxvd2luZyBjb2NjaW5lbGxlIHdhcm5pbmc6DQo+ID4+DQo+ID4+IC4vZHJp -dmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL2J0Y29leGlzdC9oYWxidGM4NzIzYjJh -bnQuYzoyOTUyOjItNDogV0FSTklORzogcG9zc2libGUNCj4gY29uZGl0aW9uIHdpdGggbm8gZWZm -ZWN0IChpZiA9PSBlbHNlKQ0KPiA+wqANCj4gPj7CoMKgwqAJLyogc3cgbWVjaGFuaXNtICovDQo+ -ID4+wqDCoMKgCWlmIChCVENfV0lGSV9CV19IVDQwID09IHdpZmlfYncpIHsNCj4gPj4gLQkJaWYg -KCh3aWZpX3Jzc2lfc3RhdGUgPT0gQlRDX1JTU0lfU1RBVEVfSElHSCkgfHwNCj4gPj4gLQkJwqDC -oMKgwqAod2lmaV9yc3NpX3N0YXRlID09IEJUQ19SU1NJX1NUQVRFX1NUQVlfSElHSCkpIHsNCj4g -Pj4gLQkJCWJ0Yzg3MjNiMmFudF9zd19tZWNoYW5pc20oYnRjb2V4aXN0LCB0cnVlLCB0cnVlLA0K -PiA+PiAtCQkJCQkJwqDCoGZhbHNlLCBmYWxzZSk7DQo+ID4+IC0JCX0gZWxzZSB7DQo+ID4+IC0J -CQlidGM4NzIzYjJhbnRfc3dfbWVjaGFuaXNtKGJ0Y29leGlzdCwgdHJ1ZSwgdHJ1ZSwNCj4gPj4g -LQkJCQkJCcKgwqBmYWxzZSwgZmFsc2UpOw0KPiA+PiAtCQl9DQo+ID4+ICsJCWJ0Yzg3MjNiMmFu -dF9zd19tZWNoYW5pc20oYnRjb2V4aXN0LCB0cnVlLCB0cnVlLA0KPiA+PiArCQkJCQnCoMKgZmFs -c2UsIGZhbHNlKTsNCj4gPj7CoMKgwqAJfSBlbHNlIHsNCj4gPsKgDQo+ID4gUmF0aGVyIHRoYW4g -YmxpbmRseSBmaXhpbmcgdGhpcywgcGVyaGFwcyBhIGJpdCBvZiB0aG91Z2h0IG5lZWRzIHRvIGJl -DQo+ID4gYXBwbGllZCB0byB3aHkgdGhpcyBjb2RlIGxvb2tzIGxpa2UgdGhpcyBpbiB0aGUgZmly -c3QgcGxhY2UuDQo+ID7CoA0KPiA+IFNlZSBjb21taXQgYzY4MjE2MTNlNjUzYcKgwqAod2hpY2gg -bG9va3MgbGlrZSB0aGUgYmxldGNoZXJvdXMgImRvIHRvbyBtYW55DQo+ID4gdGhpbmdzIGF0IG9u -Y2UiIGNvbW1pdCBpbmRlZWQpLCBhbHRob3VnaCB0aGUgYWN0dWFsIGRpZmYgYXBwZWFycyB0byBi -ZSBhDQo+ID4gIm5vIGhhcm0sIG5vIGZvdWwiIGFnYWluc3QgdGhpcyBjb21taXQsIHdoZXJlIHRo -ZSBpc3N1ZSBhbHJlYWR5IGV4aXN0ZWQuDQo+ID7CoA0KPiA+IGNvbW1pdCBhYTQ1YTY3M2IyOTFm -ZDc2MTI3NTQ5M2JjMTUzMTZkNzk1NTVlZDU1DQo+ID4gQXV0aG9yOiBMYXJyeSBGaW5nZXIgPExh -cnJ5LkZpbmdlckBsd2Zpbmdlci5uZXQ+DQo+ID4gRGF0ZTrCoMKgwqBGcmkgRmViIDI4IDE1OjE2 -OjQzIDIwMTQgLTA2MDANCj4gPsKgDQo+ID7CoMKgwqDCoMKgwqBydGx3aWZpOiBidGNvZXhpc3Q6 -IEFkZCBuZXcgbWluaSBkcml2ZXINCj4gPsKgDQo+ID4gTGFycnk/IENhbiB5b3UgcmVhY2ggYmFj -ayB0byAyMDE0IGFuZCByZW1lbWJlciB3aHkgdGhpcyBjb2RlDQo+ID4gbG9va2VkIGxpa2UgdGhp -cyBpbiB0aGUgZmlyc3QgcGxhY2U/DQo+IA0KPiBUaGUgYmFzZSBjb2RlIGNhbWUgZnJvbSBSZWFs -dGVrLiBNeSBvbmx5IHBhcnQgaW4gZ2V0dGluZyBpdCBpbnRvIHRoZSBrZXJuZWwgd2FzwqANCj4g -dG8gY2xlYW4gdXAgdGhlIGNoZWNrcGF0Y2ggYW5kIFNwYXJzZSBlcnJvcnMgYW5kIHdhcm5pbmdz -LCBhbmQgc3VibWl0IGl0LiBJIHdhc8KgDQo+IGEgInNjcmlwdCBraWRkeSIganVzdCBsaWtlIHRo -ZSBhdXRob3JzIG9mIHRoZSBjdXJyZW50IHBhdGNoZXMuIFRoZSBvbmx5wqANCj4gZGlmZmVyZW5j -ZSBpcyB0aGF0IEkgd2FzIGdldHRpbmcgZHJpdmVycyBpbnRvIHRoZSBrZXJuZWwgc28gdGhhdCB1 -c2VycyBoYXJkd2FyZcKgDQo+IHdvdWxkIHdvcmsuDQo+IA0KPiBBbnkgcmVjb3JkIG9mIHdoZXRo -ZXIgdGhlc2UgZHVwbGljYXRlIGJyYW5jaGVzIGFyZSB0aGUgcmVzdWx0IG9mIGluY29ycmVjdCBj -b3B5wqANCj4gYW5kIHBhc3RlLCBvciBqdXN0IGV4dHJhbmVvdXMgY29kZSwgd291bGQgYmUgYXQg -UmVhbHRlayBpbiB0aGVpciB2ZXJzaW9uIGNvbnRyb2zCoA0KPiBoaXN0b3J5LiBJIGhhdmUgbmV2 -ZXIgaGFkIGFjY2VzcyB0byBzdWNoIGFyY2hpdmVzLCBub3IgaGF2ZSBJIGV2ZXIgaGFkIGFuwqAN -Cj4gbm9uLWRpc2Nsb3N1cmUgYWdyZWVtZW50IHdpdGggUmVhbHRlay4NCj4gDQo+IFBpbmctS2Ug -U2hpaCwgd2hvIGlzIENjJ2Qgb24gdGhlc2UgbWVzc2FnZXMsIG1pZ2h0IGJlIGFibGUgdG8gYW5z -d2VyIHRoZXNlwqANCj4gcXVlc3Rpb25zLg0KDQpUaGVzZSBicmFuY2hlcyBpcyB1c2VkIHRvIGlt -cHJvdmUgdXNlciBleHBlcmllbmNlIGFjY29yZGluZyB0byBSU1NJIHN0cmVuZ3RoLCBidXQNCml0 -IGhhcyBub3Qgc2lnbmlmaWNhbnQgaW1wcm92ZW1lbnQgc28gdGhlIHNhbWUgYXJndW1lbnRzIGJl -Y29tZSBkdXBsaWNhdGUgYnJhbmNoZXMuDQpJIGNoZWNrIHRoZSBsYXRlc3QgY29kZSBvZsKgaGFs -YnRjODcyM2IyYW50LmMsIHRoZXJlIGFyZSBtb3JlIHRoYW4gb25lIHN0YXRlbWVudHMNCndpdGhp -biBpZi1lbHNlIGJyYW5jaCB0byBpbXByb3ZlIHBlcmZvcm1hbmNlLCBidXQgdGhlIHN0YXRlbWVu -dHMgbWVudGlvbmVkIGJ5wqANCnRoaXMgcGF0Y2ggYXJlIHN0aWxsIHRoZSBzYW1lLiBTbywgdGhl -c2UgZHVwbGljYXRlIGJyYW5jaGVzIGNhbiBiZSBzYWZlbHkgcmVtb3ZlZC4NCg0KPiANCj4gRm9y -IHRoZSBtb21lbnQsIHRoZXNlIHNpbXBsaWZpY2F0aW9ucyBjb3VsZCBiZSBhcHBsaWVkIGFzIGxv -bmcgYXMgdGhleSBhcmXCoA0KPiBjb3JyZWN0bHkgZG9uZS4gQWZ0ZXIgYWxsLCB0aGV5IGFyZSBu -b3QgY2hhbmdpbmcgd2hhdCBpcyBhbHJlYWR5IHRoZXJlIGFuZCB0aGF0wqANCj4gc3RvcHMgYW55 -IG90aGVyIHBlcnNvbiB0aGF0IGtub3dzIGhvdyB0byBydW4gY29jY2luZWxsZSBmcm9tIHN1Ym1p -dHRpbmcgdGhlIHNhbWXCoA0KPiBwYXRjaCBpbiB0aGUgZnV0dXJlLiBXaHkgImtpY2sgdGhlIGNh -biBkb3duIHRoZSByb2FkIj8gSWYgUEsgY2FuIGZpbmQgdGhhdCB0aGVyZcKgDQo+IHdhcyBhbiBl -cnJvciBpbiB0aGUgb3JpZ2luYWwgY29kZSwgaGUgY2FuIHN1Ym1pdCBhICJGaXhlcyIgcGF0Y2gu -DQo+IA0KPiANCg0K +On Tue, 2018-08-07 at 09:23 -0500, Larry Finger wrote: +> On 08/06/2018 04:42 PM, valdis.kletnieks@vt.edu wrote: +> > On Mon, 06 Aug 2018 12:54:40 +0800, YueHaibing said: +> >> Fix following coccinelle warning: +> >> +> >> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2952:2-4: WARNING: possible +> condition with no effect (if == else) +> > +> >> /* sw mechanism */ +> >> if (BTC_WIFI_BW_HT40 == wifi_bw) { +> >> - if ((wifi_rssi_state == BTC_RSSI_STATE_HIGH) || +> >> - (wifi_rssi_state == BTC_RSSI_STATE_STAY_HIGH)) { +> >> - btc8723b2ant_sw_mechanism(btcoexist, true, true, +> >> - false, false); +> >> - } else { +> >> - btc8723b2ant_sw_mechanism(btcoexist, true, true, +> >> - false, false); +> >> - } +> >> + btc8723b2ant_sw_mechanism(btcoexist, true, true, +> >> + false, false); +> >> } else { +> > +> > Rather than blindly fixing this, perhaps a bit of thought needs to be +> > applied to why this code looks like this in the first place. +> > +> > See commit c6821613e653a (which looks like the bletcherous "do too many +> > things at once" commit indeed), although the actual diff appears to be a +> > "no harm, no foul" against this commit, where the issue already existed. +> > +> > commit aa45a673b291fd761275493bc15316d79555ed55 +> > Author: Larry Finger <Larry.Finger@lwfinger.net> +> > Date: Fri Feb 28 15:16:43 2014 -0600 +> > +> > rtlwifi: btcoexist: Add new mini driver +> > +> > Larry? Can you reach back to 2014 and remember why this code +> > looked like this in the first place? +> +> The base code came from Realtek. My only part in getting it into the kernel was +> to clean up the checkpatch and Sparse errors and warnings, and submit it. I was +> a "script kiddy" just like the authors of the current patches. The only +> difference is that I was getting drivers into the kernel so that users hardware +> would work. +> +> Any record of whether these duplicate branches are the result of incorrect copy +> and paste, or just extraneous code, would be at Realtek in their version control +> history. I have never had access to such archives, nor have I ever had an +> non-disclosure agreement with Realtek. +> +> Ping-Ke Shih, who is Cc'd on these messages, might be able to answer these +> questions. + +These branches is used to improve user experience according to RSSI strength, but +it has not significant improvement so the same arguments become duplicate branches. +I check the latest code of halbtc8723b2ant.c, there are more than one statements +within if-else branch to improve performance, but the statements mentioned by +this patch are still the same. So, these duplicate branches can be safely removed. + +> +> For the moment, these simplifications could be applied as long as they are +> correctly done. After all, they are not changing what is already there and that +> stops any other person that knows how to run coccinelle from submitting the same +> patch in the future. Why "kick the can down the road"? If PK can find that there +> was an error in the original code, he can submit a "Fixes" patch. +> +> diff --git a/a/content_digest b/N1/content_digest index 4863e68..c268bfb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -15,62 +15,71 @@ " davem@davemloft.net <davem@davemloft.net>\0" "\00:1\0" "b\0" - "T24gVHVlLCAyMDE4LTA4LTA3IGF0IDA5OjIzIC0wNTAwLCBMYXJyeSBGaW5nZXIgd3JvdGU6DQo+\n" - "IE9uIDA4LzA2LzIwMTggMDQ6NDIgUE0sIHZhbGRpcy5rbGV0bmlla3NAdnQuZWR1IHdyb3RlOg0K\n" - "PiA+IE9uIE1vbiwgMDYgQXVnIDIwMTggMTI6NTQ6NDAgKzA4MDAsIFl1ZUhhaWJpbmcgc2FpZDoN\n" - "Cj4gPj4gRml4IGZvbGxvd2luZyBjb2NjaW5lbGxlIHdhcm5pbmc6DQo+ID4+DQo+ID4+IC4vZHJp\n" - "dmVycy9uZXQvd2lyZWxlc3MvcmVhbHRlay9ydGx3aWZpL2J0Y29leGlzdC9oYWxidGM4NzIzYjJh\n" - "bnQuYzoyOTUyOjItNDogV0FSTklORzogcG9zc2libGUNCj4gY29uZGl0aW9uIHdpdGggbm8gZWZm\n" - "ZWN0IChpZiA9PSBlbHNlKQ0KPiA+wqANCj4gPj7CoMKgwqAJLyogc3cgbWVjaGFuaXNtICovDQo+\n" - "ID4+wqDCoMKgCWlmIChCVENfV0lGSV9CV19IVDQwID09IHdpZmlfYncpIHsNCj4gPj4gLQkJaWYg\n" - "KCh3aWZpX3Jzc2lfc3RhdGUgPT0gQlRDX1JTU0lfU1RBVEVfSElHSCkgfHwNCj4gPj4gLQkJwqDC\n" - "oMKgwqAod2lmaV9yc3NpX3N0YXRlID09IEJUQ19SU1NJX1NUQVRFX1NUQVlfSElHSCkpIHsNCj4g\n" - "Pj4gLQkJCWJ0Yzg3MjNiMmFudF9zd19tZWNoYW5pc20oYnRjb2V4aXN0LCB0cnVlLCB0cnVlLA0K\n" - "PiA+PiAtCQkJCQkJwqDCoGZhbHNlLCBmYWxzZSk7DQo+ID4+IC0JCX0gZWxzZSB7DQo+ID4+IC0J\n" - "CQlidGM4NzIzYjJhbnRfc3dfbWVjaGFuaXNtKGJ0Y29leGlzdCwgdHJ1ZSwgdHJ1ZSwNCj4gPj4g\n" - "LQkJCQkJCcKgwqBmYWxzZSwgZmFsc2UpOw0KPiA+PiAtCQl9DQo+ID4+ICsJCWJ0Yzg3MjNiMmFu\n" - "dF9zd19tZWNoYW5pc20oYnRjb2V4aXN0LCB0cnVlLCB0cnVlLA0KPiA+PiArCQkJCQnCoMKgZmFs\n" - "c2UsIGZhbHNlKTsNCj4gPj7CoMKgwqAJfSBlbHNlIHsNCj4gPsKgDQo+ID4gUmF0aGVyIHRoYW4g\n" - "YmxpbmRseSBmaXhpbmcgdGhpcywgcGVyaGFwcyBhIGJpdCBvZiB0aG91Z2h0IG5lZWRzIHRvIGJl\n" - "DQo+ID4gYXBwbGllZCB0byB3aHkgdGhpcyBjb2RlIGxvb2tzIGxpa2UgdGhpcyBpbiB0aGUgZmly\n" - "c3QgcGxhY2UuDQo+ID7CoA0KPiA+IFNlZSBjb21taXQgYzY4MjE2MTNlNjUzYcKgwqAod2hpY2gg\n" - "bG9va3MgbGlrZSB0aGUgYmxldGNoZXJvdXMgImRvIHRvbyBtYW55DQo+ID4gdGhpbmdzIGF0IG9u\n" - "Y2UiIGNvbW1pdCBpbmRlZWQpLCBhbHRob3VnaCB0aGUgYWN0dWFsIGRpZmYgYXBwZWFycyB0byBi\n" - "ZSBhDQo+ID4gIm5vIGhhcm0sIG5vIGZvdWwiIGFnYWluc3QgdGhpcyBjb21taXQsIHdoZXJlIHRo\n" - "ZSBpc3N1ZSBhbHJlYWR5IGV4aXN0ZWQuDQo+ID7CoA0KPiA+IGNvbW1pdCBhYTQ1YTY3M2IyOTFm\n" - "ZDc2MTI3NTQ5M2JjMTUzMTZkNzk1NTVlZDU1DQo+ID4gQXV0aG9yOiBMYXJyeSBGaW5nZXIgPExh\n" - "cnJ5LkZpbmdlckBsd2Zpbmdlci5uZXQ+DQo+ID4gRGF0ZTrCoMKgwqBGcmkgRmViIDI4IDE1OjE2\n" - "OjQzIDIwMTQgLTA2MDANCj4gPsKgDQo+ID7CoMKgwqDCoMKgwqBydGx3aWZpOiBidGNvZXhpc3Q6\n" - "IEFkZCBuZXcgbWluaSBkcml2ZXINCj4gPsKgDQo+ID4gTGFycnk/IENhbiB5b3UgcmVhY2ggYmFj\n" - "ayB0byAyMDE0IGFuZCByZW1lbWJlciB3aHkgdGhpcyBjb2RlDQo+ID4gbG9va2VkIGxpa2UgdGhp\n" - "cyBpbiB0aGUgZmlyc3QgcGxhY2U/DQo+IA0KPiBUaGUgYmFzZSBjb2RlIGNhbWUgZnJvbSBSZWFs\n" - "dGVrLiBNeSBvbmx5IHBhcnQgaW4gZ2V0dGluZyBpdCBpbnRvIHRoZSBrZXJuZWwgd2FzwqANCj4g\n" - "dG8gY2xlYW4gdXAgdGhlIGNoZWNrcGF0Y2ggYW5kIFNwYXJzZSBlcnJvcnMgYW5kIHdhcm5pbmdz\n" - "LCBhbmQgc3VibWl0IGl0LiBJIHdhc8KgDQo+IGEgInNjcmlwdCBraWRkeSIganVzdCBsaWtlIHRo\n" - "ZSBhdXRob3JzIG9mIHRoZSBjdXJyZW50IHBhdGNoZXMuIFRoZSBvbmx5wqANCj4gZGlmZmVyZW5j\n" - "ZSBpcyB0aGF0IEkgd2FzIGdldHRpbmcgZHJpdmVycyBpbnRvIHRoZSBrZXJuZWwgc28gdGhhdCB1\n" - "c2VycyBoYXJkd2FyZcKgDQo+IHdvdWxkIHdvcmsuDQo+IA0KPiBBbnkgcmVjb3JkIG9mIHdoZXRo\n" - "ZXIgdGhlc2UgZHVwbGljYXRlIGJyYW5jaGVzIGFyZSB0aGUgcmVzdWx0IG9mIGluY29ycmVjdCBj\n" - "b3B5wqANCj4gYW5kIHBhc3RlLCBvciBqdXN0IGV4dHJhbmVvdXMgY29kZSwgd291bGQgYmUgYXQg\n" - "UmVhbHRlayBpbiB0aGVpciB2ZXJzaW9uIGNvbnRyb2zCoA0KPiBoaXN0b3J5LiBJIGhhdmUgbmV2\n" - "ZXIgaGFkIGFjY2VzcyB0byBzdWNoIGFyY2hpdmVzLCBub3IgaGF2ZSBJIGV2ZXIgaGFkIGFuwqAN\n" - "Cj4gbm9uLWRpc2Nsb3N1cmUgYWdyZWVtZW50IHdpdGggUmVhbHRlay4NCj4gDQo+IFBpbmctS2Ug\n" - "U2hpaCwgd2hvIGlzIENjJ2Qgb24gdGhlc2UgbWVzc2FnZXMsIG1pZ2h0IGJlIGFibGUgdG8gYW5z\n" - "d2VyIHRoZXNlwqANCj4gcXVlc3Rpb25zLg0KDQpUaGVzZSBicmFuY2hlcyBpcyB1c2VkIHRvIGlt\n" - "cHJvdmUgdXNlciBleHBlcmllbmNlIGFjY29yZGluZyB0byBSU1NJIHN0cmVuZ3RoLCBidXQNCml0\n" - "IGhhcyBub3Qgc2lnbmlmaWNhbnQgaW1wcm92ZW1lbnQgc28gdGhlIHNhbWUgYXJndW1lbnRzIGJl\n" - "Y29tZSBkdXBsaWNhdGUgYnJhbmNoZXMuDQpJIGNoZWNrIHRoZSBsYXRlc3QgY29kZSBvZsKgaGFs\n" - "YnRjODcyM2IyYW50LmMsIHRoZXJlIGFyZSBtb3JlIHRoYW4gb25lIHN0YXRlbWVudHMNCndpdGhp\n" - "biBpZi1lbHNlIGJyYW5jaCB0byBpbXByb3ZlIHBlcmZvcm1hbmNlLCBidXQgdGhlIHN0YXRlbWVu\n" - "dHMgbWVudGlvbmVkIGJ5wqANCnRoaXMgcGF0Y2ggYXJlIHN0aWxsIHRoZSBzYW1lLiBTbywgdGhl\n" - "c2UgZHVwbGljYXRlIGJyYW5jaGVzIGNhbiBiZSBzYWZlbHkgcmVtb3ZlZC4NCg0KPiANCj4gRm9y\n" - "IHRoZSBtb21lbnQsIHRoZXNlIHNpbXBsaWZpY2F0aW9ucyBjb3VsZCBiZSBhcHBsaWVkIGFzIGxv\n" - "bmcgYXMgdGhleSBhcmXCoA0KPiBjb3JyZWN0bHkgZG9uZS4gQWZ0ZXIgYWxsLCB0aGV5IGFyZSBu\n" - "b3QgY2hhbmdpbmcgd2hhdCBpcyBhbHJlYWR5IHRoZXJlIGFuZCB0aGF0wqANCj4gc3RvcHMgYW55\n" - "IG90aGVyIHBlcnNvbiB0aGF0IGtub3dzIGhvdyB0byBydW4gY29jY2luZWxsZSBmcm9tIHN1Ym1p\n" - "dHRpbmcgdGhlIHNhbWXCoA0KPiBwYXRjaCBpbiB0aGUgZnV0dXJlLiBXaHkgImtpY2sgdGhlIGNh\n" - "biBkb3duIHRoZSByb2FkIj8gSWYgUEsgY2FuIGZpbmQgdGhhdCB0aGVyZcKgDQo+IHdhcyBhbiBl\n" - "cnJvciBpbiB0aGUgb3JpZ2luYWwgY29kZSwgaGUgY2FuIHN1Ym1pdCBhICJGaXhlcyIgcGF0Y2gu\n" - DQo+IA0KPiANCg0K + "On Tue, 2018-08-07 at 09:23 -0500, Larry Finger wrote:\n" + "> On 08/06/2018 04:42 PM, valdis.kletnieks@vt.edu wrote:\n" + "> > On Mon, 06 Aug 2018 12:54:40 +0800, YueHaibing said:\n" + "> >> Fix following coccinelle warning:\n" + "> >>\n" + "> >> ./drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2952:2-4: WARNING: possible\n" + "> condition with no effect (if == else)\n" + "> >\302\240\n" + "> >>\302\240\302\240\302\240\t/* sw mechanism */\n" + "> >>\302\240\302\240\302\240\tif (BTC_WIFI_BW_HT40 == wifi_bw) {\n" + "> >> -\t\tif ((wifi_rssi_state == BTC_RSSI_STATE_HIGH) ||\n" + "> >> -\t\t\302\240\302\240\302\240\302\240(wifi_rssi_state == BTC_RSSI_STATE_STAY_HIGH)) {\n" + "> >> -\t\t\tbtc8723b2ant_sw_mechanism(btcoexist, true, true,\n" + "> >> -\t\t\t\t\t\t\302\240\302\240false, false);\n" + "> >> -\t\t} else {\n" + "> >> -\t\t\tbtc8723b2ant_sw_mechanism(btcoexist, true, true,\n" + "> >> -\t\t\t\t\t\t\302\240\302\240false, false);\n" + "> >> -\t\t}\n" + "> >> +\t\tbtc8723b2ant_sw_mechanism(btcoexist, true, true,\n" + "> >> +\t\t\t\t\t\302\240\302\240false, false);\n" + "> >>\302\240\302\240\302\240\t} else {\n" + "> >\302\240\n" + "> > Rather than blindly fixing this, perhaps a bit of thought needs to be\n" + "> > applied to why this code looks like this in the first place.\n" + "> >\302\240\n" + "> > See commit c6821613e653a\302\240\302\240(which looks like the bletcherous \"do too many\n" + "> > things at once\" commit indeed), although the actual diff appears to be a\n" + "> > \"no harm, no foul\" against this commit, where the issue already existed.\n" + "> >\302\240\n" + "> > commit aa45a673b291fd761275493bc15316d79555ed55\n" + "> > Author: Larry Finger <Larry.Finger@lwfinger.net>\n" + "> > Date:\302\240\302\240\302\240Fri Feb 28 15:16:43 2014 -0600\n" + "> >\302\240\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\240rtlwifi: btcoexist: Add new mini driver\n" + "> >\302\240\n" + "> > Larry? Can you reach back to 2014 and remember why this code\n" + "> > looked like this in the first place?\n" + "> \n" + "> The base code came from Realtek. My only part in getting it into the kernel was\302\240\n" + "> to clean up the checkpatch and Sparse errors and warnings, and submit it. I was\302\240\n" + "> a \"script kiddy\" just like the authors of the current patches. The only\302\240\n" + "> difference is that I was getting drivers into the kernel so that users hardware\302\240\n" + "> would work.\n" + "> \n" + "> Any record of whether these duplicate branches are the result of incorrect copy\302\240\n" + "> and paste, or just extraneous code, would be at Realtek in their version control\302\240\n" + "> history. I have never had access to such archives, nor have I ever had an\302\240\n" + "> non-disclosure agreement with Realtek.\n" + "> \n" + "> Ping-Ke Shih, who is Cc'd on these messages, might be able to answer these\302\240\n" + "> questions.\n" + "\n" + "These branches is used to improve user experience according to RSSI strength, but\n" + "it has not significant improvement so the same arguments become duplicate branches.\n" + "I check the latest code of\302\240halbtc8723b2ant.c, there are more than one statements\n" + "within if-else branch to improve performance, but the statements mentioned by\302\240\n" + "this patch are still the same. So, these duplicate branches can be safely removed.\n" + "\n" + "> \n" + "> For the moment, these simplifications could be applied as long as they are\302\240\n" + "> correctly done. After all, they are not changing what is already there and that\302\240\n" + "> stops any other person that knows how to run coccinelle from submitting the same\302\240\n" + "> patch in the future. Why \"kick the can down the road\"? If PK can find that there\302\240\n" + "> was an error in the original code, he can submit a \"Fixes\" patch.\n" + "> \n" + > -8239d351990bc092bec423ef6d4abeba2f85fdfba988f512750ce54ee6d323f9 +a1d85b58cda1d6f23d867a597b20270b519c5b79a019c04770c48b0d6e10df05
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.