From: Mike Galbraith <efault@gmx.de>
To: Dave Young <dyoung@redhat.com>
Cc: Baoquan He <bhe@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, kdump: Fix efi=noruntime NULL pointer dereference
Date: Wed, 15 Aug 2018 06:57:41 +0200 [thread overview]
Message-ID: <1534309061.26284.17.camel@gmx.de> (raw)
In-Reply-To: <20180815035921.GA5865@dhcp-128-65.nay.redhat.com>
On Wed, 2018-08-15 at 11:59 +0800, Dave Young wrote:
> > Does this improve things, and plug the no boot hole?
>
> Would you mind to tune my patch with some acpi_rsdp checking and add
> some error message in case kexec load failure? Eg. suggest people to use
> append acpi_rsdp for noefi booting etc.
Yeah, -ENODEV is better than hanging, but not very informative.
> I'm still not very satisfied with the code cleanup..
Not surprising, I didn't like it much either (ergo interrogative).
-Mike
prev parent reply other threads:[~2018-08-15 5:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 14:03 [PATCH] x86, kdump: Fix efi=noruntime NULL pointer dereference Mike Galbraith
2018-08-09 4:21 ` Dave Young
2018-08-09 4:21 ` Dave Young
2018-08-09 5:05 ` Mike Galbraith
2018-08-09 5:05 ` Mike Galbraith
2018-08-09 7:33 ` Mike Galbraith
2018-08-09 7:33 ` Mike Galbraith
2018-08-09 9:13 ` Dave Young
2018-08-09 9:13 ` Dave Young
2018-08-21 13:39 ` Ard Biesheuvel
2018-08-21 13:39 ` Ard Biesheuvel
2018-08-22 10:23 ` Dave Young
2018-08-22 10:23 ` Dave Young
2018-08-23 3:57 ` Dave Young
2018-08-23 3:57 ` Dave Young
2018-08-23 4:08 ` Mike Galbraith
2018-08-23 4:08 ` Mike Galbraith
2018-08-23 4:08 ` Mike Galbraith
2018-08-24 4:48 ` Mike Galbraith
2018-08-24 4:48 ` Mike Galbraith
2018-08-24 4:48 ` Mike Galbraith
2018-08-24 6:49 ` Dave Young
2018-08-24 6:49 ` Dave Young
2018-08-10 8:45 ` Dave Young
2018-08-10 10:23 ` Mike Galbraith
2018-08-10 10:28 ` Dave Young
2018-08-10 17:39 ` Mike Galbraith
2018-08-15 3:59 ` Dave Young
2018-08-15 4:57 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534309061.26284.17.camel@gmx.de \
--to=efault@gmx.de \
--cc=bhe@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=dyoung@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.