diff for duplicates of <1534408434.3432.3.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 1736f33..4b31eac 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: +On Wed, 2018-08-15 at 14:26 +0200, Noralf Trønnes wrote: > Den 14.08.2018 10.57, skrev Hean-Loong, Ong: > > > > From: Ong Hean Loong <hean.loong.ong@intel.com> @@ -12,49 +12,49 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > > > Signed-off-by: Ong Hean Loong <hean.loong.ong@intel.com> > > --- -> > ? drivers/gpu/drm/Kconfig???????????????|????2 + -> > ? drivers/gpu/drm/Makefile??????????????|????1 + -> > ? drivers/gpu/drm/ivip/Kconfig??????????|???14 +++ -> > ? drivers/gpu/drm/ivip/Makefile?????????|????9 ++ -> > ? drivers/gpu/drm/ivip/intel_vip_conn.c |???95 ++++++++++++++++ -> > ? drivers/gpu/drm/ivip/intel_vip_core.c |??161 +> > drivers/gpu/drm/Kconfig | 2 + +> > drivers/gpu/drm/Makefile | 1 + +> > drivers/gpu/drm/ivip/Kconfig | 14 +++ +> > drivers/gpu/drm/ivip/Makefile | 9 ++ +> > drivers/gpu/drm/ivip/intel_vip_conn.c | 95 ++++++++++++++++ +> > drivers/gpu/drm/ivip/intel_vip_core.c | 161 > > +++++++++++++++++++++++++++ -> > ? drivers/gpu/drm/ivip/intel_vip_drv.h??|???52 +++++++++ -> > ? drivers/gpu/drm/ivip/intel_vip_of.c???|??193 +> > drivers/gpu/drm/ivip/intel_vip_drv.h | 52 +++++++++ +> > drivers/gpu/drm/ivip/intel_vip_of.c | 193 > > +++++++++++++++++++++++++++++++++ -> > ? 8 files changed, 527 insertions(+), 0 deletions(-) -> > ? create mode 100644 drivers/gpu/drm/ivip/Kconfig -> > ? create mode 100644 drivers/gpu/drm/ivip/Makefile -> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_conn.c -> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_core.c -> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_drv.h -> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_of.c +> > 8 files changed, 527 insertions(+), 0 deletions(-) +> > create mode 100644 drivers/gpu/drm/ivip/Kconfig +> > create mode 100644 drivers/gpu/drm/ivip/Makefile +> > create mode 100644 drivers/gpu/drm/ivip/intel_vip_conn.c +> > create mode 100644 drivers/gpu/drm/ivip/intel_vip_core.c +> > create mode 100644 drivers/gpu/drm/ivip/intel_vip_drv.h +> > create mode 100644 drivers/gpu/drm/ivip/intel_vip_of.c > > > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index cb88528..6b2845b 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -215,6 +215,8 @@ source "drivers/gpu/drm/nouveau/Kconfig" -> > ?? -> > ? source "drivers/gpu/drm/i915/Kconfig" -> > ?? +> > +> > source "drivers/gpu/drm/i915/Kconfig" +> > > > +source "drivers/gpu/drm/ivip/Kconfig" > > + -> > ? config DRM_VGEM -> > ?? tristate "Virtual GEM provider" -> > ?? depends on DRM +> > config DRM_VGEM +> > tristate "Virtual GEM provider" +> > depends on DRM > > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > > index a6771ce..57205d8 100644 > > --- a/drivers/gpu/drm/Makefile > > +++ b/drivers/gpu/drm/Makefile > > @@ -61,6 +61,7 @@ obj-$(CONFIG_DRM_AMDGPU)+= amd/amdgpu/ -> > ? obj-$(CONFIG_DRM_MGA) += mga/ -> > ? obj-$(CONFIG_DRM_I810) += i810/ -> > ? obj-$(CONFIG_DRM_I915) += i915/ +> > obj-$(CONFIG_DRM_MGA) += mga/ +> > obj-$(CONFIG_DRM_I810) += i810/ +> > obj-$(CONFIG_DRM_I915) += i915/ > > +obj-$(CONFIG_DRM_IVIP) += ivip/ -> > ? obj-$(CONFIG_DRM_MGAG200) += mgag200/ -> > ? obj-$(CONFIG_DRM_V3D)??+= v3d/ -> > ? obj-$(CONFIG_DRM_VC4)??+= vc4/ +> > obj-$(CONFIG_DRM_MGAG200) += mgag200/ +> > obj-$(CONFIG_DRM_V3D) += v3d/ +> > obj-$(CONFIG_DRM_VC4) += vc4/ > > diff --git a/drivers/gpu/drm/ivip/Kconfig > > b/drivers/gpu/drm/ivip/Kconfig > > new file mode 100644 @@ -63,24 +63,24 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > +++ b/drivers/gpu/drm/ivip/Kconfig > > @@ -0,0 +1,14 @@ > > +config DRM_IVIP -> > +????????tristate "Intel FGPA Video and Image Processing" -> > +????????depends on DRM && OF -> > +????????select DRM_GEM_CMA_HELPER -> > +????????select DRM_KMS_HELPER -> > +????????select DRM_KMS_FB_HELPER -> > +????????select DRM_KMS_CMA_HELPER -> > +????????help -> > + ??Choose this option if you have an Intel FPGA +> > + tristate "Intel FGPA Video and Image Processing" +> > + depends on DRM && OF +> > + select DRM_GEM_CMA_HELPER +> > + select DRM_KMS_HELPER +> > + select DRM_KMS_FB_HELPER +> > + select DRM_KMS_CMA_HELPER +> > + help +> > + Choose this option if you have an Intel FPGA > > Arria 10 system -> > + ??and above with an Intel Display Port IP. This +> > + and above with an Intel Display Port IP. This > > does not support -> > + ??legacy Intel FPGA Cyclone V display port. +> > + legacy Intel FPGA Cyclone V display port. > > Currently only single -> > + ??frame buffer is supported. Note that ACPI and +> > + frame buffer is supported. Note that ACPI and > > X_86 architecture -> > + ??is not supported for Arria10. If M is selected +> > + is not supported for Arria10. If M is selected > > the module will be -> > + ??called ivip. +> > + called ivip. > > diff --git a/drivers/gpu/drm/ivip/Makefile > > b/drivers/gpu/drm/ivip/Makefile > > new file mode 100644 @@ -89,7 +89,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > +++ b/drivers/gpu/drm/ivip/Makefile > > @@ -0,0 +1,9 @@ > > +# -> > +# Makefile for the drm device driver.??This driver provides +> > +# Makefile for the drm device driver. This driver provides > > support for the > > +# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and > > higher. @@ -139,7 +139,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > WITHOUT > > + * ANY WARRANTY; without even the implied warranty of > > MERCHANTABILITY or -> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public +> > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public > > License for > > + * more details. > > + * @@ -187,10 +187,10 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > + > > + count = drm_add_modes_noedid(connector, drm- > > >mode_config.max_width, -> > + ?????drm->mode_config.max_height); +> > + drm->mode_config.max_height); > > + drm_set_preferred_mode(connector, drm- > > >mode_config.max_width, -> > + ???????drm->mode_config.max_height); +> > + drm->mode_config.max_height); > > + return count; > > +} > > + @@ -211,7 +211,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > + > > + ret = drm_connector_init(drm, conn, > > &intelvipfb_drm_connector_funcs, -> > + ?DRM_MODE_CONNECTOR_DisplayPort); +> > + DRM_MODE_CONNECTOR_DisplayPort); > > + if (ret < 0) { > > + dev_err(drm->dev, "failed to initialize drm > > connector\n"); @@ -259,7 +259,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > WITHOUT > > + * ANY WARRANTY; without even the implied warranty of > > MERCHANTABILITY or -> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public +> > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public > > License for > > + * more details. > > + * @@ -287,16 +287,16 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > + > > +static void intelvipfb_enable(struct drm_simple_display_pipe > > *pipe, -> > + ??????struct drm_crtc_state *crtc_state, +> > + struct drm_crtc_state *crtc_state, > > struct drm_plane_state *plane_state) > > +{ > > + /* -> > + ?* The frameinfo variable has to correspond to the size of +> > + * The frameinfo variable has to correspond to the size of > > the VIP Suite -> > + ?* Frame Reader register 7 which will determine the +> > + * Frame Reader register 7 which will determine the > > maximum size used -> > + ?* in this frameinfo -> > + ?*/ +> > + * in this frameinfo +> > + */ > > + > > + u32 frameinfo; > > + struct intelvipfb_priv *priv = pipe->plane.dev- @@ -342,7 +342,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > + > > +static int intelvipfb_pipe_prepare_fb(struct > > drm_simple_display_pipe *pipe, -> > + ??????struct drm_plane_state +> > + struct drm_plane_state > > *plane_state) > > +{ > > + return drm_gem_fb_prepare_fb(&pipe->plane, plane_state); @@ -380,7 +380,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > + } > > + > > + retval = drm_simple_display_pipe_init(drm, &fbpriv->pipe, -> > + ??????&fbpriv_funcs, +> > + &fbpriv_funcs, > > formats, > > + ARRAY_SIZE(formats), NULL, connector); > > + if (retval < 0) { @@ -402,9 +402,9 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > Noralf. > I could not find any examples that currently uses -the?drm_fbdev_generic_setup (). Would you mind pointing me on where +the drm_fbdev_generic_setup (). Would you mind pointing me on where such examples are available that would allow me to replace the -assignment of the fbcma pointer with?drm_fbdev_generic_setup() method +assignment of the fbcma pointer with drm_fbdev_generic_setup() method Thanks. Hean Loong. @@ -426,7 +426,7 @@ Hean Loong. > > +int intelvipfb_remove(struct device *dev) > > +{ > > + struct intelvipfb_priv *fbpriv = dev_get_drvdata(dev); -> > + struct drm_device *drm =??fbpriv->drm; +> > + struct drm_device *drm = fbpriv->drm; > > + > > + drm_dev_unregister(drm); > > + @@ -464,13 +464,13 @@ Hean Loong. > > WITHOUT > > + * ANY WARRANTY; without even the implied warranty of > > MERCHANTABILITY or -> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public +> > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public > > License for > > + * more details. > > + * > > + * You should have received a copy of the GNU General Public > > License along with -> > + * this program.??If not, see <http://www.gnu.org/licenses/>. +> > + * this program. If not, see <http://www.gnu.org/licenses/>. > > + * > > + * Authors: > > + * Ong, Hean-Loong <hean.loong.ong@intel.com> @@ -479,20 +479,20 @@ Hean Loong. > > +#ifndef _INTEL_VIP_DRV_H > > +#define _INTEL_VIP_DRV_H > > + -> > +#define DRIVER_NAME????"intelvipfb" -> > +#define BYTES_PER_PIXEL ?4 -> > +#define CRTC_NUM ????????1 -> > +#define CONN_NUM ????????1 +> > +#define DRIVER_NAME "intelvipfb" +> > +#define BYTES_PER_PIXEL 4 +> > +#define CRTC_NUM 1 +> > +#define CONN_NUM 1 > > + > > +/* control registers */ -> > +#define INTELVIPFB_CONTROL ??????0 -> > +#define INTELVIPFB_STATUS ???????0x4 -> > +#define INTELVIPFB_INTERRUPT ????0x8 +> > +#define INTELVIPFB_CONTROL 0 +> > +#define INTELVIPFB_STATUS 0x4 +> > +#define INTELVIPFB_INTERRUPT 0x8 > > +#define INTELVIPFB_FRAME_COUNTER 0xC -> > +#define INTELVIPFB_FRAME_DROP ???0x10 -> > +#define INTELVIPFB_FRAME_INFO ???0x14 -> > +#define INTELVIPFB_FRAME_START ??0x18 -> > +#define INTELVIPFB_FRAME_READER ?????????0x1C +> > +#define INTELVIPFB_FRAME_DROP 0x10 +> > +#define INTELVIPFB_FRAME_INFO 0x14 +> > +#define INTELVIPFB_FRAME_START 0x18 +> > +#define INTELVIPFB_FRAME_READER 0x1C > > + > > +int intelvipfb_probe(struct device *dev); > > +int intelvipfb_remove(struct device *dev); @@ -504,7 +504,7 @@ Hean Loong. > > + struct drm_simple_display_pipe pipe; > > + struct drm_fbdev_cma *fbcma; > > + struct drm_device *drm; -> > + void????__iomem *base; +> > + void __iomem *base; > > +}; > > + > > +#endif @@ -534,7 +534,7 @@ Hean Loong. > > WITHOUT > > + * ANY WARRANTY; without even the implied warranty of > > MERCHANTABILITY or -> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public +> > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public > > License for > > + * more details. > > + * @@ -636,7 +636,7 @@ Hean Loong. > > + dev_err(dev, > > + "mem-word-width is set to %i. must be >= > > 32 and multiple of 32.", -> > + ?mem_word_width); +> > + mem_word_width); > > + return -ENODEV; > > + } > > + @@ -720,3 +720,7 @@ Hean Loong. > > +}; > > + > > +module_platform_driver(intelvipfb_driver); +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N1/content_digest index 04f2243..e0ec017 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,13 +1,22 @@ "ref\01534237029-2648-1-git-send-email-hean.loong.ong@intel.com\0" "ref\01534237029-2648-4-git-send-email-hean.loong.ong@intel.com\0" "ref\028d5e08c-4ae2-2d09-6ce4-985578535d34@tronnes.org\0" - "From\0hean.loong.ong@intel.com (Ong, Hean Loong)\0" - "Subject\0[PATCH10 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite\0" + "From\0Ong, Hean Loong <hean.loong.ong@intel.com>\0" + "Subject\0Re: [PATCH10 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite\0" "Date\0Thu, 16 Aug 2018 08:33:54 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0noralf@tronnes.org <noralf@tronnes.org>" + " airlied@linux.ie <airlied@linux.ie>\0" + "Cc\0devicetree@vger.kernel.org <devicetree@vger.kernel.org>" + Vandervennet + Yves <yves.vandervennet@intel.com> + See + Chin Liang <chin.liang.see@intel.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org> + " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" "\00:1\0" "b\0" - "On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote:\n" + "On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr\303\270nnes wrote:\n" "> Den 14.08.2018 10.57, skrev Hean-Loong, Ong:\n" "> > \n" "> > From: Ong Hean Loong <hean.loong.ong@intel.com>\n" @@ -21,49 +30,49 @@ "> > \n" "> > Signed-off-by: Ong Hean Loong <hean.loong.ong@intel.com>\n" "> > ---\n" - "> > ? drivers/gpu/drm/Kconfig???????????????|????2 +\n" - "> > ? drivers/gpu/drm/Makefile??????????????|????1 +\n" - "> > ? drivers/gpu/drm/ivip/Kconfig??????????|???14 +++\n" - "> > ? drivers/gpu/drm/ivip/Makefile?????????|????9 ++\n" - "> > ? drivers/gpu/drm/ivip/intel_vip_conn.c |???95 ++++++++++++++++\n" - "> > ? drivers/gpu/drm/ivip/intel_vip_core.c |??161\n" + "> > \302\240 drivers/gpu/drm/Kconfig\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\240\302\240\302\2402 +\n" + "> > \302\240 drivers/gpu/drm/Makefile\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\240\302\240\302\2401 +\n" + "> > \302\240 drivers/gpu/drm/ivip/Kconfig\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\240\302\24014 +++\n" + "> > \302\240 drivers/gpu/drm/ivip/Makefile\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\240\302\240\302\2409 ++\n" + "> > \302\240 drivers/gpu/drm/ivip/intel_vip_conn.c |\302\240\302\240\302\24095 ++++++++++++++++\n" + "> > \302\240 drivers/gpu/drm/ivip/intel_vip_core.c |\302\240\302\240161\n" "> > +++++++++++++++++++++++++++\n" - "> > ? drivers/gpu/drm/ivip/intel_vip_drv.h??|???52 +++++++++\n" - "> > ? drivers/gpu/drm/ivip/intel_vip_of.c???|??193\n" + "> > \302\240 drivers/gpu/drm/ivip/intel_vip_drv.h\302\240\302\240|\302\240\302\240\302\24052 +++++++++\n" + "> > \302\240 drivers/gpu/drm/ivip/intel_vip_of.c\302\240\302\240\302\240|\302\240\302\240193\n" "> > +++++++++++++++++++++++++++++++++\n" - "> > ? 8 files changed, 527 insertions(+), 0 deletions(-)\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/Kconfig\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/Makefile\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_conn.c\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_core.c\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_drv.h\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_of.c\n" + "> > \302\240 8 files changed, 527 insertions(+), 0 deletions(-)\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/Kconfig\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/Makefile\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/intel_vip_conn.c\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/intel_vip_core.c\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/intel_vip_drv.h\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/intel_vip_of.c\n" "> > \n" "> > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig\n" "> > index cb88528..6b2845b 100644\n" "> > --- a/drivers/gpu/drm/Kconfig\n" "> > +++ b/drivers/gpu/drm/Kconfig\n" "> > @@ -215,6 +215,8 @@ source \"drivers/gpu/drm/nouveau/Kconfig\"\n" - "> > ??\n" - "> > ? source \"drivers/gpu/drm/i915/Kconfig\"\n" - "> > ??\n" + "> > \302\240\302\240\n" + "> > \302\240 source \"drivers/gpu/drm/i915/Kconfig\"\n" + "> > \302\240\302\240\n" "> > +source \"drivers/gpu/drm/ivip/Kconfig\"\n" "> > +\n" - "> > ? config DRM_VGEM\n" - "> > ??\ttristate \"Virtual GEM provider\"\n" - "> > ??\tdepends on DRM\n" + "> > \302\240 config DRM_VGEM\n" + "> > \302\240\302\240\ttristate \"Virtual GEM provider\"\n" + "> > \302\240\302\240\tdepends on DRM\n" "> > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile\n" "> > index a6771ce..57205d8 100644\n" "> > --- a/drivers/gpu/drm/Makefile\n" "> > +++ b/drivers/gpu/drm/Makefile\n" "> > @@ -61,6 +61,7 @@ obj-$(CONFIG_DRM_AMDGPU)+= amd/amdgpu/\n" - "> > ? obj-$(CONFIG_DRM_MGA)\t+= mga/\n" - "> > ? obj-$(CONFIG_DRM_I810)\t+= i810/\n" - "> > ? obj-$(CONFIG_DRM_I915)\t+= i915/\n" + "> > \302\240 obj-$(CONFIG_DRM_MGA)\t+= mga/\n" + "> > \302\240 obj-$(CONFIG_DRM_I810)\t+= i810/\n" + "> > \302\240 obj-$(CONFIG_DRM_I915)\t+= i915/\n" "> > +obj-$(CONFIG_DRM_IVIP)\t+= ivip/\n" - "> > ? obj-$(CONFIG_DRM_MGAG200) += mgag200/\n" - "> > ? obj-$(CONFIG_DRM_V3D)??+= v3d/\n" - "> > ? obj-$(CONFIG_DRM_VC4)??+= vc4/\n" + "> > \302\240 obj-$(CONFIG_DRM_MGAG200) += mgag200/\n" + "> > \302\240 obj-$(CONFIG_DRM_V3D)\302\240\302\240+= v3d/\n" + "> > \302\240 obj-$(CONFIG_DRM_VC4)\302\240\302\240+= vc4/\n" "> > diff --git a/drivers/gpu/drm/ivip/Kconfig\n" "> > b/drivers/gpu/drm/ivip/Kconfig\n" "> > new file mode 100644\n" @@ -72,24 +81,24 @@ "> > +++ b/drivers/gpu/drm/ivip/Kconfig\n" "> > @@ -0,0 +1,14 @@\n" "> > +config DRM_IVIP\n" - "> > +????????tristate \"Intel FGPA Video and Image Processing\"\n" - "> > +????????depends on DRM && OF\n" - "> > +????????select DRM_GEM_CMA_HELPER\n" - "> > +????????select DRM_KMS_HELPER\n" - "> > +????????select DRM_KMS_FB_HELPER\n" - "> > +????????select DRM_KMS_CMA_HELPER\n" - "> > +????????help\n" - "> > +\t\t??Choose this option if you have an Intel FPGA\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240tristate \"Intel FGPA Video and Image Processing\"\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240depends on DRM && OF\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240select DRM_GEM_CMA_HELPER\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240select DRM_KMS_HELPER\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240select DRM_KMS_FB_HELPER\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240select DRM_KMS_CMA_HELPER\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240help\n" + "> > +\t\t\302\240\302\240Choose this option if you have an Intel FPGA\n" "> > Arria 10 system\n" - "> > +\t\t??and above with an Intel Display Port IP. This\n" + "> > +\t\t\302\240\302\240and above with an Intel Display Port IP. This\n" "> > does not support\n" - "> > +\t\t??legacy Intel FPGA Cyclone V display port.\n" + "> > +\t\t\302\240\302\240legacy Intel FPGA Cyclone V display port.\n" "> > Currently only single\n" - "> > +\t\t??frame buffer is supported. Note that ACPI and\n" + "> > +\t\t\302\240\302\240frame buffer is supported. Note that ACPI and\n" "> > X_86 architecture\n" - "> > +\t\t??is not supported for Arria10. If M is selected\n" + "> > +\t\t\302\240\302\240is not supported for Arria10. If M is selected\n" "> > the module will be\n" - "> > +\t\t??called ivip.\n" + "> > +\t\t\302\240\302\240called ivip.\n" "> > diff --git a/drivers/gpu/drm/ivip/Makefile\n" "> > b/drivers/gpu/drm/ivip/Makefile\n" "> > new file mode 100644\n" @@ -98,7 +107,7 @@ "> > +++ b/drivers/gpu/drm/ivip/Makefile\n" "> > @@ -0,0 +1,9 @@\n" "> > +#\n" - "> > +# Makefile for the drm device driver.??This driver provides\n" + "> > +# Makefile for the drm device driver.\302\240\302\240This driver provides\n" "> > support for the\n" "> > +# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and\n" "> > higher.\n" @@ -148,7 +157,7 @@ "> > WITHOUT\n" "> > + * ANY WARRANTY; without even the implied warranty of\n" "> > MERCHANTABILITY or\n" - "> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public\n" + "> > + * FITNESS FOR A PARTICULAR PURPOSE.\302\240\302\240See the GNU General Public\n" "> > License for\n" "> > + * more details.\n" "> > + *\n" @@ -196,10 +205,10 @@ "> > +\n" "> > +\tcount = drm_add_modes_noedid(connector, drm-\n" "> > >mode_config.max_width,\n" - "> > +\t\t\t\t?????drm->mode_config.max_height);\n" + "> > +\t\t\t\t\302\240\302\240\302\240\302\240\302\240drm->mode_config.max_height);\n" "> > +\tdrm_set_preferred_mode(connector, drm-\n" "> > >mode_config.max_width,\n" - "> > +\t\t\t???????drm->mode_config.max_height);\n" + "> > +\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240drm->mode_config.max_height);\n" "> > +\treturn count;\n" "> > +}\n" "> > +\n" @@ -220,7 +229,7 @@ "> > +\n" "> > +\tret = drm_connector_init(drm, conn,\n" "> > &intelvipfb_drm_connector_funcs,\n" - "> > +\t\t\t\t?DRM_MODE_CONNECTOR_DisplayPort);\n" + "> > +\t\t\t\t\302\240DRM_MODE_CONNECTOR_DisplayPort);\n" "> > +\tif (ret < 0) {\n" "> > +\t\tdev_err(drm->dev, \"failed to initialize drm\n" "> > connector\\n\");\n" @@ -268,7 +277,7 @@ "> > WITHOUT\n" "> > + * ANY WARRANTY; without even the implied warranty of\n" "> > MERCHANTABILITY or\n" - "> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public\n" + "> > + * FITNESS FOR A PARTICULAR PURPOSE.\302\240\302\240See the GNU General Public\n" "> > License for\n" "> > + * more details.\n" "> > + *\n" @@ -296,16 +305,16 @@ "> > +\n" "> > +static void intelvipfb_enable(struct drm_simple_display_pipe\n" "> > *pipe,\n" - "> > +\t\t\t??????struct drm_crtc_state *crtc_state,\n" + "> > +\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240struct drm_crtc_state *crtc_state,\n" "> > struct drm_plane_state *plane_state)\n" "> > +{\n" "> > +\t/*\n" - "> > +\t?* The frameinfo variable has to correspond to the size of\n" + "> > +\t\302\240* The frameinfo variable has to correspond to the size of\n" "> > the VIP Suite\n" - "> > +\t?* Frame Reader register 7 which will determine the\n" + "> > +\t\302\240* Frame Reader register 7 which will determine the\n" "> > maximum size used\n" - "> > +\t?* in this frameinfo\n" - "> > +\t?*/\n" + "> > +\t\302\240* in this frameinfo\n" + "> > +\t\302\240*/\n" "> > +\n" "> > +\tu32 frameinfo;\n" "> > +\tstruct intelvipfb_priv *priv = pipe->plane.dev-\n" @@ -351,7 +360,7 @@ "> > +\n" "> > +static int intelvipfb_pipe_prepare_fb(struct\n" "> > drm_simple_display_pipe *pipe,\n" - "> > +\t\t\t\t??????struct drm_plane_state\n" + "> > +\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240struct drm_plane_state\n" "> > *plane_state)\n" "> > +{\n" "> > +\treturn drm_gem_fb_prepare_fb(&pipe->plane, plane_state);\n" @@ -389,7 +398,7 @@ "> > +\t}\n" "> > +\n" "> > +\tretval = drm_simple_display_pipe_init(drm, &fbpriv->pipe,\n" - "> > +\t\t\t\t\t??????&fbpriv_funcs,\n" + "> > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240&fbpriv_funcs,\n" "> > formats,\n" "> > +\t\t\tARRAY_SIZE(formats), NULL, connector);\n" "> > +\tif (retval < 0) {\n" @@ -411,9 +420,9 @@ "> Noralf.\n" "> \n" "I could not find any examples that currently uses\n" - "the?drm_fbdev_generic_setup (). Would you mind pointing me on where\n" + "the\302\240drm_fbdev_generic_setup (). Would you mind pointing me on where\n" "such examples are available that would allow me to replace the\n" - "assignment of the fbcma pointer with?drm_fbdev_generic_setup() method\n" + "assignment of the fbcma pointer with\302\240drm_fbdev_generic_setup() method\n" "\n" "Thanks.\n" "Hean Loong.\n" @@ -435,7 +444,7 @@ "> > +int intelvipfb_remove(struct device *dev)\n" "> > +{\n" "> > +\tstruct intelvipfb_priv *fbpriv = dev_get_drvdata(dev);\n" - "> > +\tstruct drm_device *drm =??fbpriv->drm;\n" + "> > +\tstruct drm_device *drm =\302\240\302\240fbpriv->drm;\n" "> > +\n" "> > +\tdrm_dev_unregister(drm);\n" "> > +\n" @@ -473,13 +482,13 @@ "> > WITHOUT\n" "> > + * ANY WARRANTY; without even the implied warranty of\n" "> > MERCHANTABILITY or\n" - "> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public\n" + "> > + * FITNESS FOR A PARTICULAR PURPOSE.\302\240\302\240See the GNU General Public\n" "> > License for\n" "> > + * more details.\n" "> > + *\n" "> > + * You should have received a copy of the GNU General Public\n" "> > License along with\n" - "> > + * this program.??If not, see <http://www.gnu.org/licenses/>.\n" + "> > + * this program.\302\240\302\240If not, see <http://www.gnu.org/licenses/>.\n" "> > + *\n" "> > + * Authors:\n" "> > + * Ong, Hean-Loong <hean.loong.ong@intel.com>\n" @@ -488,20 +497,20 @@ "> > +#ifndef _INTEL_VIP_DRV_H\n" "> > +#define _INTEL_VIP_DRV_H\n" "> > +\n" - "> > +#define DRIVER_NAME????\"intelvipfb\"\n" - "> > +#define BYTES_PER_PIXEL\t?4\n" - "> > +#define CRTC_NUM\t????????1\n" - "> > +#define CONN_NUM\t????????1\n" + "> > +#define DRIVER_NAME\302\240\302\240\302\240\302\240\"intelvipfb\"\n" + "> > +#define BYTES_PER_PIXEL\t\302\2404\n" + "> > +#define CRTC_NUM\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\2401\n" + "> > +#define CONN_NUM\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\2401\n" "> > +\n" "> > +/* control registers */\n" - "> > +#define INTELVIPFB_CONTROL\t??????0\n" - "> > +#define INTELVIPFB_STATUS\t???????0x4\n" - "> > +#define INTELVIPFB_INTERRUPT\t????0x8\n" + "> > +#define INTELVIPFB_CONTROL\t\302\240\302\240\302\240\302\240\302\240\302\2400\n" + "> > +#define INTELVIPFB_STATUS\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x4\n" + "> > +#define INTELVIPFB_INTERRUPT\t\302\240\302\240\302\240\302\2400x8\n" "> > +#define INTELVIPFB_FRAME_COUNTER\t0xC\n" - "> > +#define INTELVIPFB_FRAME_DROP\t???0x10\n" - "> > +#define INTELVIPFB_FRAME_INFO\t???0x14\n" - "> > +#define INTELVIPFB_FRAME_START\t??0x18\n" - "> > +#define INTELVIPFB_FRAME_READER\t?????????0x1C\n" + "> > +#define INTELVIPFB_FRAME_DROP\t\302\240\302\240\302\2400x10\n" + "> > +#define INTELVIPFB_FRAME_INFO\t\302\240\302\240\302\2400x14\n" + "> > +#define INTELVIPFB_FRAME_START\t\302\240\302\2400x18\n" + "> > +#define INTELVIPFB_FRAME_READER\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x1C\n" "> > +\n" "> > +int intelvipfb_probe(struct device *dev);\n" "> > +int intelvipfb_remove(struct device *dev);\n" @@ -513,7 +522,7 @@ "> > +\tstruct drm_simple_display_pipe pipe;\n" "> > +\tstruct drm_fbdev_cma *fbcma;\n" "> > +\tstruct drm_device *drm;\n" - "> > +\tvoid????__iomem *base;\n" + "> > +\tvoid\302\240\302\240\302\240\302\240__iomem *base;\n" "> > +};\n" "> > +\n" "> > +#endif\n" @@ -543,7 +552,7 @@ "> > WITHOUT\n" "> > + * ANY WARRANTY; without even the implied warranty of\n" "> > MERCHANTABILITY or\n" - "> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public\n" + "> > + * FITNESS FOR A PARTICULAR PURPOSE.\302\240\302\240See the GNU General Public\n" "> > License for\n" "> > + * more details.\n" "> > + *\n" @@ -645,7 +654,7 @@ "> > +\t\tdev_err(dev,\n" "> > +\t\t\t\"mem-word-width is set to %i. must be >=\n" "> > 32 and multiple of 32.\",\n" - "> > +\t\t\t?mem_word_width);\n" + "> > +\t\t\t\302\240mem_word_width);\n" "> > +\t\treturn -ENODEV;\n" "> > +\t}\n" "> > +\n" @@ -728,6 +737,10 @@ "> > +\t},\n" "> > +};\n" "> > +\n" - > > +module_platform_driver(intelvipfb_driver); + "> > +module_platform_driver(intelvipfb_driver);\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -5c599106e09eb50a9c12858ea0d0597b63588bb7079d4e90c42ee93f1972f702 +55e12c56e8bca3650b2314671bd0afe168549da398393898bd243268e82137ad
diff --git a/a/1.txt b/N2/1.txt index 1736f33..f3d02df 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,4 +1,4 @@ -On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: +On Wed, 2018-08-15 at 14:26 +0200, Noralf Trønnes wrote: > Den 14.08.2018 10.57, skrev Hean-Loong, Ong: > > > > From: Ong Hean Loong <hean.loong.ong@intel.com> @@ -12,49 +12,49 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > > > Signed-off-by: Ong Hean Loong <hean.loong.ong@intel.com> > > --- -> > ? drivers/gpu/drm/Kconfig???????????????|????2 + -> > ? drivers/gpu/drm/Makefile??????????????|????1 + -> > ? drivers/gpu/drm/ivip/Kconfig??????????|???14 +++ -> > ? drivers/gpu/drm/ivip/Makefile?????????|????9 ++ -> > ? drivers/gpu/drm/ivip/intel_vip_conn.c |???95 ++++++++++++++++ -> > ? drivers/gpu/drm/ivip/intel_vip_core.c |??161 +> > drivers/gpu/drm/Kconfig | 2 + +> > drivers/gpu/drm/Makefile | 1 + +> > drivers/gpu/drm/ivip/Kconfig | 14 +++ +> > drivers/gpu/drm/ivip/Makefile | 9 ++ +> > drivers/gpu/drm/ivip/intel_vip_conn.c | 95 ++++++++++++++++ +> > drivers/gpu/drm/ivip/intel_vip_core.c | 161 > > +++++++++++++++++++++++++++ -> > ? drivers/gpu/drm/ivip/intel_vip_drv.h??|???52 +++++++++ -> > ? drivers/gpu/drm/ivip/intel_vip_of.c???|??193 +> > drivers/gpu/drm/ivip/intel_vip_drv.h | 52 +++++++++ +> > drivers/gpu/drm/ivip/intel_vip_of.c | 193 > > +++++++++++++++++++++++++++++++++ -> > ? 8 files changed, 527 insertions(+), 0 deletions(-) -> > ? create mode 100644 drivers/gpu/drm/ivip/Kconfig -> > ? create mode 100644 drivers/gpu/drm/ivip/Makefile -> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_conn.c -> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_core.c -> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_drv.h -> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_of.c +> > 8 files changed, 527 insertions(+), 0 deletions(-) +> > create mode 100644 drivers/gpu/drm/ivip/Kconfig +> > create mode 100644 drivers/gpu/drm/ivip/Makefile +> > create mode 100644 drivers/gpu/drm/ivip/intel_vip_conn.c +> > create mode 100644 drivers/gpu/drm/ivip/intel_vip_core.c +> > create mode 100644 drivers/gpu/drm/ivip/intel_vip_drv.h +> > create mode 100644 drivers/gpu/drm/ivip/intel_vip_of.c > > > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > > index cb88528..6b2845b 100644 > > --- a/drivers/gpu/drm/Kconfig > > +++ b/drivers/gpu/drm/Kconfig > > @@ -215,6 +215,8 @@ source "drivers/gpu/drm/nouveau/Kconfig" -> > ?? -> > ? source "drivers/gpu/drm/i915/Kconfig" -> > ?? +> > +> > source "drivers/gpu/drm/i915/Kconfig" +> > > > +source "drivers/gpu/drm/ivip/Kconfig" > > + -> > ? config DRM_VGEM -> > ?? tristate "Virtual GEM provider" -> > ?? depends on DRM +> > config DRM_VGEM +> > tristate "Virtual GEM provider" +> > depends on DRM > > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > > index a6771ce..57205d8 100644 > > --- a/drivers/gpu/drm/Makefile > > +++ b/drivers/gpu/drm/Makefile > > @@ -61,6 +61,7 @@ obj-$(CONFIG_DRM_AMDGPU)+= amd/amdgpu/ -> > ? obj-$(CONFIG_DRM_MGA) += mga/ -> > ? obj-$(CONFIG_DRM_I810) += i810/ -> > ? obj-$(CONFIG_DRM_I915) += i915/ +> > obj-$(CONFIG_DRM_MGA) += mga/ +> > obj-$(CONFIG_DRM_I810) += i810/ +> > obj-$(CONFIG_DRM_I915) += i915/ > > +obj-$(CONFIG_DRM_IVIP) += ivip/ -> > ? obj-$(CONFIG_DRM_MGAG200) += mgag200/ -> > ? obj-$(CONFIG_DRM_V3D)??+= v3d/ -> > ? obj-$(CONFIG_DRM_VC4)??+= vc4/ +> > obj-$(CONFIG_DRM_MGAG200) += mgag200/ +> > obj-$(CONFIG_DRM_V3D) += v3d/ +> > obj-$(CONFIG_DRM_VC4) += vc4/ > > diff --git a/drivers/gpu/drm/ivip/Kconfig > > b/drivers/gpu/drm/ivip/Kconfig > > new file mode 100644 @@ -63,24 +63,24 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > +++ b/drivers/gpu/drm/ivip/Kconfig > > @@ -0,0 +1,14 @@ > > +config DRM_IVIP -> > +????????tristate "Intel FGPA Video and Image Processing" -> > +????????depends on DRM && OF -> > +????????select DRM_GEM_CMA_HELPER -> > +????????select DRM_KMS_HELPER -> > +????????select DRM_KMS_FB_HELPER -> > +????????select DRM_KMS_CMA_HELPER -> > +????????help -> > + ??Choose this option if you have an Intel FPGA +> > + tristate "Intel FGPA Video and Image Processing" +> > + depends on DRM && OF +> > + select DRM_GEM_CMA_HELPER +> > + select DRM_KMS_HELPER +> > + select DRM_KMS_FB_HELPER +> > + select DRM_KMS_CMA_HELPER +> > + help +> > + Choose this option if you have an Intel FPGA > > Arria 10 system -> > + ??and above with an Intel Display Port IP. This +> > + and above with an Intel Display Port IP. This > > does not support -> > + ??legacy Intel FPGA Cyclone V display port. +> > + legacy Intel FPGA Cyclone V display port. > > Currently only single -> > + ??frame buffer is supported. Note that ACPI and +> > + frame buffer is supported. Note that ACPI and > > X_86 architecture -> > + ??is not supported for Arria10. If M is selected +> > + is not supported for Arria10. If M is selected > > the module will be -> > + ??called ivip. +> > + called ivip. > > diff --git a/drivers/gpu/drm/ivip/Makefile > > b/drivers/gpu/drm/ivip/Makefile > > new file mode 100644 @@ -89,7 +89,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > +++ b/drivers/gpu/drm/ivip/Makefile > > @@ -0,0 +1,9 @@ > > +# -> > +# Makefile for the drm device driver.??This driver provides +> > +# Makefile for the drm device driver. This driver provides > > support for the > > +# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and > > higher. @@ -139,7 +139,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > WITHOUT > > + * ANY WARRANTY; without even the implied warranty of > > MERCHANTABILITY or -> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public +> > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public > > License for > > + * more details. > > + * @@ -187,10 +187,10 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > + > > + count = drm_add_modes_noedid(connector, drm- > > >mode_config.max_width, -> > + ?????drm->mode_config.max_height); +> > + drm->mode_config.max_height); > > + drm_set_preferred_mode(connector, drm- > > >mode_config.max_width, -> > + ???????drm->mode_config.max_height); +> > + drm->mode_config.max_height); > > + return count; > > +} > > + @@ -211,7 +211,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > + > > + ret = drm_connector_init(drm, conn, > > &intelvipfb_drm_connector_funcs, -> > + ?DRM_MODE_CONNECTOR_DisplayPort); +> > + DRM_MODE_CONNECTOR_DisplayPort); > > + if (ret < 0) { > > + dev_err(drm->dev, "failed to initialize drm > > connector\n"); @@ -259,7 +259,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > WITHOUT > > + * ANY WARRANTY; without even the implied warranty of > > MERCHANTABILITY or -> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public +> > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public > > License for > > + * more details. > > + * @@ -287,16 +287,16 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > + > > +static void intelvipfb_enable(struct drm_simple_display_pipe > > *pipe, -> > + ??????struct drm_crtc_state *crtc_state, +> > + struct drm_crtc_state *crtc_state, > > struct drm_plane_state *plane_state) > > +{ > > + /* -> > + ?* The frameinfo variable has to correspond to the size of +> > + * The frameinfo variable has to correspond to the size of > > the VIP Suite -> > + ?* Frame Reader register 7 which will determine the +> > + * Frame Reader register 7 which will determine the > > maximum size used -> > + ?* in this frameinfo -> > + ?*/ +> > + * in this frameinfo +> > + */ > > + > > + u32 frameinfo; > > + struct intelvipfb_priv *priv = pipe->plane.dev- @@ -342,7 +342,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > + > > +static int intelvipfb_pipe_prepare_fb(struct > > drm_simple_display_pipe *pipe, -> > + ??????struct drm_plane_state +> > + struct drm_plane_state > > *plane_state) > > +{ > > + return drm_gem_fb_prepare_fb(&pipe->plane, plane_state); @@ -380,7 +380,7 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > > + } > > + > > + retval = drm_simple_display_pipe_init(drm, &fbpriv->pipe, -> > + ??????&fbpriv_funcs, +> > + &fbpriv_funcs, > > formats, > > + ARRAY_SIZE(formats), NULL, connector); > > + if (retval < 0) { @@ -402,9 +402,9 @@ On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote: > Noralf. > I could not find any examples that currently uses -the?drm_fbdev_generic_setup (). Would you mind pointing me on where +the drm_fbdev_generic_setup (). Would you mind pointing me on where such examples are available that would allow me to replace the -assignment of the fbcma pointer with?drm_fbdev_generic_setup() method +assignment of the fbcma pointer with drm_fbdev_generic_setup() method Thanks. Hean Loong. @@ -426,7 +426,7 @@ Hean Loong. > > +int intelvipfb_remove(struct device *dev) > > +{ > > + struct intelvipfb_priv *fbpriv = dev_get_drvdata(dev); -> > + struct drm_device *drm =??fbpriv->drm; +> > + struct drm_device *drm = fbpriv->drm; > > + > > + drm_dev_unregister(drm); > > + @@ -464,13 +464,13 @@ Hean Loong. > > WITHOUT > > + * ANY WARRANTY; without even the implied warranty of > > MERCHANTABILITY or -> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public +> > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public > > License for > > + * more details. > > + * > > + * You should have received a copy of the GNU General Public > > License along with -> > + * this program.??If not, see <http://www.gnu.org/licenses/>. +> > + * this program. If not, see <http://www.gnu.org/licenses/>. > > + * > > + * Authors: > > + * Ong, Hean-Loong <hean.loong.ong@intel.com> @@ -479,20 +479,20 @@ Hean Loong. > > +#ifndef _INTEL_VIP_DRV_H > > +#define _INTEL_VIP_DRV_H > > + -> > +#define DRIVER_NAME????"intelvipfb" -> > +#define BYTES_PER_PIXEL ?4 -> > +#define CRTC_NUM ????????1 -> > +#define CONN_NUM ????????1 +> > +#define DRIVER_NAME "intelvipfb" +> > +#define BYTES_PER_PIXEL 4 +> > +#define CRTC_NUM 1 +> > +#define CONN_NUM 1 > > + > > +/* control registers */ -> > +#define INTELVIPFB_CONTROL ??????0 -> > +#define INTELVIPFB_STATUS ???????0x4 -> > +#define INTELVIPFB_INTERRUPT ????0x8 +> > +#define INTELVIPFB_CONTROL 0 +> > +#define INTELVIPFB_STATUS 0x4 +> > +#define INTELVIPFB_INTERRUPT 0x8 > > +#define INTELVIPFB_FRAME_COUNTER 0xC -> > +#define INTELVIPFB_FRAME_DROP ???0x10 -> > +#define INTELVIPFB_FRAME_INFO ???0x14 -> > +#define INTELVIPFB_FRAME_START ??0x18 -> > +#define INTELVIPFB_FRAME_READER ?????????0x1C +> > +#define INTELVIPFB_FRAME_DROP 0x10 +> > +#define INTELVIPFB_FRAME_INFO 0x14 +> > +#define INTELVIPFB_FRAME_START 0x18 +> > +#define INTELVIPFB_FRAME_READER 0x1C > > + > > +int intelvipfb_probe(struct device *dev); > > +int intelvipfb_remove(struct device *dev); @@ -504,7 +504,7 @@ Hean Loong. > > + struct drm_simple_display_pipe pipe; > > + struct drm_fbdev_cma *fbcma; > > + struct drm_device *drm; -> > + void????__iomem *base; +> > + void __iomem *base; > > +}; > > + > > +#endif @@ -534,7 +534,7 @@ Hean Loong. > > WITHOUT > > + * ANY WARRANTY; without even the implied warranty of > > MERCHANTABILITY or -> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public +> > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public > > License for > > + * more details. > > + * @@ -636,7 +636,7 @@ Hean Loong. > > + dev_err(dev, > > + "mem-word-width is set to %i. must be >= > > 32 and multiple of 32.", -> > + ?mem_word_width); +> > + mem_word_width); > > + return -ENODEV; > > + } > > + diff --git a/a/content_digest b/N2/content_digest index 04f2243..9cff048 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,13 +1,22 @@ "ref\01534237029-2648-1-git-send-email-hean.loong.ong@intel.com\0" "ref\01534237029-2648-4-git-send-email-hean.loong.ong@intel.com\0" "ref\028d5e08c-4ae2-2d09-6ce4-985578535d34@tronnes.org\0" - "From\0hean.loong.ong@intel.com (Ong, Hean Loong)\0" - "Subject\0[PATCH10 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite\0" + "From\0Ong, Hean Loong <hean.loong.ong@intel.com>\0" + "Subject\0Re: [PATCH10 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite\0" "Date\0Thu, 16 Aug 2018 08:33:54 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0noralf@tronnes.org <noralf@tronnes.org>" + " airlied@linux.ie <airlied@linux.ie>\0" + "Cc\0dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + See + Chin Liang <chin.liang.see@intel.com> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + devicetree@vger.kernel.org <devicetree@vger.kernel.org> + Vandervennet + " Yves <yves.vandervennet@intel.com>\0" "\00:1\0" "b\0" - "On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr?nnes wrote:\n" + "On Wed, 2018-08-15 at 14:26 +0200, Noralf Tr\303\270nnes wrote:\n" "> Den 14.08.2018 10.57, skrev Hean-Loong, Ong:\n" "> > \n" "> > From: Ong Hean Loong <hean.loong.ong@intel.com>\n" @@ -21,49 +30,49 @@ "> > \n" "> > Signed-off-by: Ong Hean Loong <hean.loong.ong@intel.com>\n" "> > ---\n" - "> > ? drivers/gpu/drm/Kconfig???????????????|????2 +\n" - "> > ? drivers/gpu/drm/Makefile??????????????|????1 +\n" - "> > ? drivers/gpu/drm/ivip/Kconfig??????????|???14 +++\n" - "> > ? drivers/gpu/drm/ivip/Makefile?????????|????9 ++\n" - "> > ? drivers/gpu/drm/ivip/intel_vip_conn.c |???95 ++++++++++++++++\n" - "> > ? drivers/gpu/drm/ivip/intel_vip_core.c |??161\n" + "> > \302\240 drivers/gpu/drm/Kconfig\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\240\302\240\302\2402 +\n" + "> > \302\240 drivers/gpu/drm/Makefile\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\240\302\240\302\2401 +\n" + "> > \302\240 drivers/gpu/drm/ivip/Kconfig\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\240\302\24014 +++\n" + "> > \302\240 drivers/gpu/drm/ivip/Makefile\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240|\302\240\302\240\302\240\302\2409 ++\n" + "> > \302\240 drivers/gpu/drm/ivip/intel_vip_conn.c |\302\240\302\240\302\24095 ++++++++++++++++\n" + "> > \302\240 drivers/gpu/drm/ivip/intel_vip_core.c |\302\240\302\240161\n" "> > +++++++++++++++++++++++++++\n" - "> > ? drivers/gpu/drm/ivip/intel_vip_drv.h??|???52 +++++++++\n" - "> > ? drivers/gpu/drm/ivip/intel_vip_of.c???|??193\n" + "> > \302\240 drivers/gpu/drm/ivip/intel_vip_drv.h\302\240\302\240|\302\240\302\240\302\24052 +++++++++\n" + "> > \302\240 drivers/gpu/drm/ivip/intel_vip_of.c\302\240\302\240\302\240|\302\240\302\240193\n" "> > +++++++++++++++++++++++++++++++++\n" - "> > ? 8 files changed, 527 insertions(+), 0 deletions(-)\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/Kconfig\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/Makefile\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_conn.c\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_core.c\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_drv.h\n" - "> > ? create mode 100644 drivers/gpu/drm/ivip/intel_vip_of.c\n" + "> > \302\240 8 files changed, 527 insertions(+), 0 deletions(-)\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/Kconfig\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/Makefile\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/intel_vip_conn.c\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/intel_vip_core.c\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/intel_vip_drv.h\n" + "> > \302\240 create mode 100644 drivers/gpu/drm/ivip/intel_vip_of.c\n" "> > \n" "> > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig\n" "> > index cb88528..6b2845b 100644\n" "> > --- a/drivers/gpu/drm/Kconfig\n" "> > +++ b/drivers/gpu/drm/Kconfig\n" "> > @@ -215,6 +215,8 @@ source \"drivers/gpu/drm/nouveau/Kconfig\"\n" - "> > ??\n" - "> > ? source \"drivers/gpu/drm/i915/Kconfig\"\n" - "> > ??\n" + "> > \302\240\302\240\n" + "> > \302\240 source \"drivers/gpu/drm/i915/Kconfig\"\n" + "> > \302\240\302\240\n" "> > +source \"drivers/gpu/drm/ivip/Kconfig\"\n" "> > +\n" - "> > ? config DRM_VGEM\n" - "> > ??\ttristate \"Virtual GEM provider\"\n" - "> > ??\tdepends on DRM\n" + "> > \302\240 config DRM_VGEM\n" + "> > \302\240\302\240\ttristate \"Virtual GEM provider\"\n" + "> > \302\240\302\240\tdepends on DRM\n" "> > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile\n" "> > index a6771ce..57205d8 100644\n" "> > --- a/drivers/gpu/drm/Makefile\n" "> > +++ b/drivers/gpu/drm/Makefile\n" "> > @@ -61,6 +61,7 @@ obj-$(CONFIG_DRM_AMDGPU)+= amd/amdgpu/\n" - "> > ? obj-$(CONFIG_DRM_MGA)\t+= mga/\n" - "> > ? obj-$(CONFIG_DRM_I810)\t+= i810/\n" - "> > ? obj-$(CONFIG_DRM_I915)\t+= i915/\n" + "> > \302\240 obj-$(CONFIG_DRM_MGA)\t+= mga/\n" + "> > \302\240 obj-$(CONFIG_DRM_I810)\t+= i810/\n" + "> > \302\240 obj-$(CONFIG_DRM_I915)\t+= i915/\n" "> > +obj-$(CONFIG_DRM_IVIP)\t+= ivip/\n" - "> > ? obj-$(CONFIG_DRM_MGAG200) += mgag200/\n" - "> > ? obj-$(CONFIG_DRM_V3D)??+= v3d/\n" - "> > ? obj-$(CONFIG_DRM_VC4)??+= vc4/\n" + "> > \302\240 obj-$(CONFIG_DRM_MGAG200) += mgag200/\n" + "> > \302\240 obj-$(CONFIG_DRM_V3D)\302\240\302\240+= v3d/\n" + "> > \302\240 obj-$(CONFIG_DRM_VC4)\302\240\302\240+= vc4/\n" "> > diff --git a/drivers/gpu/drm/ivip/Kconfig\n" "> > b/drivers/gpu/drm/ivip/Kconfig\n" "> > new file mode 100644\n" @@ -72,24 +81,24 @@ "> > +++ b/drivers/gpu/drm/ivip/Kconfig\n" "> > @@ -0,0 +1,14 @@\n" "> > +config DRM_IVIP\n" - "> > +????????tristate \"Intel FGPA Video and Image Processing\"\n" - "> > +????????depends on DRM && OF\n" - "> > +????????select DRM_GEM_CMA_HELPER\n" - "> > +????????select DRM_KMS_HELPER\n" - "> > +????????select DRM_KMS_FB_HELPER\n" - "> > +????????select DRM_KMS_CMA_HELPER\n" - "> > +????????help\n" - "> > +\t\t??Choose this option if you have an Intel FPGA\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240tristate \"Intel FGPA Video and Image Processing\"\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240depends on DRM && OF\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240select DRM_GEM_CMA_HELPER\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240select DRM_KMS_HELPER\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240select DRM_KMS_FB_HELPER\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240select DRM_KMS_CMA_HELPER\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240help\n" + "> > +\t\t\302\240\302\240Choose this option if you have an Intel FPGA\n" "> > Arria 10 system\n" - "> > +\t\t??and above with an Intel Display Port IP. This\n" + "> > +\t\t\302\240\302\240and above with an Intel Display Port IP. This\n" "> > does not support\n" - "> > +\t\t??legacy Intel FPGA Cyclone V display port.\n" + "> > +\t\t\302\240\302\240legacy Intel FPGA Cyclone V display port.\n" "> > Currently only single\n" - "> > +\t\t??frame buffer is supported. Note that ACPI and\n" + "> > +\t\t\302\240\302\240frame buffer is supported. Note that ACPI and\n" "> > X_86 architecture\n" - "> > +\t\t??is not supported for Arria10. If M is selected\n" + "> > +\t\t\302\240\302\240is not supported for Arria10. If M is selected\n" "> > the module will be\n" - "> > +\t\t??called ivip.\n" + "> > +\t\t\302\240\302\240called ivip.\n" "> > diff --git a/drivers/gpu/drm/ivip/Makefile\n" "> > b/drivers/gpu/drm/ivip/Makefile\n" "> > new file mode 100644\n" @@ -98,7 +107,7 @@ "> > +++ b/drivers/gpu/drm/ivip/Makefile\n" "> > @@ -0,0 +1,9 @@\n" "> > +#\n" - "> > +# Makefile for the drm device driver.??This driver provides\n" + "> > +# Makefile for the drm device driver.\302\240\302\240This driver provides\n" "> > support for the\n" "> > +# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and\n" "> > higher.\n" @@ -148,7 +157,7 @@ "> > WITHOUT\n" "> > + * ANY WARRANTY; without even the implied warranty of\n" "> > MERCHANTABILITY or\n" - "> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public\n" + "> > + * FITNESS FOR A PARTICULAR PURPOSE.\302\240\302\240See the GNU General Public\n" "> > License for\n" "> > + * more details.\n" "> > + *\n" @@ -196,10 +205,10 @@ "> > +\n" "> > +\tcount = drm_add_modes_noedid(connector, drm-\n" "> > >mode_config.max_width,\n" - "> > +\t\t\t\t?????drm->mode_config.max_height);\n" + "> > +\t\t\t\t\302\240\302\240\302\240\302\240\302\240drm->mode_config.max_height);\n" "> > +\tdrm_set_preferred_mode(connector, drm-\n" "> > >mode_config.max_width,\n" - "> > +\t\t\t???????drm->mode_config.max_height);\n" + "> > +\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240drm->mode_config.max_height);\n" "> > +\treturn count;\n" "> > +}\n" "> > +\n" @@ -220,7 +229,7 @@ "> > +\n" "> > +\tret = drm_connector_init(drm, conn,\n" "> > &intelvipfb_drm_connector_funcs,\n" - "> > +\t\t\t\t?DRM_MODE_CONNECTOR_DisplayPort);\n" + "> > +\t\t\t\t\302\240DRM_MODE_CONNECTOR_DisplayPort);\n" "> > +\tif (ret < 0) {\n" "> > +\t\tdev_err(drm->dev, \"failed to initialize drm\n" "> > connector\\n\");\n" @@ -268,7 +277,7 @@ "> > WITHOUT\n" "> > + * ANY WARRANTY; without even the implied warranty of\n" "> > MERCHANTABILITY or\n" - "> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public\n" + "> > + * FITNESS FOR A PARTICULAR PURPOSE.\302\240\302\240See the GNU General Public\n" "> > License for\n" "> > + * more details.\n" "> > + *\n" @@ -296,16 +305,16 @@ "> > +\n" "> > +static void intelvipfb_enable(struct drm_simple_display_pipe\n" "> > *pipe,\n" - "> > +\t\t\t??????struct drm_crtc_state *crtc_state,\n" + "> > +\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240struct drm_crtc_state *crtc_state,\n" "> > struct drm_plane_state *plane_state)\n" "> > +{\n" "> > +\t/*\n" - "> > +\t?* The frameinfo variable has to correspond to the size of\n" + "> > +\t\302\240* The frameinfo variable has to correspond to the size of\n" "> > the VIP Suite\n" - "> > +\t?* Frame Reader register 7 which will determine the\n" + "> > +\t\302\240* Frame Reader register 7 which will determine the\n" "> > maximum size used\n" - "> > +\t?* in this frameinfo\n" - "> > +\t?*/\n" + "> > +\t\302\240* in this frameinfo\n" + "> > +\t\302\240*/\n" "> > +\n" "> > +\tu32 frameinfo;\n" "> > +\tstruct intelvipfb_priv *priv = pipe->plane.dev-\n" @@ -351,7 +360,7 @@ "> > +\n" "> > +static int intelvipfb_pipe_prepare_fb(struct\n" "> > drm_simple_display_pipe *pipe,\n" - "> > +\t\t\t\t??????struct drm_plane_state\n" + "> > +\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240struct drm_plane_state\n" "> > *plane_state)\n" "> > +{\n" "> > +\treturn drm_gem_fb_prepare_fb(&pipe->plane, plane_state);\n" @@ -389,7 +398,7 @@ "> > +\t}\n" "> > +\n" "> > +\tretval = drm_simple_display_pipe_init(drm, &fbpriv->pipe,\n" - "> > +\t\t\t\t\t??????&fbpriv_funcs,\n" + "> > +\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240&fbpriv_funcs,\n" "> > formats,\n" "> > +\t\t\tARRAY_SIZE(formats), NULL, connector);\n" "> > +\tif (retval < 0) {\n" @@ -411,9 +420,9 @@ "> Noralf.\n" "> \n" "I could not find any examples that currently uses\n" - "the?drm_fbdev_generic_setup (). Would you mind pointing me on where\n" + "the\302\240drm_fbdev_generic_setup (). Would you mind pointing me on where\n" "such examples are available that would allow me to replace the\n" - "assignment of the fbcma pointer with?drm_fbdev_generic_setup() method\n" + "assignment of the fbcma pointer with\302\240drm_fbdev_generic_setup() method\n" "\n" "Thanks.\n" "Hean Loong.\n" @@ -435,7 +444,7 @@ "> > +int intelvipfb_remove(struct device *dev)\n" "> > +{\n" "> > +\tstruct intelvipfb_priv *fbpriv = dev_get_drvdata(dev);\n" - "> > +\tstruct drm_device *drm =??fbpriv->drm;\n" + "> > +\tstruct drm_device *drm =\302\240\302\240fbpriv->drm;\n" "> > +\n" "> > +\tdrm_dev_unregister(drm);\n" "> > +\n" @@ -473,13 +482,13 @@ "> > WITHOUT\n" "> > + * ANY WARRANTY; without even the implied warranty of\n" "> > MERCHANTABILITY or\n" - "> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public\n" + "> > + * FITNESS FOR A PARTICULAR PURPOSE.\302\240\302\240See the GNU General Public\n" "> > License for\n" "> > + * more details.\n" "> > + *\n" "> > + * You should have received a copy of the GNU General Public\n" "> > License along with\n" - "> > + * this program.??If not, see <http://www.gnu.org/licenses/>.\n" + "> > + * this program.\302\240\302\240If not, see <http://www.gnu.org/licenses/>.\n" "> > + *\n" "> > + * Authors:\n" "> > + * Ong, Hean-Loong <hean.loong.ong@intel.com>\n" @@ -488,20 +497,20 @@ "> > +#ifndef _INTEL_VIP_DRV_H\n" "> > +#define _INTEL_VIP_DRV_H\n" "> > +\n" - "> > +#define DRIVER_NAME????\"intelvipfb\"\n" - "> > +#define BYTES_PER_PIXEL\t?4\n" - "> > +#define CRTC_NUM\t????????1\n" - "> > +#define CONN_NUM\t????????1\n" + "> > +#define DRIVER_NAME\302\240\302\240\302\240\302\240\"intelvipfb\"\n" + "> > +#define BYTES_PER_PIXEL\t\302\2404\n" + "> > +#define CRTC_NUM\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\2401\n" + "> > +#define CONN_NUM\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\2401\n" "> > +\n" "> > +/* control registers */\n" - "> > +#define INTELVIPFB_CONTROL\t??????0\n" - "> > +#define INTELVIPFB_STATUS\t???????0x4\n" - "> > +#define INTELVIPFB_INTERRUPT\t????0x8\n" + "> > +#define INTELVIPFB_CONTROL\t\302\240\302\240\302\240\302\240\302\240\302\2400\n" + "> > +#define INTELVIPFB_STATUS\t\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x4\n" + "> > +#define INTELVIPFB_INTERRUPT\t\302\240\302\240\302\240\302\2400x8\n" "> > +#define INTELVIPFB_FRAME_COUNTER\t0xC\n" - "> > +#define INTELVIPFB_FRAME_DROP\t???0x10\n" - "> > +#define INTELVIPFB_FRAME_INFO\t???0x14\n" - "> > +#define INTELVIPFB_FRAME_START\t??0x18\n" - "> > +#define INTELVIPFB_FRAME_READER\t?????????0x1C\n" + "> > +#define INTELVIPFB_FRAME_DROP\t\302\240\302\240\302\2400x10\n" + "> > +#define INTELVIPFB_FRAME_INFO\t\302\240\302\240\302\2400x14\n" + "> > +#define INTELVIPFB_FRAME_START\t\302\240\302\2400x18\n" + "> > +#define INTELVIPFB_FRAME_READER\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\2400x1C\n" "> > +\n" "> > +int intelvipfb_probe(struct device *dev);\n" "> > +int intelvipfb_remove(struct device *dev);\n" @@ -513,7 +522,7 @@ "> > +\tstruct drm_simple_display_pipe pipe;\n" "> > +\tstruct drm_fbdev_cma *fbcma;\n" "> > +\tstruct drm_device *drm;\n" - "> > +\tvoid????__iomem *base;\n" + "> > +\tvoid\302\240\302\240\302\240\302\240__iomem *base;\n" "> > +};\n" "> > +\n" "> > +#endif\n" @@ -543,7 +552,7 @@ "> > WITHOUT\n" "> > + * ANY WARRANTY; without even the implied warranty of\n" "> > MERCHANTABILITY or\n" - "> > + * FITNESS FOR A PARTICULAR PURPOSE.??See the GNU General Public\n" + "> > + * FITNESS FOR A PARTICULAR PURPOSE.\302\240\302\240See the GNU General Public\n" "> > License for\n" "> > + * more details.\n" "> > + *\n" @@ -645,7 +654,7 @@ "> > +\t\tdev_err(dev,\n" "> > +\t\t\t\"mem-word-width is set to %i. must be >=\n" "> > 32 and multiple of 32.\",\n" - "> > +\t\t\t?mem_word_width);\n" + "> > +\t\t\t\302\240mem_word_width);\n" "> > +\t\treturn -ENODEV;\n" "> > +\t}\n" "> > +\n" @@ -730,4 +739,4 @@ "> > +\n" > > +module_platform_driver(intelvipfb_driver); -5c599106e09eb50a9c12858ea0d0597b63588bb7079d4e90c42ee93f1972f702 +e5b16dd5edc3a386d3c2a42c55153d916e50f93f252d06c42de1a8f65a63b780
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.