From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 06/11] vdev: rename nonpci_devs as vdev Date: Fri, 11 Apr 2014 13:25:39 +0200 Message-ID: <1534459.c4aMep7oeX@xps13> References: <2329281.9S2dNLIOMh@xps13> <1397201793-26580-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Olivier Matz Return-path: In-Reply-To: <1397201793-26580-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-04-11 09:36, Olivier Matz: > The name "nonpci_devs" for virtual devices is ambiguous as a physical > device can also be non-PCI (ex: usb, sata, ...). A better name for this > file is "vded" as it only deals with virtual devices. > > This patch doesn't introduce any change except renaming. > > Signed-off-by: Olivier Matz You probably should change the BSD Makefile also: lib/librte_eal/bsdapp/eal/Makefile:SRCS-$(CONFIG_RTE_LIBRTE_EAL_BSDAPP) += eal_common_nonpci_devs.c Thanks -- Thomas