Re: [PATCH v4] net/bonding: per-slave intermediate rx ring

[Luca Boccassi <bluca@debian.org>]

On Tue, 2018-08-21 at 10:56 +0000, Matan Azrad wrote:
> Hi
> 
> From: Chas Williams
> > This will need to be implemented for some of the other RX burst
> > methods at
> > some point for other modes to see this performance improvement
> > (with the
> > exception of active-backup).
> 
> Yes, I think it should be done at least to
> bond_ethdev_rx_burst_8023ad_fast_queue (should be easy) for now.
> 
> > On Thu, Aug 16, 2018 at 9:32 AM Luca Boccassi <bluca@debian.org>
> > wrote:
> > 
> > > During bond 802.3ad receive, a burst of packets is fetched from
> > > each
> > > slave into a local array and appended to per-slave ring buffer.
> > > Packets are taken from the head of the ring buffer and returned
> > > to the
> > > caller.  The number of mbufs provided to each slave is sufficient
> > > to
> > > meet the requirements of the ixgbe vector receive.
> 
> Luca,
> 
> Can you explain these requirements of ixgbe?

I think Chas knows this better than I do. Chas?

> Did you check for other vendor PMDs? It may hurt performance there..

Yeah we do support the appliance with more drivers - off the top of my
head at the very least e1000, i40e, bnxt, and I'm pretty sure there are
users that run with bonded virtio interfaces (yeah I know). No issues
were reported as far as I'm aware.

-- 
Kind regards,
Luca Boccassi