From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Panu Matilainen <pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] config: default to shared library
Date: Wed, 04 Mar 2015 10:24:44 +0100 [thread overview]
Message-ID: <1534932.rt5IAT3UZl@xps13> (raw)
In-Reply-To: <c826d83d78b0d24d0d840775b6ff6afaa848320c.1425449872.git.pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hi Panu,
2015-03-04 08:17, Panu Matilainen:
> With symbol versioning its vital that developers test their code in
> shared library mode, otherwise we'll be playing "add the forgotten
> symbol export" from here to eternity.
Yes we must improve the sanity checks.
A lot of options must be tested (or removed) and not only shared libs.
But the error you reported before (missing export of rte_eth_dev_release_port)
cannot be seen even with this patch.
It means we need more tools.
Though, default configuration is not a tool.
> By defaulting to shared we should catch more of these cases early,
> but without taking away anybodys ability to build static.
Shared libraries are convenient for distributions but have a performance
impact. I think that static build must remain the default choice.
next prev parent reply other threads:[~2015-03-04 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 6:17 [PATCH] config: default to shared library Panu Matilainen
[not found] ` <c826d83d78b0d24d0d840775b6ff6afaa848320c.1425449872.git.pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-04 9:24 ` Thomas Monjalon [this message]
2015-03-04 10:42 ` Bruce Richardson
2015-03-04 11:05 ` Panu Matilainen
[not found] ` <54F6E6E3.50404-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-04 11:28 ` Neil Horman
[not found] ` <20150304112805.GA5808-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2015-03-04 13:08 ` Bruce Richardson
2015-03-04 13:24 ` Panu Matilainen
[not found] ` <54F7077C.1010504-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-04 13:31 ` Bruce Richardson
2015-03-04 13:41 ` Panu Matilainen
[not found] ` <54F70B9D.7040903-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-04 13:49 ` Bruce Richardson
2015-03-04 13:56 ` Thomas Monjalon
2015-03-04 13:57 ` David Marchand
[not found] ` <CALwxeUtvB=sSgJfpNA6aqWO_W2sMobw1EQFwMTAk88vWrik25A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-04 14:10 ` Bruce Richardson
2015-03-04 11:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534932.rt5IAT3UZl@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=pmatilai-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.