From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] testsuite: Handle large number of kernel options
Date: Wed, 22 Aug 2018 12:02:51 +0100
Message-ID: <1534935771.5764.109.camel@debian.org>
References: <1534926698-25163-1-git-send-email-stefan.bader@canonical.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-PmYavM8RzdlCYANKeMAA"
Cc: Stephen Hemminger <stephen@networkplumber.org>,
        Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Stefan Bader <stefan.bader@canonical.com>,
        net-devel <netdev@vger.kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f66.google.com ([209.85.221.66]:35316 "EHLO
        mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727016AbeHVO1U (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 22 Aug 2018 10:27:20 -0400
Received: by mail-wr1-f66.google.com with SMTP id j26-v6so1272693wre.2
        for <netdev@vger.kernel.org>; Wed, 22 Aug 2018 04:02:54 -0700 (PDT)
In-Reply-To: <1534926698-25163-1-git-send-email-stefan.bader@canonical.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--=-PmYavM8RzdlCYANKeMAA
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2018-08-22 at 10:31 +0200, Stefan Bader wrote:
> Once there are more than a certain number of kernel config options
> set (this happened for us with kernel 4.17), the method of passing
> those as command line arguments exceeds the maximum number of
> arguments the shell supports. This causes the whole testsuite to
> fail.
> Instead, create a temporary file and modify its contents so that
> the config option variables are exported. Then this file can be
> sourced in before running the tests.
>=20
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> ---
> =C2=A0testsuite/Makefile | 16 +++++++++++-----
> =C2=A01 file changed, 11 insertions(+), 5 deletions(-)
>=20
> diff --git a/testsuite/Makefile b/testsuite/Makefile
> index 8fcbc55..f9f3b19 100644

Acked-by: Luca Boccassi <bluca@debian.org>

Looks good to me, thanks.

--=20
Kind regards,
Luca Boccassi
--=-PmYavM8RzdlCYANKeMAA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAlt9QtsACgkQSylmgFB4
UWJ0bQgAoyLiKIQE/JmcGh+rr6AGOdkRMuOHnOG+MiqNTLcJQoEfQW6xO91hh1aN
Oi0IefHde+UVwoOWjoyPoDKVMFj4a6YPhC0bzDjWPIlr/mFRh5iwYUv3tD2n9YRo
WO5eoStE1QeQ1yqO+hOZH+jpIVG663Ja4qBinX39DP/tcm3Ccz0g7rCE9a4kAiT3
OM3ILJS8emAV9Pwfo7MvEhIAooTlknO0rY1cW70tWr0QCiaDj2Jy1pIi2FUCcve/
qZuj+9sCQxt1o7Au0Jnb/gep1K9jZWNenzGnkRBb0rtFcQa4D6OXymD840X7uCId
eHbvf5ChSxAKvNXEDd9sDnya8K0hzg==
=53Ab
-----END PGP SIGNATURE-----

--=-PmYavM8RzdlCYANKeMAA--