Re: [PATCH RFC v3 2/3] smb/server: fix minimum SMB2 PDU size

[ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev>]

Hi Namjae,

Thank you for reviewing patch 01 and 03. I will update the patches 
according to your suggestions.

Do you have any suggestions for this patch 02?

Thanks,
ChenXiaoSong.

On 12/20/25 7:54 AM, chenxiaosong.chenxiaosong@linux.dev wrote:
> From: ChenXiaoSong <chenxiaosong@kylinos.cn>
> 
> The minimum SMB2 PDU size should be updated to the size of
> `struct smb2_pdu`.
> 
> Suggested-by: David Howells <dhowells@redhat.com>
> Suggested-by: Namjae Jeon <linkinjeon@kernel.org>
> Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
> ---
>   fs/smb/server/connection.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/smb/server/connection.c b/fs/smb/server/connection.c
> index f372486ebcc5..4a8eb4fef763 100644
> --- a/fs/smb/server/connection.c
> +++ b/fs/smb/server/connection.c
> @@ -296,7 +296,7 @@ bool ksmbd_conn_alive(struct ksmbd_conn *conn)
>   }
>   
>   #define SMB1_MIN_SUPPORTED_PDU_SIZE (sizeof(struct smb_pdu))
> -#define SMB2_MIN_SUPPORTED_HEADER_SIZE (sizeof(struct smb2_hdr) + 4)
> +#define SMB2_MIN_SUPPORTED_PDU_SIZE (sizeof(struct smb2_pdu))
>   
>   /**
>    * ksmbd_conn_handler_loop() - session thread to listen on new smb requests
> @@ -396,7 +396,7 @@ int ksmbd_conn_handler_loop(void *p)
>   
>   		if (((struct smb2_hdr *)smb2_get_msg(conn->request_buf))->ProtocolId ==
>   		    SMB2_PROTO_NUMBER) {
> -			if (pdu_size < SMB2_MIN_SUPPORTED_HEADER_SIZE)
> +			if (pdu_size < SMB2_MIN_SUPPORTED_PDU_SIZE)
>   				break;
>   		}
>