From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org,
"Grzegorz Duszyński" <gfduszynski@gmail.com>
Subject: Re: [PATCH 1/2] cfg80211: let's wmm_rule be part of reg_rule structure
Date: Tue, 28 Aug 2018 10:43:34 +0200 [thread overview]
Message-ID: <1535445814.5895.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20180822115854.GA2747@redhat.com>
On Wed, 2018-08-22 at 13:58 +0200, Stanislaw Gruszka wrote:
> On Wed, Aug 22, 2018 at 01:54:27PM +0200, Johannes Berg wrote:
> > On Wed, 2018-08-22 at 13:52 +0200, Stanislaw Gruszka wrote:
> > > Make wmm_rule be part of reg_rule structure. This simplify code
> > > a lot at cost of having bigger memory usage. However in most cases
> > > we have only few reg_rule's and when we have many like in iwlwifi
> > > we do not save memory as we allocate wmm_rule for each channel.
> >
> > So I think this is fine, but should we "sell" this to stable as well? I
> > guess we don't really have any other fix?
>
> I wanted to delegate that decision to you :-)
>
> It's not one-liner, but from other hand patch just remove bunch
> of code, so should be safe for -stable.
Yeah, I guess I'll try :)
johannes
prev parent reply other threads:[~2018-08-28 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 11:52 [PATCH 1/2] cfg80211: let's wmm_rule be part of reg_rule structure Stanislaw Gruszka
2018-08-22 11:52 ` [PATCH 2/2] cfg80211: validate wmm rule when setting Stanislaw Gruszka
2018-08-22 11:54 ` [PATCH 1/2] cfg80211: let's wmm_rule be part of reg_rule structure Johannes Berg
2018-08-22 11:58 ` Stanislaw Gruszka
2018-08-28 8:43 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535445814.5895.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gfduszynski@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.