From: Johannes Berg <johannes@sipsolutions.net>
To: Alexander Wetzel <alexander@wetzel-home.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API
Date: Tue, 28 Aug 2018 18:03:46 +0200 [thread overview]
Message-ID: <1535472226.5895.58.camel@sipsolutions.net> (raw)
In-Reply-To: <4cc30aa2-6235-f76c-485f-48fac8af3c1a@wetzel-home.de>
On Tue, 2018-08-28 at 18:00 +0200, Alexander Wetzel wrote:
> > If you have a flag here, why say "userspace must not" rather than just
> > outright prevent userspace from doing it?
>
> The userspace must not but currently of course is doing exactly that.
> Enforcing the new requirement would therefore cause user visible
> regressions till all drivers have been updated or the updated userspace
> software is deployed on all systems... Both will take years.
>
> So the current approach is keep backward compatibility to not break
> rekeys for users it's currently working for.
Yeah but is it really working for them? They might have it "working",
but leak some frames in clear, like we said? So it might work for all
they notice, but leak frames once a while? I don't see how that's better
really.
johannes
next prev parent reply other threads:[~2018-08-28 19:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 10:42 [PATCH v6 0/3] Fix PTK rekey freezes and cleartext leaks Alexander Wetzel
2018-08-14 10:42 ` [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API Alexander Wetzel
2018-08-16 16:30 ` Denis Kenzior
2018-08-18 20:53 ` Alexander Wetzel
2018-08-28 8:46 ` Johannes Berg
2018-08-28 16:00 ` Alexander Wetzel
2018-08-28 8:47 ` Johannes Berg
2018-08-28 16:00 ` Alexander Wetzel
2018-08-28 16:03 ` Johannes Berg [this message]
2018-08-28 19:02 ` Alexander Wetzel
2018-08-29 7:02 ` Johannes Berg
2018-08-14 10:42 ` [PATCH v6 2/3] mac80211: Define new driver callback replace_key Alexander Wetzel
2018-08-16 16:35 ` Denis Kenzior
2018-08-18 21:01 ` Alexander Wetzel
2018-08-14 10:42 ` [PATCH v6 3/3] mac80211: Fix PTK rekey freezes and cleartext leaks Alexander Wetzel
2018-08-28 8:48 ` Johannes Berg
2018-08-28 16:27 ` Alexander Wetzel
2018-08-29 6:59 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535472226.5895.58.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=alexander@wetzel-home.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.