From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: linux-wireless@vger.kernel.org, nbd@nbd.name, sara.sharon@intel.com
Subject: Re: [PATCH] mac80211: do not aggregate frames if max_frags is set to one
Date: Tue, 28 Aug 2018 23:14:21 +0200 [thread overview]
Message-ID: <1535490861.20033.8.camel@sipsolutions.net> (raw)
In-Reply-To: <d67c1a6772d46f449dbb74d61ddf4d80dee7a350.1535489707.git.lorenzo.bianconi@redhat.com> (sfid-20180828_230714_540221_B42ABCED)
On Tue, 2018-08-28 at 23:07 +0200, Lorenzo Bianconi wrote:
> Do not try to aggregate packets in a A-MSDU frame if max_tx_fragments
> or max_amsdu_subframes is set to 1.
Yeah that seems valid.
> Moreover take into account
> tail padding added on the first frame into flow backlog if
> ieee80211_amsdu_realloc_pad routine on the second frame fails.
That's not really right - the padding shouldn't have been added to the
first subframe in the first place as the last one shouldn't have padding
at all. There's also a separate bug in that the A-MSDU subframe length
should NOT include the padding.
My colleague Sara (CC'ed now) has a patch to fix all of this (we just
did that this morning). I'll send it out tomorrow morning. Can I bother
you to try that?
We'd have to fix the first point independently though, or I guess we can
roll that into our bugfix too, which would you prefer?
johannes
next prev parent reply other threads:[~2018-08-29 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1535489707.git.lorenzo.bianconi@redhat.com>
2018-08-28 21:07 ` [PATCH] mac80211: do not aggregate frames if max_frags is set to one Lorenzo Bianconi
2018-08-28 21:14 ` Johannes Berg [this message]
2018-08-28 21:41 ` Lorenzo Bianconi
2018-08-29 6:57 ` Johannes Berg
2018-08-29 10:21 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535490861.20033.8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=sara.sharon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.