From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] compat: fix symbol version support with meson
Date: Thu, 30 Aug 2018 18:31:03 +0100
Message-ID: <1535650263.11823.18.camel@debian.org>
References: <20180830170701.21443-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
 by dpdk.org (Postfix) with ESMTP id A9EEA58C6
 for <dev@dpdk.org>; Thu, 30 Aug 2018 19:31:05 +0200 (CEST)
Received: by mail-wm0-f66.google.com with SMTP id n11-v6so2812397wmc.2
 for <dev@dpdk.org>; Thu, 30 Aug 2018 10:31:05 -0700 (PDT)
In-Reply-To: <20180830170701.21443-1-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote:
> For meson builds, the define to enable the symbol version
> macros in rte_compat.h was missing. This led to symbols being
> omitted from shared objects. For example, checking rte_distributor.so
> with objdump and comparing make and meson built versions:
>=20
> $ objdump -T make-build/lib/librte_distributor.so | grep _flush
> =C2=A00000000000001b60 g=C2=A0=C2=A0=C2=A0=C2=A0DF .text	00000000000000a7
> (DPDK_2.0)=C2=A0=C2=A0=C2=A0rte_distributor_flush
> =C2=A00000000000003f10 g=C2=A0=C2=A0=C2=A0=C2=A0DF .text	0000000000000434=
=C2=A0=C2=A0DPDK_17.05=C2=A0=C2=A0
> rte_distributor_flush
> $ objdump -T meson-build/lib/librte_distributor.so | grep _flush
> =C2=A00000000000001d50 g=C2=A0=C2=A0=C2=A0=C2=A0DF .text	00000000000000fb=
=C2=A0=C2=A0DPDK_2.0=C2=A0=C2=A0=C2=A0=C2=A0
> rte_distributor_flush
>=20
> Adding in the missing define fixes this.
>=20
> Fixes: 5b9656b157d3 ("lib: build with meson")
>=20
> Reported-by: Luca Boccassi <bluca@debian.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> =C2=A0config/rte_config.h | 3 +++
> =C2=A01 file changed, 3 insertions(+)
>=20
> diff --git a/config/rte_config.h b/config/rte_config.h
> index a8e479774..46775a841 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -20,6 +20,9 @@
> =C2=A0
> =C2=A0/****** library defines ********/
> =C2=A0
> +/* compat defines */
> +#define RTE_BUILD_SHARED_LIB
> +
> =C2=A0/* EAL defines */
> =C2=A0#define RTE_MAX_MEMSEG_LISTS 128
> =C2=A0#define RTE_MAX_MEMSEG_PER_LIST 8192

Tested-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi