Re: [PATCH] mac80211: use non-zero TID only for QoS frames

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2018-09-05 at 10:06 +0200, Arend van Spriel wrote:
> 
> > +++ b/net/mac80211/tx.c
> > @@ -1260,7 +1260,10 @@ static struct txq_info *ieee80211_get_txq(struct ieee80211_local *local,
> >   			txq = sta->sta.txq[IEEE80211_NUM_TIDS];
> >   		}
> >   	} else if (sta) {
> > -		u8 tid = skb->priority & IEEE80211_QOS_CTL_TID_MASK;
> > +		u8 tid = 0;
> > +
> > +		if (hdr->frame_control & cpu_to_le16(IEEE80211_STYPE_QOS_DATA))
> > +			tid = skb->priority & IEEE80211_QOS_CTL_TAG1D_MASK;
> 
> Is the use of different mask intentional here? Just a quick glance so 
> did not look into it further.

Ah, I forgot to mention that in the commit log. That just aligns it with
most of the other code, but since we never have values other than 0-7 it
doesn't actually matter.

johannes