From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1536161092.11534.1.camel@acm.org> Subject: Re: [PATCH 1/5] block: genhd: add 'groups' argument to device_add_disk From: Bart Van Assche To: Hannes Reinecke , Jens Axboe Cc: Christoph Hellwig , Sagi Grimberg , Keith Busch , Bart van Assche , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Martin Wilck , Hannes Reinecke Date: Wed, 05 Sep 2018 08:24:52 -0700 In-Reply-To: <20180905070053.26239-2-hare@suse.de> References: <20180905070053.26239-1-hare@suse.de> <20180905070053.26239-2-hare@suse.de> Content-Type: text/plain; charset="UTF-7" Mime-Version: 1.0 List-ID: On Wed, 2018-09-05 at 09:00 +-0200, Hannes Reinecke wrote: +AD4 Update device+AF8-add+AF8-disk() to take an 'groups' argument so that +AD4 individual drivers can register a device with additional sysfs +AD4 attributes. +AD4 This avoids race condition the driver would otherwise have if these +AD4 groups were to be created with sysfs+AF8-add+AF8-groups(). Reviewed-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: bvanassche@acm.org (Bart Van Assche) Date: Wed, 05 Sep 2018 08:24:52 -0700 Subject: [PATCH 1/5] block: genhd: add 'groups' argument to device_add_disk In-Reply-To: <20180905070053.26239-2-hare@suse.de> References: <20180905070053.26239-1-hare@suse.de> <20180905070053.26239-2-hare@suse.de> Message-ID: <1536161092.11534.1.camel@acm.org> On Wed, 2018-09-05@09:00 +0200, Hannes Reinecke wrote: > Update device_add_disk() to take an 'groups' argument so that > individual drivers can register a device with additional sysfs > attributes. > This avoids race condition the driver would otherwise have if these > groups were to be created with sysfs_add_groups(). Reviewed-by: Bart Van Assche