Re: [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: Fix bad-pixel-format not to be run on gen11 and later

[Mika Kahola <mika.kahola@intel.com>]

On Wed, 2018-08-29 at 16:12 +0300, Juha-Pekka Heikkila wrote:
> gen11 enables 90/270 rotation for RGB565 mode. IGT would need support
> for
> C8 mode to enable running this subtest on gen11 and later.
> 
> v2 (Mika Kahola): Combine gen checks into one comparison. Update
> comment on why bad-pixel-format is disabled beyond gen11.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  tests/kms_rotation_crc.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index b994cc5..5ed0c0b 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -557,7 +557,12 @@ igt_main
>  	data.pos_y = 0;
>  
>  	igt_subtest_f("bad-pixel-format") {
> -		igt_require(gen >= 9);
> +		/*
> +		 * gen11 enables RGB565 rotation for 90/270 degrees.
> +		 * DRM_FORMAT_C8 fmt need to be enabled for IGT if
> want to run
> +		 * this test on gen11 and later.
> +		 */
> +		igt_require(gen >= 9 && gen < 11);
>  		data.rotation = IGT_ROTATION_90;
>  		data.override_fmt = DRM_FORMAT_RGB565;
>  		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY,
> true);
Both patches now pushed to IGT.

-- 
Mika Kahola - Intel OTC

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev