From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [RFC v2 1/2] netlink: add NLA_REJECT policy type
Date: Wed, 12 Sep 2018 10:38:12 +0200 [thread overview]
Message-ID: <1536741492.3678.9.camel@sipsolutions.net> (raw)
In-Reply-To: <20180912083610.20857-1-johannes@sipsolutions.net> (sfid-20180912_103626_907703_3A24107A)
On Wed, 2018-09-12 at 10:36 +0200, Johannes Berg wrote:
> @@ -251,7 +257,7 @@ int nla_parse(struct nlattr **tb, int maxtype, const struct nlattr *head,
>
> if (type > 0 && type <= maxtype) {
> if (policy) {
> - err = validate_nla(nla, maxtype, policy);
> + err = validate_nla(nla, maxtype, policy, extack);
> if (err < 0) {
> NL_SET_ERR_MSG_ATTR(extack, nla,
> "Attribute failed policy validation");
Err... I should read my patches before sending them :-)
Clearly, this NL_SET_ERR_MSG_ATTR() overwrites the error message, so
would have to be made conditional.
I can fix that (and I should use/test it) if we decide it's worthwhile.
johannes
next prev parent reply other threads:[~2018-09-12 13:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 8:36 [RFC v2 1/2] netlink: add NLA_REJECT policy type Johannes Berg
2018-09-12 8:36 ` Johannes Berg
2018-09-12 8:36 ` [RFC v2 2/2] netlink: add ethernet address policy types Johannes Berg
2018-09-12 8:36 ` Johannes Berg
2018-09-12 8:49 ` Arend van Spriel
2018-09-12 8:50 ` Johannes Berg
2018-09-12 8:38 ` Johannes Berg [this message]
2018-09-12 18:15 ` [RFC v2 1/2] netlink: add NLA_REJECT policy type David Miller
2018-09-12 18:15 ` David Miller
2018-09-12 18:34 ` Johannes Berg
2018-09-12 19:29 ` Michal Kubecek
2018-09-12 19:29 ` Michal Kubecek
2018-09-12 19:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536741492.3678.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.