From: Petre Pircalabu <ppircalabu@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/4] x86_emulator: Add PHONY uninstall target
Date: Fri, 14 Sep 2018 14:19:42 +0300 [thread overview]
Message-ID: <1536923982.23465.34.camel@bitdefender.com> (raw)
In-Reply-To: <5B9B7ACE02000078001E88F4@prv1-mh.provo.novell.com>
On Vi, 2018-09-14 at 03:09 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 13.09.18 at 17:01, <ppircalabu@bitdefender.com> wrote:
> > The missing uninstall target breaks the top 'tools' uninstall
> > target.
> Missing?
>
> >
> > --- a/tools/tests/x86_emulator/Makefile
> > +++ b/tools/tests/x86_emulator/Makefile
> > @@ -126,6 +126,9 @@ distclean: clean
> > .PHONY: install uninstall
> > install uninstall:
> >
> > +.PHONY: uninstall
> > +uninstall:
> Please look at the patch context above your change. It was added
> a couple of weeks ago (09613d3b5f), and you really should have
> noticed this the latest when re-basing on top of that change.
>
> Jan
>
Thank-you very much for pointing it out. I have missed it completely.
I will completely remove this patch in the next patchset iteration.
//Petre
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-14 11:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 15:01 [PATCH 0/4] Add support for multi-page vm_event ring buffer Petre Pircalabu
2018-09-13 15:01 ` [PATCH 1/4] x86_emulator: Add PHONY uninstall target Petre Pircalabu
2018-09-14 9:04 ` Wei Liu
2018-09-14 9:09 ` Jan Beulich
2018-09-14 11:19 ` Petre Pircalabu [this message]
2018-09-13 15:01 ` [PATCH 2/4] tools/libxc: Define VM_EVENT type Petre Pircalabu
2018-09-14 9:14 ` Jan Beulich
2018-09-14 11:11 ` Petre Pircalabu
2018-09-14 11:16 ` Jan Beulich
2018-09-13 15:01 ` [PATCH 3/4] x86: Add map_domain_pages_global Petre Pircalabu
2018-09-18 10:51 ` Jan Beulich
2018-09-24 13:13 ` Julien Grall
2018-09-13 15:02 ` [PATCH 4/4] vm_event: Add support for multi-page ring buffer Petre Pircalabu
2018-09-13 16:42 ` Tamas K Lengyel
2018-09-14 8:10 ` Petre Pircalabu
2018-09-17 14:41 ` Andrew Cooper
2018-09-24 16:32 ` Petre Pircalabu
2018-09-18 12:58 ` Jan Beulich
2018-09-24 16:54 ` Petre Pircalabu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536923982.23465.34.camel@bitdefender.com \
--to=ppircalabu@bitdefender.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.