From: Fenghua Yu <fenghua.yu@intel.com>
To: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>, "H Peter Anvin" <hpa@zytor.com>,
"Tony Luck" <tony.luck@intel.com>
Cc: "Chatre, Reinette" <reinette.chatre@intel.com>,
"Xiaochen Shen" <xiaochen.shen@intel.com>,
"Chen Yu" <yu.c.chen@intel.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"x86" <x86@kernel.org>, "Fenghua Yu" <fenghua.yu@intel.com>
Subject: [PATCH V2 0/9] x86/intel_rdt: MBA integration fixes
Date: Sat, 15 Sep 2018 14:58:18 -0700 [thread overview]
Message-ID: <1537048707-76280-1-git-send-email-fenghua.yu@intel.com> (raw)
Chen Yu reported an issue where reading the resctrl "size" file results in
a divide-by-zero issue on a system with a MBA resource. Further
investigation revealed more issues where the recent RDT features are not
well integrated with the MBA resource handling.
This series consists out of:
- One helper function in support of fixes that need to know the number of
supported CLOSIDs on the system (the minimum of all CLOSIDs of all
resources).
- The fix to the issue reported by Chen Yu - now reading a resource
group's "size" file will show a MB resource's allocation as its size.
- A fix from Xiaochen Shen to the MB parsing callback that was never
changed to accept a new parameter format.
- Functions that iterate over the number of CLOSIDs need to take care
whether it is using a particular resource's supported CLOSIDs or the
number of CLOSIDs supported by the system. This was done incorrectly in
a few places and fixed here.
- When a new resource group is created it is intended to be configured
with sane defaults. This new feature blindly assumed that the resource
group only consists out of cache resources - make this explicit to not
cause invalid register writes on a system with MBA resources.
- The new "exclusive" mode assumes that all resources support a CBM, while
a MBA resource does not. Since the MBA resource allocations cannot be
done in a way to specify whether allocations can overlap or not the
"exclusive" mode of a resource group will only apply to the cache
resources within the group, if only a MBA resource is present then
"exclusive" mode will not be allowed.
Changelog
v2:
- Patch 1: Change 'data' from void pointer to struct rdt_parse_data
pointer in parsing callbacks based on suggestion from Thomas.
- Patch 2, 4, 5: Condense backtraces in commit description to minimum
based on suggestion from Thomas
Reinette Chatre (8):
x86/intel_rdt: Fix size reporting of MBA resource
x86/intel_rdt: Global closid helper to support future fixes
x86/intel_rdt: Fix invalid mode warning when multiple resources are
managed
x86/intel_rdt: Fix unchecked MSR access
x86/intel_rdt: Do not allow pseudo-locking of MBA resource
x86/intel_rdt: Fix incorrect loop end condition
x86/intel_rdt: Fix exclusive mode handling of MBA resource
x86/intel_rdt: Fix incorrect loop end condition
Xiaochen Shen (1):
x86/intel_rdt: Fix data type in parsing callbacks
arch/x86/kernel/cpu/intel_rdt.h | 17 +++++--
arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c | 27 ++++++-----
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 53 +++++++++++++++++----
3 files changed, 71 insertions(+), 26 deletions(-)
--
2.19.0
next reply other threads:[~2018-09-15 22:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 21:58 Fenghua Yu [this message]
2018-09-15 21:58 ` [PATCH V2 1/9] x86/intel_rdt: Fix data type in parsing callbacks Fenghua Yu
2018-09-18 21:42 ` [tip:x86/urgent] " tip-bot for Xiaochen Shen
2018-09-15 21:58 ` [PATCH V2 2/9] x86/intel_rdt: Fix size reporting of MBA resource Fenghua Yu
2018-09-18 21:43 ` [tip:x86/urgent] " tip-bot for Reinette Chatre
2018-09-15 21:58 ` [PATCH V2 3/9] x86/intel_rdt: Global closid helper to support future fixes Fenghua Yu
2018-09-18 21:43 ` [tip:x86/urgent] " tip-bot for Reinette Chatre
2018-09-15 21:58 ` [PATCH V2 4/9] x86/intel_rdt: Fix invalid mode warning when multiple resources are managed Fenghua Yu
2018-09-18 21:44 ` [tip:x86/urgent] " tip-bot for Reinette Chatre
2018-09-15 21:58 ` [PATCH V2 5/9] x86/intel_rdt: Fix unchecked MSR access Fenghua Yu
2018-09-18 21:45 ` [tip:x86/urgent] " tip-bot for Reinette Chatre
2018-09-15 21:58 ` [PATCH V2 6/9] x86/intel_rdt: Do not allow pseudo-locking of MBA resource Fenghua Yu
2018-09-18 21:45 ` [tip:x86/urgent] " tip-bot for Reinette Chatre
2018-09-15 21:58 ` [PATCH V2 7/9] x86/intel_rdt: Fix incorrect loop end condition Fenghua Yu
2018-09-18 21:46 ` [tip:x86/urgent] " tip-bot for Reinette Chatre
2018-09-15 21:58 ` [PATCH V2 8/9] x86/intel_rdt: Fix exclusive mode handling of MBA resource Fenghua Yu
2018-09-18 21:46 ` [tip:x86/urgent] " tip-bot for Reinette Chatre
2018-09-15 21:58 ` [PATCH V2 9/9] x86/intel_rdt: Fix incorrect loop end condition Fenghua Yu
2018-09-18 21:47 ` [tip:x86/urgent] " tip-bot for Reinette Chatre
-- strict thread matches above, loose matches on Subject: below --
2018-09-04 17:46 [PATCH][RFC] x86/intel_rdt: Do not display size for non-CAT resource Chen Yu
2018-09-04 20:24 ` Reinette Chatre
2018-09-04 22:36 ` Reinette Chatre
2018-09-05 6:28 ` Yu Chen
2018-09-05 20:52 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537048707-76280-1-git-send-email-fenghua.yu@intel.com \
--to=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xiaochen.shen@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.