All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Martin Galvan <omgalvan.86@gmail.com>, jarkko.sakkinen@linux.intel.com
Cc: linux-integrity@vger.kernel.org
Subject: Re: Question about the TPM driver
Date: Mon, 17 Sep 2018 07:45:32 -0700	[thread overview]
Message-ID: <1537195532.4198.11.camel@HansenPartnership.com> (raw)
In-Reply-To: <CAN19L9HFSkPfrRjDKZZiNXW+rXpV89v9ua1p_r4qmO8pQHfKiA@mail.gmail.com>

On Mon, 2018-09-17 at 10:32 -0300, Martin Galvan wrote:
> El dom., 16 sept. 2018 a las 16:16, Jarkko Sakkinen
> (<jarkko.sakkinen@linux.intel.com>) escribio:
> > I understand your concerns but without a concrete workload there is
> > no
> > problem with this behavior.
> 
> IMHO it's a bit excessive to allocate 4k to end up storing than 100
> bytes. Beyond that, it's a pretty big gotcha for someone who's
> writing software which talks to the driver :)

It's what we do in the kernel, which is one of our most memory
constrained environments.

You have to remember that sub page size buffers aren't always managed
the best at any level (they usually fragment the heap) so even in a
constrained memory environment, a 4k buffer (4k aligned) is usually
preferable.

James

  reply	other threads:[~2018-09-17 20:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 13:14 Question about the TPM driver Martin Galvan
2018-09-13 14:22 ` James Bottomley
2018-09-13 14:31   ` Martin Galvan
2018-09-13 15:11     ` Javier Martinez Canillas
2018-09-13 15:21       ` Tadeusz Struk
2018-09-13 15:26         ` Martin Galvan
2018-10-11 15:17   ` Ken Goldman
2018-09-16 19:16 ` Jarkko Sakkinen
2018-09-17 13:32   ` Martin Galvan
2018-09-17 14:45     ` James Bottomley [this message]
2018-09-17 21:23       ` Jarkko Sakkinen
2018-09-17 21:20     ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1537195532.4198.11.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=omgalvan.86@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.