Re: [ndctl PATCH 1/3] ndctl: Introduce dirty-dimm command

["Verma, Vishal L" <vishal.l.verma@intel.com>]

On Mon, 2018-09-17 at 22:49 -0700, Dan Williams wrote:
> Some DIMMs provide a facility to track dirty-shutdown events. The
> counter only rolls forward after the OS sets a latch. This allows the
> agent tracking dirty shutdowns to ignore events that occur while the
> capacity has not been written. For these DIMMs dirty-dimm will trigger
> the counter to roll to the next state. The shutdown state can be
> retrieved with 'ndctl list -DH'
> 
> Cc: Keith Busch <keith.busch@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  Documentation/ndctl/Makefile.am          |    1 +
>  Documentation/ndctl/ndctl-dirty-dimm.txt |   29 +++++++++++++++++++++++++++++
>  builtin.h                                |    1 +
>  ndctl/dimm.c                             |   28 ++++++++++++++++++++++++++++
>  ndctl/ndctl.c                            |    1 +
>  5 files changed, 60 insertions(+)
>  create mode 100644 Documentation/ndctl/ndctl-dirty-dimm.txt

The series generally looks good to me, just a couple comments below:

> 
> diff --git a/ndctl/dimm.c b/ndctl/dimm.c
> index a4203f354000..595e4e4096a5 100644
> --- a/ndctl/dimm.c
> +++ b/ndctl/dimm.c
> @@ -61,6 +61,19 @@ static int action_zero(struct ndctl_dimm *dimm, struct action_context *actx)
>  	return ndctl_dimm_zero_labels(dimm);
>  }
>  
> +static int action_dirty(struct ndctl_dimm *dimm, struct action_context *actx)
> +{
> +	struct ndctl_cmd *cmd;
> +
> +	cmd = ndctl_dimm_cmd_new_ack_shutdown_count(dimm);
> +	if (!cmd)
> +		return -EOPNOTSUPP;
> +	ndctl_cmd_submit(cmd);

Shouldn't we report any errors here?

> +	ndctl_cmd_unref(cmd);
> +
> +        return 0;

	^ stray whitespace?

> +}
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm