From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:37328 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeIUTtc (ORCPT ); Fri, 21 Sep 2018 15:49:32 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8LE0N5v033670 for ; Fri, 21 Sep 2018 10:00:31 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mn1xd082d-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 21 Sep 2018 10:00:29 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 21 Sep 2018 15:00:05 +0100 Subject: Re: [PATCH v2, RESEND 2/3] tpm: modify tpm_pcr_read() definition to pass TPM hash algorithms From: Mimi Zohar To: Roberto Sassu , jarkko.sakkinen@linux.intel.com Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers , Nayna Jain Date: Fri, 21 Sep 2018 09:59:49 -0400 In-Reply-To: <411432db-ea57-a537-05d3-0b53008bef27@huawei.com> References: <20180917093820.20500-1-roberto.sassu@huawei.com> <20180917093820.20500-3-roberto.sassu@huawei.com> <411432db-ea57-a537-05d3-0b53008bef27@huawei.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Message-Id: <1537538389.3830.336.camel@linux.ibm.com> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Fri, 2018-09-21 at 12:24 +0200, Roberto Sassu wrote: > On 9/17/2018 11:38 AM, Roberto Sassu wrote: > > Currently the TPM driver allows other kernel subsystems to read only the > > SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and > > tpm2_pcr_read() to pass an array of tpm_digest structures, which contains > > the desired hash algorithms. Initially, the array size is limited to 1. > > Jarkko, is this patch ok? > > Mimi, I wait for your review of the IMA part. Yes, I know. I've been on vacation and am hoping to review your, Eric Bigger's and Nayna's patches soon. Sorry for the delay! Mimi From mboxrd@z Thu Jan 1 00:00:00 1970 From: zohar@linux.ibm.com (Mimi Zohar) Date: Fri, 21 Sep 2018 09:59:49 -0400 Subject: [PATCH v2, RESEND 2/3] tpm: modify tpm_pcr_read() definition to pass TPM hash algorithms In-Reply-To: <411432db-ea57-a537-05d3-0b53008bef27@huawei.com> References: <20180917093820.20500-1-roberto.sassu@huawei.com> <20180917093820.20500-3-roberto.sassu@huawei.com> <411432db-ea57-a537-05d3-0b53008bef27@huawei.com> Message-ID: <1537538389.3830.336.camel@linux.ibm.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Fri, 2018-09-21 at 12:24 +0200, Roberto Sassu wrote: > On 9/17/2018 11:38 AM, Roberto Sassu wrote: > > Currently the TPM driver allows other kernel subsystems to read only the > > SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and > > tpm2_pcr_read() to pass an array of tpm_digest structures, which contains > > the desired hash algorithms. Initially, the array size is limited to 1. > > Jarkko, is this patch ok? > > Mimi, I wait for your review of the IMA part. Yes, I know. ?I've been on vacation and am hoping to review your, Eric Bigger's and Nayna's patches soon. ?Sorry for the delay! Mimi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE908C433F4 for ; Fri, 21 Sep 2018 14:00:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C1CE21523 for ; Fri, 21 Sep 2018 14:00:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C1CE21523 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389978AbeIUTtQ (ORCPT ); Fri, 21 Sep 2018 15:49:16 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55166 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727554AbeIUTtQ (ORCPT ); Fri, 21 Sep 2018 15:49:16 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8LE0C8A026740 for ; Fri, 21 Sep 2018 10:00:15 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2mn0stuesc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 21 Sep 2018 10:00:12 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 21 Sep 2018 15:00:05 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 21 Sep 2018 15:00:02 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w8LE01fZ43450524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 21 Sep 2018 14:00:01 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 714F542042; Fri, 21 Sep 2018 16:59:47 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7F4B542041; Fri, 21 Sep 2018 16:59:46 +0100 (BST) Received: from localhost.localdomain (unknown [9.80.102.161]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 21 Sep 2018 16:59:46 +0100 (BST) Subject: Re: [PATCH v2, RESEND 2/3] tpm: modify tpm_pcr_read() definition to pass TPM hash algorithms From: Mimi Zohar To: Roberto Sassu , jarkko.sakkinen@linux.intel.com Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers , Nayna Jain Date: Fri, 21 Sep 2018 09:59:49 -0400 In-Reply-To: <411432db-ea57-a537-05d3-0b53008bef27@huawei.com> References: <20180917093820.20500-1-roberto.sassu@huawei.com> <20180917093820.20500-3-roberto.sassu@huawei.com> <411432db-ea57-a537-05d3-0b53008bef27@huawei.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18092114-4275-0000-0000-000002BDCF0C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18092114-4276-0000-0000-000037C7D51C Message-Id: <1537538389.3830.336.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-21_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=790 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809210142 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-09-21 at 12:24 +0200, Roberto Sassu wrote: > On 9/17/2018 11:38 AM, Roberto Sassu wrote: > > Currently the TPM driver allows other kernel subsystems to read only the > > SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and > > tpm2_pcr_read() to pass an array of tpm_digest structures, which contains > > the desired hash algorithms. Initially, the array size is limited to 1. > > Jarkko, is this patch ok? > > Mimi, I wait for your review of the IMA part. Yes, I know.  I've been on vacation and am hoping to review your, Eric Bigger's and Nayna's patches soon.  Sorry for the delay! Mimi