From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD15489A1F for ; Fri, 21 Sep 2018 22:45:16 +0000 (UTC) Message-ID: <1537569916.3945.43.camel@intel.com> From: Paulo Zanoni Date: Fri, 21 Sep 2018 15:45:16 -0700 In-Reply-To: <20180719150415.935-15-ville.syrjala@linux.intel.com> References: <20180719150415.935-1-ville.syrjala@linux.intel.com> <20180719150415.935-15-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 15/25] lib/kms: Pass strides[] to __kms_addfb List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville Syrjala , igt-dev@lists.freedesktop.org List-ID: RW0gUXVpLCAyMDE4LTA3LTE5IMOgcyAxODowNCArMDMwMCwgVmlsbGUgU3lyamFsYSBlc2NyZXZl dToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+IAo+IE1ha2UgX19rbXNfYWRkZmIoKSB1c2FibGUgd2l0aCBwbGFuYXIgZm9ybWF0cyBieSBw YXNzaW5nIGluIHRoZQo+IHN0cmlkZSBmb3IgZWFjaCBwbGFuZS4KCkknbSBob3BpbmcgbGF0ZXIg aW4gdGhpcyBzZXJpZXMgd2UnbGwganVzdCB1c2UKZHJtTW9kZUFkZEZCMldpdGhNb2RpZmllcnMo KSA6KQoKT3IgYXQgbGVhc3QgdW5pZnkgdGhlIFkgdnMgWC9saW5lYXIgY2FzZXMgYmVsb3cuCgpS ZXZpZXdlZC1ieTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cgo+IAo+ IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfZmIuYyAgICAgICAgICAgICAgICAgICAgfCAgNyArKysr KystCj4gIGxpYi9pb2N0bF93cmFwcGVycy5jICAgICAgICAgICAgfCAxMiArKysrKysrLS0tLS0K PiAgbGliL2lvY3RsX3dyYXBwZXJzLmggICAgICAgICAgICB8ICA4ICsrKysrLS0tCj4gIHRlc3Rz L2ttc19hdmFpbGFibGVfbW9kZXNfY3JjLmMgfCAxNCArKysrKysrLS0tLS0tLQo+ICB0ZXN0cy9r bXNfZHJhd19jcmMuYyAgICAgICAgICAgIHwgIDYgKysrLS0tCj4gIHRlc3RzL3ByaW1lX3ZnZW0u YyAgICAgICAgICAgICAgfCAgOCArKysrKystLQo+ICA2IGZpbGVzIGNoYW5nZWQsIDM0IGluc2Vy dGlvbnMoKyksIDIxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2ZiLmMg Yi9saWIvaWd0X2ZiLmMKPiBpbmRleCAwMjIxYTBiOWIwNDAuLjVlNjg3Yjk1ZTI2NSAxMDA2NDQK PiAtLS0gYS9saWIvaWd0X2ZiLmMKPiArKysgYi9saWIvaWd0X2ZiLmMKPiBAQCAtODc3LDggKzg3 NywxMyBAQCBpZ3RfY3JlYXRlX2ZiX3dpdGhfYm9fc2l6ZShpbnQgZmQsIGludCB3aWR0aCwKPiBp bnQgaGVpZ2h0LAo+ICAKPiAgCWlmICh0aWxpbmcgIT0gTE9DQUxfRFJNX0ZPUk1BVF9NT0RfTk9O RSAmJgo+ICAJICAgIHRpbGluZyAhPSBMT0NBTF9JOTE1X0ZPUk1BVF9NT0RfWF9USUxFRCkgewo+ ICsJCXVpbnQzMl90IHBpdGNoZXNbNF07Cj4gKwo+ICsJCWZvciAoaSA9IDA7IGkgPCBmYl9udW1f cGxhbmVzKGYpOyBpKyspCj4gKwkJCXBpdGNoZXNbaV0gPSBmYi0+c3RyaWRlOwo+ICsKPiAgCQlk b19vcl9kaWUoX19rbXNfYWRkZmIoZmQsIGZiLT5nZW1faGFuZGxlLCB3aWR0aCwKPiBoZWlnaHQs Cj4gLQkJCQkgICAgICBmYi0+c3RyaWRlLCBmb3JtYXQsIHRpbGluZywKPiBmYi0+b2Zmc2V0cywK PiArCQkJCSAgICAgIGZvcm1hdCwgdGlsaW5nLCBwaXRjaGVzLCBmYi0KPiA+b2Zmc2V0cywKPiAg CQkJCSAgICAgIExPQ0FMX0RSTV9NT0RFX0ZCX01PRElGSUVSUywKPiAmZmJfaWQpKTsKPiAgCX0g ZWxzZSB7Cj4gIAkJdWludDMyX3QgaGFuZGxlc1s0XTsKPiBkaWZmIC0tZ2l0IGEvbGliL2lvY3Rs X3dyYXBwZXJzLmMgYi9saWIvaW9jdGxfd3JhcHBlcnMuYwo+IGluZGV4IGQ1ZDJhNGU0YzkxMy4u YTM0ODU3MjY2ZDkyIDEwMDY0NAo+IC0tLSBhL2xpYi9pb2N0bF93cmFwcGVycy5jCj4gKysrIGIv bGliL2lvY3RsX3dyYXBwZXJzLmMKPiBAQCAtMTY3MCw5ICsxNjcwLDExIEBAIHZvaWQgaWd0X3Jl cXVpcmVfZmJfbW9kaWZpZXJzKGludCBmZCkKPiAgCWlndF9yZXF1aXJlKGhhc19tb2RpZmllcnMp Owo+ICB9Cj4gIAo+IC1pbnQgX19rbXNfYWRkZmIoaW50IGZkLCB1aW50MzJfdCBoYW5kbGUsIHVp bnQzMl90IHdpZHRoLCB1aW50MzJfdAo+IGhlaWdodCwKPiAtCQl1aW50MzJfdCBzdHJpZGUsIHVp bnQzMl90IHBpeGVsX2Zvcm1hdCwgdWludDY0X3QKPiBtb2RpZmllciwKPiAtCQl1aW50MzJfdCAq b2Zmc2V0cywgdWludDMyX3QgZmxhZ3MsIHVpbnQzMl90ICpidWZfaWQpCj4gK2ludCBfX2ttc19h ZGRmYihpbnQgZmQsIHVpbnQzMl90IGhhbmRsZSwKPiArCQl1aW50MzJfdCB3aWR0aCwgdWludDMy X3QgaGVpZ2h0LAo+ICsJCXVpbnQzMl90IHBpeGVsX2Zvcm1hdCwgdWludDY0X3QgbW9kaWZpZXIs Cj4gKwkJdWludDMyX3Qgc3RyaWRlc1s0XSwgdWludDMyX3Qgb2Zmc2V0c1s0XSwKPiArCQl1aW50 MzJfdCBmbGFncywgdWludDMyX3QgKmJ1Zl9pZCkKPiAgewo+ICAJc3RydWN0IGRybV9tb2RlX2Zi X2NtZDIgZjsKPiAgCWludCByZXQsIGk7Cj4gQEAgLTE2ODYsMTIgKzE2ODgsMTIgQEAgaW50IF9f a21zX2FkZGZiKGludCBmZCwgdWludDMyX3QgaGFuZGxlLAo+IHVpbnQzMl90IHdpZHRoLCB1aW50 MzJfdCBoZWlnaHQsCj4gIAlmLnBpeGVsX2Zvcm1hdCA9IHBpeGVsX2Zvcm1hdDsKPiAgCWYuZmxh Z3MgPSBmbGFnczsKPiAgCWYuaGFuZGxlc1swXSA9IGhhbmRsZTsKPiAtCWYucGl0Y2hlc1swXSA9 IHN0cmlkZTsKPiArCWYucGl0Y2hlc1swXSA9IHN0cmlkZXNbMF07Cj4gIAlmLm1vZGlmaWVyWzBd ID0gbW9kaWZpZXI7Cj4gIAo+ICAJZm9yIChpID0gMTsgaSA8IDQgJiYgb2Zmc2V0cyAmJiBvZmZz ZXRzW2ldOyBpKyspIHsKPiAgCQlmLmhhbmRsZXNbaV0gPSBoYW5kbGU7Cj4gLQkJZi5waXRjaGVz W2ldID0gc3RyaWRlOwo+ICsJCWYucGl0Y2hlc1tpXSA9IHN0cmlkZXNbaV07Cj4gIAkJZi5tb2Rp ZmllcltpXSA9IG1vZGlmaWVyOwo+ICAJCWYub2Zmc2V0c1tpXSA9IG9mZnNldHNbaV07Cj4gIAl9 Cj4gZGlmZiAtLWdpdCBhL2xpYi9pb2N0bF93cmFwcGVycy5oIGIvbGliL2lvY3RsX3dyYXBwZXJz LmgKPiBpbmRleCA4ZTJjZDM4MGI1NzUuLjY3YmY1MDU2MmJmMyAxMDA2NDQKPiAtLS0gYS9saWIv aW9jdGxfd3JhcHBlcnMuaAo+ICsrKyBiL2xpYi9pb2N0bF93cmFwcGVycy5oCj4gQEAgLTIzNSw5 ICsyMzUsMTEgQEAgdm9pZCBpZ3RfcmVxdWlyZV9mYl9tb2RpZmllcnMoaW50IGZkKTsKPiAgICoK PiAgICogQ3JlYXRlcyBhIGZyYW1lYnVmZmVyIG9iamVjdC4KPiAgICovCj4gLWludCBfX2ttc19h ZGRmYihpbnQgZmQsIHVpbnQzMl90IGhhbmRsZSwgdWludDMyX3Qgd2lkdGgsIHVpbnQzMl90Cj4g aGVpZ2h0LAo+IC0JCXVpbnQzMl90IHN0cmlkZSwgdWludDMyX3QgcGl4ZWxfZm9ybWF0LCB1aW50 NjRfdAo+IG1vZGlmaWVyLAo+IC0JCXVpbnQzMl90ICpvZmZzZXRzLCB1aW50MzJfdCBmbGFncywg dWludDMyX3QKPiAqYnVmX2lkKTsKPiAraW50IF9fa21zX2FkZGZiKGludCBmZCwgdWludDMyX3Qg aGFuZGxlLAo+ICsJCXVpbnQzMl90IHdpZHRoLCB1aW50MzJfdCBoZWlnaHQsCj4gKwkJdWludDMy X3QgcGl4ZWxfZm9ybWF0LCB1aW50NjRfdCBtb2RpZmllciwKPiArCQl1aW50MzJfdCBzdHJpZGVz WzRdLCB1aW50MzJfdCBvZmZzZXRzWzRdLAo+ICsJCXVpbnQzMl90IGZsYWdzLCB1aW50MzJfdCAq YnVmX2lkKTsKPiAgCj4gIC8qKgo+ICAgKiB0b191c2VyX3BvaW50ZXI6Cj4gZGlmZiAtLWdpdCBh L3Rlc3RzL2ttc19hdmFpbGFibGVfbW9kZXNfY3JjLmMKPiBiL3Rlc3RzL2ttc19hdmFpbGFibGVf bW9kZXNfY3JjLmMKPiBpbmRleCBiNzBlZjVkN2Q0YzAuLjFjODQzYzZjZjY5MSAxMDA2NDQKPiAt LS0gYS90ZXN0cy9rbXNfYXZhaWxhYmxlX21vZGVzX2NyYy5jCj4gKysrIGIvdGVzdHMva21zX2F2 YWlsYWJsZV9tb2Rlc19jcmMuYwo+IEBAIC0yNTUsNyArMjU1LDggQEAgc3RhdGljIGJvb2wgc2V0 dXBfZmIoZGF0YV90ICpkYXRhLCBpZ3Rfb3V0cHV0X3QKPiAqb3V0cHV0LCBpZ3RfcGxhbmVfdCAq cGxhbmUsCj4gIAlkcm1Nb2RlTW9kZUluZm8gKm1vZGU7Cj4gIAl1aW50NjRfdCB3LCBoOwo+ICAJ c2lnbmVkIHJldCwgZ2Vtc2l6ZSA9IDA7Cj4gLQl1bnNpZ25lZCB0aWxlX3dpZHRoLCB0aWxlX2hl aWdodCwgc3RyaWRlOwo+ICsJdW5zaWduZWQgdGlsZV93aWR0aCwgdGlsZV9oZWlnaHQ7Cj4gKwl1 aW50MzJfdCBzdHJpZGVzWzRdID0ge307Cj4gIAl1aW50MzJfdCBvZmZzZXRzWzRdID0ge307Cj4g IAl1aW50NjRfdCB0aWxpbmc7Cj4gIAlpbnQgYnBwID0gMDsKPiBAQCAtMjk2LDggKzI5Nyw4IEBA IHN0YXRpYyBib29sIHNldHVwX2ZiKGRhdGFfdCAqZGF0YSwgaWd0X291dHB1dF90Cj4gKm91dHB1 dCwgaWd0X3BsYW5lX3QgKnBsYW5lLAo+ICAKPiAgCWlndF9nZXRfZmJfdGlsZV9zaXplKGRhdGEt PmdmeF9mZCwgdGlsaW5nLCBicHAsCj4gIAkJCSAgICAgJnRpbGVfd2lkdGgsICZ0aWxlX2hlaWdo dCk7Cj4gLQlzdHJpZGUgPSBBTElHTih3ICogYnBwIC8gOCwgdGlsZV93aWR0aCk7Cj4gLQlnZW1z aXplID0gZGF0YS0+c2l6ZSA9IHN0cmlkZSAqIEFMSUdOKGgsIHRpbGVfaGVpZ2h0KTsKPiArCXN0 cmlkZXNbMF0gPSBBTElHTih3ICogYnBwIC8gOCwgdGlsZV93aWR0aCk7Cj4gKwlnZW1zaXplID0g ZGF0YS0+c2l6ZSA9IHN0cmlkZXNbMF0gKiBBTElHTihoLCB0aWxlX2hlaWdodCk7Cj4gIAo+ICAJ aWYgKGZpbGxlcnNbaV0uYnBwID09IFAwMTAgfHwgZmlsbGVyc1tpXS5icHAgPT0gTlYxMikgewo+ ICAJCW9mZnNldHNbMV0gPSBkYXRhLT5zaXplOwo+IEBAIC0zMDYsMTQgKzMwNywxMyBAQCBzdGF0 aWMgYm9vbCBzZXR1cF9mYihkYXRhX3QgKmRhdGEsIGlndF9vdXRwdXRfdAo+ICpvdXRwdXQsIGln dF9wbGFuZV90ICpwbGFuZSwKPiAgCj4gIAlkYXRhLT5nZW1faGFuZGxlID0gZ2VtX2NyZWF0ZShk YXRhLT5nZnhfZmQsIGdlbXNpemUpOwo+ICAJcmV0ID0gX19nZW1fc2V0X3RpbGluZyhkYXRhLT5n ZnhfZmQsIGRhdGEtPmdlbV9oYW5kbGUsCj4gLQkJCSAgICAgICBpZ3RfZmJfbW9kX3RvX3RpbGlu Zyh0aWxpbmcpLAo+IHN0cmlkZSk7Cj4gKwkJCSAgICAgICBpZ3RfZmJfbW9kX3RvX3RpbGluZyh0 aWxpbmcpLAo+IHN0cmlkZXNbMF0pOwo+ICAKPiAgCWlndF9hc3NlcnRfZXEocmV0LCAwKTsKPiAg Cj4gIAlyZXQgPSBfX2ttc19hZGRmYihkYXRhLT5nZnhfZmQsIGRhdGEtPmdlbV9oYW5kbGUsIHcs IGgsCj4gLQkJCSAgc3RyaWRlLCBmb3JtYXQsIHRpbGluZywKPiAtCQkJICBvZmZzZXRzLCBMT0NB TF9EUk1fTU9ERV9GQl9NT0RJRklFUlMsCj4gLQkJCSAgJmRhdGEtPmZiLmZiX2lkKTsKPiArCQkJ ICBmb3JtYXQsIHRpbGluZywgc3RyaWRlcywgb2Zmc2V0cywKPiArCQkJICBMT0NBTF9EUk1fTU9E RV9GQl9NT0RJRklFUlMsICZkYXRhLQo+ID5mYi5mYl9pZCk7Cj4gIAo+ICAJaWYocmV0IDwgMCkg ewo+ICAJCWlndF9pbmZvKCJDcmVhdGluZyBmYiBmb3IgZm9ybWF0ICVzIGZhaWxlZCwgcmV0dXJu Cj4gY29kZSAlZFxuIiwKPiBkaWZmIC0tZ2l0IGEvdGVzdHMva21zX2RyYXdfY3JjLmMgYi90ZXN0 cy9rbXNfZHJhd19jcmMuYwo+IGluZGV4IDg2ZGNmMzkyODVmMy4uZmIxMGQ3Y2NmOGJjIDEwMDY0 NAo+IC0tLSBhL3Rlc3RzL2ttc19kcmF3X2NyYy5jCj4gKysrIGIvdGVzdHMva21zX2RyYXdfY3Jj LmMKPiBAQCAtMTU2LDE0ICsxNTYsMTQgQEAgc3RhdGljIHZvaWQgZ2V0X21ldGhvZF9jcmMoZW51 bSBpZ3RfZHJhd19tZXRob2QKPiBtZXRob2QsIHVpbnQzMl90IGRybV9mb3JtYXQsCj4gIHN0YXRp YyBib29sIGZvcm1hdF9pc19zdXBwb3J0ZWQodWludDMyX3QgZm9ybWF0LCB1aW50NjRfdCBtb2Rp ZmllcikKPiAgewo+ICAJdWludDMyX3QgZ2VtX2hhbmRsZSwgZmJfaWQ7Cj4gLQl1bnNpZ25lZCBp bnQgc3RyaWRlOwo+ICsJdW5zaWduZWQgaW50IHN0cmlkZXNbNF0gPSB7fTsKPiAgCWludCByZXQ7 Cj4gIAo+ICAJZ2VtX2hhbmRsZSA9IGlndF9jcmVhdGVfYm9fd2l0aF9kaW1lbnNpb25zKGRybV9m ZCwgNjQsIDY0LAo+ICAJCQkJCQkgICBmb3JtYXQsIG1vZGlmaWVyLAo+IC0JCQkJCQkgICAwLCBO VUxMLCAmc3RyaWRlLAo+IE5VTEwpOwo+ICsJCQkJCQkgICAwLCBOVUxMLAo+ICZzdHJpZGVzWzBd LCBOVUxMKTsKPiAgCXJldCA9ICBfX2ttc19hZGRmYihkcm1fZmQsIGdlbV9oYW5kbGUsIDY0LCA2 NCwKPiAtCQkJICAgc3RyaWRlLCBmb3JtYXQsIG1vZGlmaWVyLCBOVUxMLAo+ICsJCQkgICBmb3Jt YXQsIG1vZGlmaWVyLCBzdHJpZGVzLCBOVUxMLAo+ICAJCQkgICBMT0NBTF9EUk1fTU9ERV9GQl9N T0RJRklFUlMsICZmYl9pZCk7Cj4gIAlkcm1Nb2RlUm1GQihkcm1fZmQsIGZiX2lkKTsKPiAgCWdl bV9jbG9zZShkcm1fZmQsIGdlbV9oYW5kbGUpOwo+IGRpZmYgLS1naXQgYS90ZXN0cy9wcmltZV92 Z2VtLmMgYi90ZXN0cy9wcmltZV92Z2VtLmMKPiBpbmRleCA3NjNjNjJlNjA2ZjYuLjFiN2Q4ZmIy OTNlZiAxMDA2NDQKPiAtLS0gYS90ZXN0cy9wcmltZV92Z2VtLmMKPiArKysgYi90ZXN0cy9wcmlt ZV92Z2VtLmMKPiBAQCAtNzA5LDYgKzcwOSw3IEBAIHN0YXRpYyB2b2lkIHRlc3RfZmxpcChpbnQg aTkxNSwgaW50IHZnZW0sCj4gdW5zaWduZWQgaGFuZykKPiAgCXNpZ25hbChTSUdIVVAsIHNpZ2hh bmRsZXIpOwo+ICAKPiAgCWZvciAoaW50IGkgPSAwOyBpIDwgMjsgaSsrKSB7Cj4gKwkJdWludDMy X3Qgc3RyaWRlc1s0XSA9IHt9Owo+ICAJCWludCBmZDsKPiAgCj4gIAkJYm9baV0ud2lkdGggPSAx MDI0Owo+IEBAIC03MjEsOSArNzIyLDEyIEBAIHN0YXRpYyB2b2lkIHRlc3RfZmxpcChpbnQgaTkx NSwgaW50IHZnZW0sCj4gdW5zaWduZWQgaGFuZykKPiAgCQlpZ3RfYXNzZXJ0KGhhbmRsZVtpXSk7 Cj4gIAkJY2xvc2UoZmQpOwo+ICAKPiArCQlzdHJpZGVzWzBdID0gYm9baV0ucGl0Y2g7Cj4gKwo+ ICAJCWRvX29yX2RpZShfX2ttc19hZGRmYihpOTE1LCBoYW5kbGVbaV0sCj4gLQkJCQkgICAgICBi b1tpXS53aWR0aCwgYm9baV0uaGVpZ2h0LAo+IGJvW2ldLnBpdGNoLAo+IC0JCQkJICAgICAgRFJN X0ZPUk1BVF9YUkdCODg4OCwKPiBJOTE1X1RJTElOR19OT05FLCBOVUxMLAo+ICsJCQkJICAgICAg Ym9baV0ud2lkdGgsIGJvW2ldLmhlaWdodCwKPiArCQkJCSAgICAgIERSTV9GT1JNQVRfWFJHQjg4 ODgsCj4gSTkxNV9USUxJTkdfTk9ORSwKPiArCQkJCSAgICAgIHN0cmlkZXMsIE5VTEwsCj4gIAkJ CQkgICAgICBMT0NBTF9EUk1fTU9ERV9GQl9NT0RJRklFUlMsCj4gJmZiX2lkW2ldKSk7Cj4gIAkJ aWd0X2Fzc2VydChmYl9pZFtpXSk7Cj4gIAl9Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaWd0LWRldgo=