From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AD906E286 for ; Fri, 21 Sep 2018 22:54:40 +0000 (UTC) Message-ID: <1537570479.3945.45.camel@intel.com> From: Paulo Zanoni Date: Fri, 21 Sep 2018 15:54:39 -0700 In-Reply-To: <20180719150415.935-16-ville.syrjala@linux.intel.com> References: <20180719150415.935-1-ville.syrjala@linux.intel.com> <20180719150415.935-16-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 16/25] lib/kms: Pass the number of planes explicitly to __kms_addfb() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville Syrjala , igt-dev@lists.freedesktop.org List-ID: RW0gUXVpLCAyMDE4LTA3LTE5IMOgcyAxODowNCArMDMwMCwgVmlsbGUgU3lyamFsYSBlc2NyZXZl dToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+IAo+IEN1cnJlbnRseSBfX2ttc19hZGRmYigpIGFzc3VtZXMgdGhhdCBvbmx5IHRoZSBmaXJz dCBwbGFuZSBjYW4gYmUKPiBhdCBvZmZzZXQgMC4gSSBkb24ndCBwYXJ0aWN1bGFybHkgbGlrZSBz dWNoIGFzc3VtcHRpb25zIHNvIGxldCdzCj4ganVzdCBwYXNzIGluIHRoZSBudW1iZXIgb2YgcGxh bmVzIGV4cGxpY2l0bHkuCj4gCj4gV2UnbGwgYWxzbyByZXF1aXJlIG9mZnNldHNbXSB0byBiZSBw YXNzZWQgaW4gYWx3YXlzLiBOb3RoaW5nIHJlYWxseQo+IHRvIGdhaW4gYnkgbWFraW5nIGl0IG9w dGlvbmFsLgoKUmV2aWV3ZWQtYnk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwu Y29tPgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBsaWIvaWd0X2ZiLmMgICAgICAgICAgICAgICAgICAg IHwgMSArCj4gIGxpYi9pb2N0bF93cmFwcGVycy5jICAgICAgICAgICAgfCA5ICsrKy0tLS0tLQo+ ICBsaWIvaW9jdGxfd3JhcHBlcnMuaCAgICAgICAgICAgIHwgMiArLQo+ICB0ZXN0cy9rbXNfYXZh aWxhYmxlX21vZGVzX2NyYy5jIHwgNSArKysrLQo+ICB0ZXN0cy9rbXNfZHJhd19jcmMuYyAgICAg ICAgICAgIHwgMyArKy0KPiAgdGVzdHMvcHJpbWVfdmdlbS5jICAgICAgICAgICAgICB8IDMgKyst Cj4gIDYgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZmIuYyBiL2xpYi9pZ3RfZmIuYwo+IGluZGV4IDVlNjg3 Yjk1ZTI2NS4uNzc2MTFiNTkzYTdlIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ICsrKyBi L2xpYi9pZ3RfZmIuYwo+IEBAIC04ODQsNiArODg0LDcgQEAgaWd0X2NyZWF0ZV9mYl93aXRoX2Jv X3NpemUoaW50IGZkLCBpbnQgd2lkdGgsIGludAo+IGhlaWdodCwKPiAgCj4gIAkJZG9fb3JfZGll KF9fa21zX2FkZGZiKGZkLCBmYi0+Z2VtX2hhbmRsZSwgd2lkdGgsCj4gaGVpZ2h0LAo+ICAJCQkJ ICAgICAgZm9ybWF0LCB0aWxpbmcsIHBpdGNoZXMsIGZiLQo+ID5vZmZzZXRzLAo+ICsJCQkJICAg ICAgZmJfbnVtX3BsYW5lcyhmKSwKPiAgCQkJCSAgICAgIExPQ0FMX0RSTV9NT0RFX0ZCX01PRElG SUVSUywKPiAmZmJfaWQpKTsKPiAgCX0gZWxzZSB7Cj4gIAkJdWludDMyX3QgaGFuZGxlc1s0XTsK PiBkaWZmIC0tZ2l0IGEvbGliL2lvY3RsX3dyYXBwZXJzLmMgYi9saWIvaW9jdGxfd3JhcHBlcnMu Ywo+IGluZGV4IGEzNDg1NzI2NmQ5Mi4uZDk5MmUwMTViOWM4IDEwMDY0NAo+IC0tLSBhL2xpYi9p b2N0bF93cmFwcGVycy5jCj4gKysrIGIvbGliL2lvY3RsX3dyYXBwZXJzLmMKPiBAQCAtMTY3NCw3 ICsxNjc0LDcgQEAgaW50IF9fa21zX2FkZGZiKGludCBmZCwgdWludDMyX3QgaGFuZGxlLAo+ICAJ CXVpbnQzMl90IHdpZHRoLCB1aW50MzJfdCBoZWlnaHQsCj4gIAkJdWludDMyX3QgcGl4ZWxfZm9y bWF0LCB1aW50NjRfdCBtb2RpZmllciwKPiAgCQl1aW50MzJfdCBzdHJpZGVzWzRdLCB1aW50MzJf dCBvZmZzZXRzWzRdLAo+IC0JCXVpbnQzMl90IGZsYWdzLCB1aW50MzJfdCAqYnVmX2lkKQo+ICsJ CWludCBudW1fcGxhbmVzLCB1aW50MzJfdCBmbGFncywgdWludDMyX3QgKmJ1Zl9pZCkKPiAgewo+ ICAJc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgZjsKPiAgCWludCByZXQsIGk7Cj4gQEAgLTE2ODcs MTQgKzE2ODcsMTEgQEAgaW50IF9fa21zX2FkZGZiKGludCBmZCwgdWludDMyX3QgaGFuZGxlLAo+ ICAJZi5oZWlnaHQgPSBoZWlnaHQ7Cj4gIAlmLnBpeGVsX2Zvcm1hdCA9IHBpeGVsX2Zvcm1hdDsK PiAgCWYuZmxhZ3MgPSBmbGFnczsKPiAtCWYuaGFuZGxlc1swXSA9IGhhbmRsZTsKPiAtCWYucGl0 Y2hlc1swXSA9IHN0cmlkZXNbMF07Cj4gLQlmLm1vZGlmaWVyWzBdID0gbW9kaWZpZXI7Cj4gIAo+ IC0JZm9yIChpID0gMTsgaSA8IDQgJiYgb2Zmc2V0cyAmJiBvZmZzZXRzW2ldOyBpKyspIHsKPiAr CWZvciAoaSA9IDA7IGkgPCBudW1fcGxhbmVzOyBpKyspIHsKPiAgCQlmLmhhbmRsZXNbaV0gPSBo YW5kbGU7Cj4gLQkJZi5waXRjaGVzW2ldID0gc3RyaWRlc1tpXTsKPiAgCQlmLm1vZGlmaWVyW2ld ID0gbW9kaWZpZXI7Cj4gKwkJZi5waXRjaGVzW2ldID0gc3RyaWRlc1tpXTsKPiAgCQlmLm9mZnNl dHNbaV0gPSBvZmZzZXRzW2ldOwo+ICAJfQo+ICAKPiBkaWZmIC0tZ2l0IGEvbGliL2lvY3RsX3dy YXBwZXJzLmggYi9saWIvaW9jdGxfd3JhcHBlcnMuaAo+IGluZGV4IDY3YmY1MDU2MmJmMy4uODcy ZTMwNTYzMTRiIDEwMDY0NAo+IC0tLSBhL2xpYi9pb2N0bF93cmFwcGVycy5oCj4gKysrIGIvbGli L2lvY3RsX3dyYXBwZXJzLmgKPiBAQCAtMjM5LDcgKzIzOSw3IEBAIGludCBfX2ttc19hZGRmYihp bnQgZmQsIHVpbnQzMl90IGhhbmRsZSwKPiAgCQl1aW50MzJfdCB3aWR0aCwgdWludDMyX3QgaGVp Z2h0LAo+ICAJCXVpbnQzMl90IHBpeGVsX2Zvcm1hdCwgdWludDY0X3QgbW9kaWZpZXIsCj4gIAkJ dWludDMyX3Qgc3RyaWRlc1s0XSwgdWludDMyX3Qgb2Zmc2V0c1s0XSwKPiAtCQl1aW50MzJfdCBm bGFncywgdWludDMyX3QgKmJ1Zl9pZCk7Cj4gKwkJaW50IG51bV9wbGFuZXMsIHVpbnQzMl90IGZs YWdzLCB1aW50MzJfdCAqYnVmX2lkKTsKPiAgCj4gIC8qKgo+ICAgKiB0b191c2VyX3BvaW50ZXI6 Cj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2ttc19hdmFpbGFibGVfbW9kZXNfY3JjLmMKPiBiL3Rlc3Rz L2ttc19hdmFpbGFibGVfbW9kZXNfY3JjLmMKPiBpbmRleCAxYzg0M2M2Y2Y2OTEuLjE0MTcwZWY3 MTFlMyAxMDA2NDQKPiAtLS0gYS90ZXN0cy9rbXNfYXZhaWxhYmxlX21vZGVzX2NyYy5jCj4gKysr IGIvdGVzdHMva21zX2F2YWlsYWJsZV9tb2Rlc19jcmMuYwo+IEBAIC0yNTgsNiArMjU4LDcgQEAg c3RhdGljIGJvb2wgc2V0dXBfZmIoZGF0YV90ICpkYXRhLCBpZ3Rfb3V0cHV0X3QKPiAqb3V0cHV0 LCBpZ3RfcGxhbmVfdCAqcGxhbmUsCj4gIAl1bnNpZ25lZCB0aWxlX3dpZHRoLCB0aWxlX2hlaWdo dDsKPiAgCXVpbnQzMl90IHN0cmlkZXNbNF0gPSB7fTsKPiAgCXVpbnQzMl90IG9mZnNldHNbNF0g PSB7fTsKPiArCWludCBudW1fcGxhbmVzID0gMTsKPiAgCXVpbnQ2NF90IHRpbGluZzsKPiAgCWlu dCBicHAgPSAwOwo+ICAJaW50IGk7Cj4gQEAgLTMwMyw2ICszMDQsNyBAQCBzdGF0aWMgYm9vbCBz ZXR1cF9mYihkYXRhX3QgKmRhdGEsIGlndF9vdXRwdXRfdAo+ICpvdXRwdXQsIGlndF9wbGFuZV90 ICpwbGFuZSwKPiAgCWlmIChmaWxsZXJzW2ldLmJwcCA9PSBQMDEwIHx8IGZpbGxlcnNbaV0uYnBw ID09IE5WMTIpIHsKPiAgCQlvZmZzZXRzWzFdID0gZGF0YS0+c2l6ZTsKPiAgCQlnZW1zaXplID0g ZGF0YS0+c2l6ZSAqIDI7Cj4gKwkJbnVtX3BsYW5lcyA9IDI7Cj4gIAl9Cj4gIAo+ICAJZGF0YS0+ Z2VtX2hhbmRsZSA9IGdlbV9jcmVhdGUoZGF0YS0+Z2Z4X2ZkLCBnZW1zaXplKTsKPiBAQCAtMzEz LDcgKzMxNSw4IEBAIHN0YXRpYyBib29sIHNldHVwX2ZiKGRhdGFfdCAqZGF0YSwgaWd0X291dHB1 dF90Cj4gKm91dHB1dCwgaWd0X3BsYW5lX3QgKnBsYW5lLAo+ICAKPiAgCXJldCA9IF9fa21zX2Fk ZGZiKGRhdGEtPmdmeF9mZCwgZGF0YS0+Z2VtX2hhbmRsZSwgdywgaCwKPiAgCQkJICBmb3JtYXQs IHRpbGluZywgc3RyaWRlcywgb2Zmc2V0cywKPiAtCQkJICBMT0NBTF9EUk1fTU9ERV9GQl9NT0RJ RklFUlMsICZkYXRhLQo+ID5mYi5mYl9pZCk7Cj4gKwkJCSAgbnVtX3BsYW5lcywgTE9DQUxfRFJN X01PREVfRkJfTU9ESUZJRVJTLAo+ICsJCQkgICZkYXRhLT5mYi5mYl9pZCk7Cj4gIAo+ICAJaWYo cmV0IDwgMCkgewo+ICAJCWlndF9pbmZvKCJDcmVhdGluZyBmYiBmb3IgZm9ybWF0ICVzIGZhaWxl ZCwgcmV0dXJuCj4gY29kZSAlZFxuIiwKPiBkaWZmIC0tZ2l0IGEvdGVzdHMva21zX2RyYXdfY3Jj LmMgYi90ZXN0cy9rbXNfZHJhd19jcmMuYwo+IGluZGV4IGZiMTBkN2NjZjhiYy4uOTA5MDQ3MTQy ODNjIDEwMDY0NAo+IC0tLSBhL3Rlc3RzL2ttc19kcmF3X2NyYy5jCj4gKysrIGIvdGVzdHMva21z X2RyYXdfY3JjLmMKPiBAQCAtMTU2LDYgKzE1Niw3IEBAIHN0YXRpYyB2b2lkIGdldF9tZXRob2Rf Y3JjKGVudW0gaWd0X2RyYXdfbWV0aG9kCj4gbWV0aG9kLCB1aW50MzJfdCBkcm1fZm9ybWF0LAo+ ICBzdGF0aWMgYm9vbCBmb3JtYXRfaXNfc3VwcG9ydGVkKHVpbnQzMl90IGZvcm1hdCwgdWludDY0 X3QgbW9kaWZpZXIpCj4gIHsKPiAgCXVpbnQzMl90IGdlbV9oYW5kbGUsIGZiX2lkOwo+ICsJdW5z aWduZWQgaW50IG9mZnNldHNbNF0gPSB7fTsKPiAgCXVuc2lnbmVkIGludCBzdHJpZGVzWzRdID0g e307Cj4gIAlpbnQgcmV0Owo+ICAKPiBAQCAtMTYzLDcgKzE2NCw3IEBAIHN0YXRpYyBib29sIGZv cm1hdF9pc19zdXBwb3J0ZWQodWludDMyX3QgZm9ybWF0LAo+IHVpbnQ2NF90IG1vZGlmaWVyKQo+ ICAJCQkJCQkgICBmb3JtYXQsIG1vZGlmaWVyLAo+ICAJCQkJCQkgICAwLCBOVUxMLAo+ICZzdHJp ZGVzWzBdLCBOVUxMKTsKPiAgCXJldCA9ICBfX2ttc19hZGRmYihkcm1fZmQsIGdlbV9oYW5kbGUs IDY0LCA2NCwKPiAtCQkJICAgZm9ybWF0LCBtb2RpZmllciwgc3RyaWRlcywgTlVMTCwKPiArCQkJ ICAgZm9ybWF0LCBtb2RpZmllciwgc3RyaWRlcywgb2Zmc2V0cywgMSwKPiAgCQkJICAgTE9DQUxf RFJNX01PREVfRkJfTU9ESUZJRVJTLCAmZmJfaWQpOwo+ICAJZHJtTW9kZVJtRkIoZHJtX2ZkLCBm Yl9pZCk7Cj4gIAlnZW1fY2xvc2UoZHJtX2ZkLCBnZW1faGFuZGxlKTsKPiBkaWZmIC0tZ2l0IGEv dGVzdHMvcHJpbWVfdmdlbS5jIGIvdGVzdHMvcHJpbWVfdmdlbS5jCj4gaW5kZXggMWI3ZDhmYjI5 M2VmLi5kMDZhYTI0YjVlZjIgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMvcHJpbWVfdmdlbS5jCj4gKysr IGIvdGVzdHMvcHJpbWVfdmdlbS5jCj4gQEAgLTcxMCw2ICs3MTAsNyBAQCBzdGF0aWMgdm9pZCB0 ZXN0X2ZsaXAoaW50IGk5MTUsIGludCB2Z2VtLAo+IHVuc2lnbmVkIGhhbmcpCj4gIAo+ICAJZm9y IChpbnQgaSA9IDA7IGkgPCAyOyBpKyspIHsKPiAgCQl1aW50MzJfdCBzdHJpZGVzWzRdID0ge307 Cj4gKwkJdWludDMyX3Qgb2Zmc2V0c1s0XSA9IHt9Owo+ICAJCWludCBmZDsKPiAgCj4gIAkJYm9b aV0ud2lkdGggPSAxMDI0Owo+IEBAIC03MjcsNyArNzI4LDcgQEAgc3RhdGljIHZvaWQgdGVzdF9m bGlwKGludCBpOTE1LCBpbnQgdmdlbSwKPiB1bnNpZ25lZCBoYW5nKQo+ICAJCWRvX29yX2RpZShf X2ttc19hZGRmYihpOTE1LCBoYW5kbGVbaV0sCj4gIAkJCQkgICAgICBib1tpXS53aWR0aCwgYm9b aV0uaGVpZ2h0LAo+ICAJCQkJICAgICAgRFJNX0ZPUk1BVF9YUkdCODg4OCwKPiBJOTE1X1RJTElO R19OT05FLAo+IC0JCQkJICAgICAgc3RyaWRlcywgTlVMTCwKPiArCQkJCSAgICAgIHN0cmlkZXMs IG9mZnNldHMsIDEsCj4gIAkJCQkgICAgICBMT0NBTF9EUk1fTU9ERV9GQl9NT0RJRklFUlMsCj4g JmZiX2lkW2ldKSk7Cj4gIAkJaWd0X2Fzc2VydChmYl9pZFtpXSk7Cj4gIAl9Cl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0 CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=