From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B3266E044 for ; Fri, 21 Sep 2018 23:15:36 +0000 (UTC) Message-ID: <1537571734.3945.52.camel@intel.com> From: Paulo Zanoni Date: Fri, 21 Sep 2018 16:15:34 -0700 In-Reply-To: <20180719150415.935-17-ville.syrjala@linux.intel.com> References: <20180719150415.935-1-ville.syrjala@linux.intel.com> <20180719150415.935-17-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 17/25] lib/igt_fb: Remove the hand rolled addfb2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville Syrjala , igt-dev@lists.freedesktop.org List-ID: RW0gUXVpLCAyMDE4LTA3LTE5IMOgcyAxODowNCArMDMwMCwgVmlsbGUgU3lyamFsYSBlc2NyZXZl dToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+IAo+IEp1c3QgdXNlIF9fa21zX2FkZGZiKCkgYWx3YXlzIGluc3RlYWQgb2YgaGFuZCByb2xs aW5nIGFub3RoZXIKPiBkcm1Nb2RlQWRkRkIyKCkgdXNhZ2UuIF9fa21zX2FkZGZiKCkgZGVtYW5k cyBzdXBwb3J0IGZvciBtb2RpZmllcnMKPiBidXQgd2UndmUgaGFkIHRoYXQgZm9yIGEgbG9uZyB0 aW1lIG5vdyBzbyBpdCdzIG5vdCBhIHByb2JsZW0uCgpEZWFyIElHVCBtYWluYWluZXJzLCBkbyB3 ZSBoYXZlIGFueSBzcGVjaWZpYyBydWxlcy9yZXF1aXJlbWVudHMgYWJvdXQKcnVubmluZyBuZXcg SUdUIGluIG9sZGVyIEtlcm5lbHM/IEEgbWluaW11bS9tYXhpbXVtIGFnZT8KCj4gCj4gU2lnbmVk LW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K PiAtLS0KPiAgbGliL2lndF9mYi5jIHwgMzUgKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMjggZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZmIuYyBiL2xpYi9pZ3RfZmIuYwo+IGluZGV4IDc3 NjExYjU5M2E3ZS4uNjQ4ZjBhMzE4YzkxIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ICsr KyBiL2xpYi9pZ3RfZmIuYwo+IEBAIC04NTYsNiArODU2LDcgQEAgaWd0X2NyZWF0ZV9mYl93aXRo X2JvX3NpemUoaW50IGZkLCBpbnQgd2lkdGgsIGludAo+IGhlaWdodCwKPiAgCWVudW0gaWd0X2Nv bG9yX2VuY29kaW5nIGNvbG9yX2VuY29kaW5nID0KPiBJR1RfQ09MT1JfWUNCQ1JfQlQ3MDk7Cj4g IAllbnVtIGlndF9jb2xvcl9yYW5nZSBjb2xvcl9yYW5nZSA9Cj4gSUdUX0NPTE9SX1lDQkNSX0xJ TUlURURfUkFOR0U7Cj4gIAlzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmID0gbG9va3VwX2Ry bV9mb3JtYXQoZm9ybWF0KTsKPiArCXVpbnQzMl90IHBpdGNoZXNbNF07Cj4gIAl1aW50MzJfdCBm Yl9pZDsKPiAgCWludCBpOwo+ICAKPiBAQCAtODc1LDM1ICs4NzYsMTMgQEAgaWd0X2NyZWF0ZV9m Yl93aXRoX2JvX3NpemUoaW50IGZkLCBpbnQgd2lkdGgsCj4gaW50IGhlaWdodCwKPiAgCWlndF9k ZWJ1ZygiJXMoaGFuZGxlPSVkLCBwaXRjaD0lZClcbiIsCj4gIAkJICBfX2Z1bmNfXywgZmItPmdl bV9oYW5kbGUsIGZiLT5zdHJpZGUpOwo+ICAKPiAtCWlmICh0aWxpbmcgIT0gTE9DQUxfRFJNX0ZP Uk1BVF9NT0RfTk9ORSAmJgo+IC0JICAgIHRpbGluZyAhPSBMT0NBTF9JOTE1X0ZPUk1BVF9NT0Rf WF9USUxFRCkgewo+IC0JCXVpbnQzMl90IHBpdGNoZXNbNF07Cj4gLQo+IC0JCWZvciAoaSA9IDA7 IGkgPCBmYl9udW1fcGxhbmVzKGYpOyBpKyspCj4gLQkJCXBpdGNoZXNbaV0gPSBmYi0+c3RyaWRl Owo+IC0KPiAtCQlkb19vcl9kaWUoX19rbXNfYWRkZmIoZmQsIGZiLT5nZW1faGFuZGxlLCB3aWR0 aCwKPiBoZWlnaHQsCj4gLQkJCQkgICAgICBmb3JtYXQsIHRpbGluZywgcGl0Y2hlcywgZmItCj4g Pm9mZnNldHMsCj4gLQkJCQkgICAgICBmYl9udW1fcGxhbmVzKGYpLAo+IC0JCQkJICAgICAgTE9D QUxfRFJNX01PREVfRkJfTU9ESUZJRVJTLAo+ICZmYl9pZCkpOwo+IC0JfSBlbHNlIHsKPiAtCQl1 aW50MzJfdCBoYW5kbGVzWzRdOwo+IC0JCXVpbnQzMl90IHBpdGNoZXNbNF07Cj4gKwlmb3IgKGkg PSAwOyBpIDwgZmJfbnVtX3BsYW5lcyhmKTsgaSsrKQo+ICsJCXBpdGNoZXNbaV0gPSBmYi0+c3Ry aWRlOwo+ICAKPiAtCQltZW1zZXQoaGFuZGxlcywgMCwgc2l6ZW9mKGhhbmRsZXMpKTsKPiAtCQlt ZW1zZXQocGl0Y2hlcywgMCwgc2l6ZW9mKHBpdGNoZXMpKTsKPiAtCj4gLQkJaGFuZGxlc1swXSA9 IGZiLT5nZW1faGFuZGxlOwo+IC0JCXBpdGNoZXNbMF0gPSBmYi0+c3RyaWRlOwo+IC0JCWZvciAo aSA9IDA7IGkgPCBmYl9udW1fcGxhbmVzKGYpOyBpKyspIHsKPiAtCQkJaGFuZGxlc1tpXSA9IGZi LT5nZW1faGFuZGxlOwo+IC0JCQlwaXRjaGVzW2ldID0gZmItPnN0cmlkZTsKPiAtCQl9Cj4gLQo+ IC0JCWRvX29yX2RpZShkcm1Nb2RlQWRkRkIyKGZkLCB3aWR0aCwgaGVpZ2h0LCBmb3JtYXQsCj4g LQkJCQkJaGFuZGxlcywgcGl0Y2hlcywgZmItCj4gPm9mZnNldHMsCj4gLQkJCQkJJmZiX2lkLCAw KSk7Cj4gLQl9Cj4gKwlkb19vcl9kaWUoX19rbXNfYWRkZmIoZmQsIGZiLT5nZW1faGFuZGxlLCB3 aWR0aCwgaGVpZ2h0LAo+ICsJCQkgICAgICBmb3JtYXQsIHRpbGluZywgcGl0Y2hlcywgZmItPm9m ZnNldHMsCgpTbyB0aGUgcmVhbCBkaWZmZXJlbmNlIGlzIHRoYXQgd2Ugbm93IHBhc3MgInRpbGlu ZyIgYXMgYSBtb2RpZmllciBhcwpvcHBvc2VkIHRvIG5vdGhpbmcsIGZvciB0aGUgWCBhbmQgbGlu ZWFyIGZvcm1hdHMuIEEgcXVpY2sgbG9vayBhdAppbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KCkgc3Vn Z2VzdHMgdGhhdCB0aGlzIGlzIGZpbmUgKGFuZCByZXF1aXJlZCkuCgpBcyBsb25nIGFzIG1haW50 YWluZXJzIGRvbid0IGJsb2NrIGl0OgpSZXZpZXdlZC1ieTogUGF1bG8gWmFub25pIDxwYXVsby5y Lnphbm9uaUBpbnRlbC5jb20+CgpCdXQgbm93IF9fa21zX2FkZGZiKCkgaXMgYWxtb3N0IGEgcmVp bXBsZW1lbnRhdGlvbiBvZiBvZgpkcm1Nb2RlQWRkRkIyV2l0aE1vZGlmaWVycygpLCBtYXliZSB3 ZSBjb3VsZCB1c2UgaXQgaW5zdGVhZC4KCj4gKwkJCSAgICAgIGZiX251bV9wbGFuZXMoZiksCj4g KwkJCSAgICAgIExPQ0FMX0RSTV9NT0RFX0ZCX01PRElGSUVSUywgJmZiX2lkKSk7Cj4gIAo+ICAJ ZmItPndpZHRoID0gd2lkdGg7Cj4gIAlmYi0+aGVpZ2h0ID0gaGVpZ2h0OwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdApp Z3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK