From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 83EF46E044 for ; Fri, 21 Sep 2018 23:20:08 +0000 (UTC) Message-ID: <1537572007.3945.54.camel@intel.com> From: Paulo Zanoni Date: Fri, 21 Sep 2018 16:20:07 -0700 In-Reply-To: <20180719150415.935-18-ville.syrjala@linux.intel.com> References: <20180719150415.935-1-ville.syrjala@linux.intel.com> <20180719150415.935-18-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 18/25] lib/igt_fb: Constify format_desc_struct List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville Syrjala , igt-dev@lists.freedesktop.org List-ID: RW0gUXVpLCAyMDE4LTA3LTE5IMOgcyAxODowNCArMDMwMCwgVmlsbGUgU3lyamFsYSBlc2NyZXZl dToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+IAo+IFdlIGRvbid0IHdhbnQgYW55b25lIHRvIG1vZGlmeSB0aGUgZm9ybWF0IGRlc2NyaXB0 aW9uIHN0cnVjdHVyZXMuCj4gTWFrZQo+IHRoZW0gY29uc3QuCgpSZXZpZXdlZC1ieTogUGF1bG8g WmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cgo+IAo+IFNpZ25lZC1vZmYtYnk6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGxp Yi9pZ3RfZmIuYyB8IDQ0ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gaW5kZXggNjQ4 ZjBhMzE4YzkxLi40OWUzMjNiMjJkMjYgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9mYi5jCj4gKysr IGIvbGliL2lndF9mYi5jCj4gQEAgLTYwLDcgKzYwLDcgQEAKPiAgICovCj4gIAo+ICAvKiBkcm0g Zm91cmNjL2NhaXJvIGZvcm1hdCBtYXBzICovCj4gLXN0YXRpYyBzdHJ1Y3QgZm9ybWF0X2Rlc2Nf c3RydWN0IHsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3Qgewo+ICAJ Y29uc3QgY2hhciAqbmFtZTsKPiAgCXVpbnQzMl90IGRybV9pZDsKPiAgCWNhaXJvX2Zvcm1hdF90 IGNhaXJvX2lkOwo+IEBAIC0xMDgsOSArMTA4LDkgQEAgc3RhdGljIHN0cnVjdCBmb3JtYXRfZGVz Y19zdHJ1Y3Qgewo+ICAjZGVmaW5lIGZvcl9lYWNoX2Zvcm1hdChmKQlcCj4gIAlmb3IgKGYgPSBm b3JtYXRfZGVzYzsgZiAtIGZvcm1hdF9kZXNjIDwKPiBBUlJBWV9TSVpFKGZvcm1hdF9kZXNjKTsg ZisrKQo+ICAKPiAtc3RhdGljIHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmxvb2t1cF9kcm1f Zm9ybWF0KHVpbnQzMl90Cj4gZHJtX2Zvcm1hdCkKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBmb3Jt YXRfZGVzY19zdHJ1Y3QgKmxvb2t1cF9kcm1fZm9ybWF0KHVpbnQzMl90Cj4gZHJtX2Zvcm1hdCkK PiAgewo+IC0Jc3RydWN0IGZvcm1hdF9kZXNjX3N0cnVjdCAqZm9ybWF0Owo+ICsJY29uc3Qgc3Ry dWN0IGZvcm1hdF9kZXNjX3N0cnVjdCAqZm9ybWF0Owo+ICAKPiAgCWZvcl9lYWNoX2Zvcm1hdChm b3JtYXQpIHsKPiAgCQlpZiAoZm9ybWF0LT5kcm1faWQgIT0gZHJtX2Zvcm1hdCkKPiBAQCAtMTkw LDggKzE5MCw4IEBAIHZvaWQgaWd0X2dldF9mYl90aWxlX3NpemUoaW50IGZkLCB1aW50NjRfdAo+ IHRpbGluZywgaW50IGZiX2JwcCwKPiAgCX0KPiAgfQo+ICAKPiAtc3RhdGljIHVuc2lnbmVkIGZi X3BsYW5lX3dpZHRoKHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmZvcm1hdCwKPiAtCQkJICAg ICAgIHVuc2lnbmVkIHdpZHRoLCBpbnQgcGxhbmUpCj4gK3N0YXRpYyB1bnNpZ25lZCBmYl9wbGFu ZV93aWR0aChjb25zdCBzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0Cj4gKmZvcm1hdCwKPiArCQkJ ICAgICAgIGludCBwbGFuZSwgdW5zaWduZWQgd2lkdGgpCj4gIHsKPiAgCWlmIChmb3JtYXQtPmRy bV9pZCA9PSBEUk1fRk9STUFUX05WMTIgJiYgcGxhbmUgPT0gMSkKPiAgCQlyZXR1cm4gRElWX1JP VU5EX1VQKHdpZHRoLCAyKTsKPiBAQCAtMTk5LDIxICsxOTksMjEgQEAgc3RhdGljIHVuc2lnbmVk IGZiX3BsYW5lX3dpZHRoKHN0cnVjdAo+IGZvcm1hdF9kZXNjX3N0cnVjdCAqZm9ybWF0LAo+ICAJ cmV0dXJuIHdpZHRoOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdW5zaWduZWQgZmJfcGxhbmVfYnBwKHN0 cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmZvcm1hdCwgaW50Cj4gcGxhbmUpCj4gK3N0YXRpYyB1 bnNpZ25lZCBmYl9wbGFuZV9icHAoY29uc3Qgc3RydWN0IGZvcm1hdF9kZXNjX3N0cnVjdAo+ICpm b3JtYXQsIGludCBwbGFuZSkKPiAgewo+ICAJcmV0dXJuIGZvcm1hdC0+cGxhbmVfYnBwW3BsYW5l XTsKPiAgfQo+ICAKPiAtc3RhdGljIHVuc2lnbmVkIGZiX3BsYW5lX21pbl9zdHJpZGUoc3RydWN0 IGZvcm1hdF9kZXNjX3N0cnVjdAo+ICpmb3JtYXQsCj4gLQkJCQkgICAgdW5zaWduZWQgd2lkdGgs IGludCBwbGFuZSkKPiArc3RhdGljIHVuc2lnbmVkIGZiX3BsYW5lX21pbl9zdHJpZGUoY29uc3Qg c3RydWN0IGZvcm1hdF9kZXNjX3N0cnVjdAo+ICpmb3JtYXQsCj4gKwkJCQkgICAgaW50IHBsYW5l LCB1bnNpZ25lZCB3aWR0aCkKPiAgewo+ICAJdW5zaWduZWQgY3BwID0gZmJfcGxhbmVfYnBwKGZv cm1hdCwgcGxhbmUpIC8gODsKPiAgCj4gIAlyZXR1cm4gZmJfcGxhbmVfd2lkdGgoZm9ybWF0LCB3 aWR0aCwgcGxhbmUpICogY3BwOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdW5zaWduZWQgZmJfcGxhbmVf aGVpZ2h0KHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmZvcm1hdCwKPiAtCQkJCXVuc2lnbmVk IGhlaWdodCwgaW50IHBsYW5lKQo+ICtzdGF0aWMgdW5zaWduZWQgZmJfcGxhbmVfaGVpZ2h0KGNv bnN0IHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QKPiAqZm9ybWF0LAo+ICsJCQkJaW50IHBsYW5l LCB1bnNpZ25lZCBoZWlnaHQpCj4gIHsKPiAgCWlmIChmb3JtYXQtPmRybV9pZCA9PSBEUk1fRk9S TUFUX05WMTIgJiYgcGxhbmUgPT0gMSkKPiAgCQlyZXR1cm4gRElWX1JPVU5EX1VQKGhlaWdodCwg Mik7Cj4gQEAgLTIyMSwxMyArMjIxLDEzIEBAIHN0YXRpYyB1bnNpZ25lZCBmYl9wbGFuZV9oZWln aHQoc3RydWN0Cj4gZm9ybWF0X2Rlc2Nfc3RydWN0ICpmb3JtYXQsCj4gIAlyZXR1cm4gaGVpZ2h0 Owo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGZiX251bV9wbGFuZXMoc3RydWN0IGZvcm1hdF9kZXNj X3N0cnVjdCAqZm9ybWF0KQo+ICtzdGF0aWMgaW50IGZiX251bV9wbGFuZXMoY29uc3Qgc3RydWN0 IGZvcm1hdF9kZXNjX3N0cnVjdCAqZm9ybWF0KQo+ICB7Cj4gIAlyZXR1cm4gZm9ybWF0LT5udW1f cGxhbmVzOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdW5zaWduZWQgY2FsY19wbGFuZV9zdHJpZGUoaW50 IGZkLAo+IC0JCQkJICBzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmb3JtYXQsCj4gKwkJCQkg IGNvbnN0IHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QKPiAqZm9ybWF0LAo+ICAJCQkJICBpbnQg d2lkdGgsIHVpbnQ2NF90IHRpbGluZywgaW50Cj4gcGxhbmUpCj4gIHsKPiAgCXVpbnQzMl90IG1p bl9zdHJpZGUgPSBmYl9wbGFuZV9taW5fc3RyaWRlKGZvcm1hdCwgd2lkdGgsCj4gcGxhbmUpOwo+ IEBAIC0yNTksNyArMjU5LDcgQEAgc3RhdGljIHVuc2lnbmVkIGNhbGNfcGxhbmVfc3RyaWRlKGlu dCBmZCwKPiAgfQo+ICAKPiAgc3RhdGljIHVuc2lnbmVkIGNhbGNfcGxhbmVfc2l6ZShpbnQgZmQs IGludCB3aWR0aCwgaW50IGhlaWdodCwKPiAtCQkJCXN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3Qg KmZvcm1hdCwKPiArCQkJCWNvbnN0IHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QKPiAqZm9ybWF0 LAo+ICAJCQkJdWludDY0X3QgdGlsaW5nLCBpbnQgcGxhbmUsCj4gIAkJCQl1aW50MzJfdCBzdHJp ZGUpCj4gIHsKPiBAQCAtMjkwLDcgKzI5MCw3IEBAIHN0YXRpYyB1bnNpZ25lZCBjYWxjX3BsYW5l X3NpemUoaW50IGZkLCBpbnQKPiB3aWR0aCwgaW50IGhlaWdodCwKPiAgfQo+ICAKPiAgc3RhdGlj IHVuc2lnbmVkIGNhbGNfZmJfc2l6ZShpbnQgZmQsIGludCB3aWR0aCwgaW50IGhlaWdodCwKPiAt CQkJICAgICBzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmb3JtYXQsCj4gKwkJCSAgICAgY29u c3Qgc3RydWN0IGZvcm1hdF9kZXNjX3N0cnVjdAo+ICpmb3JtYXQsCj4gIAkJCSAgICAgdWludDY0 X3QgdGlsaW5nLAo+ICAJCQkgICAgIHVpbnQzMl90IHN0cmlkZXNbNF0sIHVpbnQzMl90Cj4gb2Zm c2V0c1s0XSkKPiAgewo+IEBAIC0zMzUsNyArMzM1LDcgQEAgc3RhdGljIHVuc2lnbmVkIGNhbGNf ZmJfc2l6ZShpbnQgZmQsIGludCB3aWR0aCwKPiBpbnQgaGVpZ2h0LAo+ICB2b2lkIGlndF9jYWxj X2ZiX3NpemUoaW50IGZkLCBpbnQgd2lkdGgsIGludCBoZWlnaHQsIHVpbnQzMl90Cj4gZHJtX2Zv cm1hdCwgdWludDY0X3QgdGlsaW5nLAo+ICAJCSAgICAgIHVuc2lnbmVkICpzaXplX3JldCwgdW5z aWduZWQgKnN0cmlkZV9yZXQpCj4gIHsKPiAtCXN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmZv cm1hdCA9Cj4gbG9va3VwX2RybV9mb3JtYXQoZHJtX2Zvcm1hdCk7Cj4gKwljb25zdCBzdHJ1Y3Qg Zm9ybWF0X2Rlc2Nfc3RydWN0ICpmb3JtYXQgPQo+IGxvb2t1cF9kcm1fZm9ybWF0KGRybV9mb3Jt YXQpOwo+ICAJdWludDMyX3Qgc3RyaWRlc1s0XSA9IHt9Owo+ICAKPiAgCWlndF9hc3NlcnQoZm9y bWF0KTsKPiBAQCAtNDAwLDcgKzQwMCw3IEBAIHVpbnQ2NF90IGlndF9mYl90aWxpbmdfdG9fbW9k KHVpbnQ2NF90IHRpbGluZykKPiAgc3RhdGljIGludCBjcmVhdGVfYm9fZm9yX2ZiKGludCBmZCwg aW50IHdpZHRoLCBpbnQgaGVpZ2h0LAo+ICAJCQkgICAgZW51bSBpZ3RfY29sb3JfZW5jb2Rpbmcg Y29sb3JfZW5jb2RpbmcsCj4gIAkJCSAgICBlbnVtIGlndF9jb2xvcl9yYW5nZSBjb2xvcl9yYW5n ZSwKPiAtCQkJICAgIHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmZvcm1hdCwKPiArCQkJICAg IGNvbnN0IHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmZvcm1hdCwKPiAgCQkJICAgIHVpbnQ2 NF90IHRpbGluZywgdW5zaWduZWQgc2l6ZSwgdW5zaWduZWQKPiBzdHJpZGUsCj4gIAkJCSAgICB1 bnNpZ25lZCAqc2l6ZV9yZXQsIHVuc2lnbmVkCj4gKnN0cmlkZV9yZXQsCj4gIAkJCSAgICB1aW50 MzJfdCBvZmZzZXRzWzRdLCBib29sICppc19kdW1iKQo+IEBAIC04NTUsNyArODU1LDcgQEAgaWd0 X2NyZWF0ZV9mYl93aXRoX2JvX3NpemUoaW50IGZkLCBpbnQgd2lkdGgsIGludAo+IGhlaWdodCwK PiAgCS8qIEZJWE1FIGFsbG93IHRoZSBjYWxsZXIgdG8gcGFzcyB0aGVzZSBpbiAqLwo+ICAJZW51 bSBpZ3RfY29sb3JfZW5jb2RpbmcgY29sb3JfZW5jb2RpbmcgPQo+IElHVF9DT0xPUl9ZQ0JDUl9C VDcwOTsKPiAgCWVudW0gaWd0X2NvbG9yX3JhbmdlIGNvbG9yX3JhbmdlID0KPiBJR1RfQ09MT1Jf WUNCQ1JfTElNSVRFRF9SQU5HRTsKPiAtCXN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmYgPSBs b29rdXBfZHJtX2Zvcm1hdChmb3JtYXQpOwo+ICsJY29uc3Qgc3RydWN0IGZvcm1hdF9kZXNjX3N0 cnVjdCAqZiA9Cj4gbG9va3VwX2RybV9mb3JtYXQoZm9ybWF0KTsKPiAgCXVpbnQzMl90IHBpdGNo ZXNbNF07Cj4gIAl1aW50MzJfdCBmYl9pZDsKPiAgCWludCBpOwo+IEBAIC0xMTk1LDcgKzExOTUs NyBAQCB1bnNpZ25lZCBpbnQgaWd0X2NyZWF0ZV9zdGVyZW9fZmIoaW50IGRybV9mZCwKPiBkcm1N b2RlTW9kZUluZm8gKm1vZGUsCj4gIAo+ICBzdGF0aWMgY2Fpcm9fZm9ybWF0X3QgZHJtX2Zvcm1h dF90b19jYWlybyh1aW50MzJfdCBkcm1fZm9ybWF0KQo+ICB7Cj4gLQlzdHJ1Y3QgZm9ybWF0X2Rl c2Nfc3RydWN0ICpmOwo+ICsJY29uc3Qgc3RydWN0IGZvcm1hdF9kZXNjX3N0cnVjdCAqZjsKPiAg Cj4gIAlmb3JfZWFjaF9mb3JtYXQoZikKPiAgCQlpZiAoZi0+ZHJtX2lkID09IGRybV9mb3JtYXQp Cj4gQEAgLTE5NTMsNyArMTk1Myw3IEBAIHZvaWQgaWd0X3JlbW92ZV9mYihpbnQgZmQsIHN0cnVj dCBpZ3RfZmIgKmZiKQo+ICAgKi8KPiAgdWludDMyX3QgaWd0X2JwcF9kZXB0aF90b19kcm1fZm9y bWF0KGludCBicHAsIGludCBkZXB0aCkKPiAgewo+IC0Jc3RydWN0IGZvcm1hdF9kZXNjX3N0cnVj dCAqZjsKPiArCWNvbnN0IHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmY7Cj4gIAo+ICAJZm9y X2VhY2hfZm9ybWF0KGYpCj4gIAkJaWYgKGYtPnBsYW5lX2JwcFswXSA9PSBicHAgJiYgZi0+ZGVw dGggPT0gZGVwdGgpCj4gQEAgLTE5NzQsNyArMTk3NCw3IEBAIHVpbnQzMl90IGlndF9icHBfZGVw dGhfdG9fZHJtX2Zvcm1hdChpbnQgYnBwLAo+IGludCBkZXB0aCkKPiAgICovCj4gIHVpbnQzMl90 IGlndF9kcm1fZm9ybWF0X3RvX2JwcCh1aW50MzJfdCBkcm1fZm9ybWF0KQo+ICB7Cj4gLQlzdHJ1 Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmID0KPiBsb29rdXBfZHJtX2Zvcm1hdChkcm1fZm9ybWF0 KTsKPiArCWNvbnN0IHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmYgPQo+IGxvb2t1cF9kcm1f Zm9ybWF0KGRybV9mb3JtYXQpOwo+ICAKPiAgCWlndF9hc3NlcnRfZihmLCAiY2FuJ3QgZmluZCBh IGJwcCBmb3JtYXQgZm9yICUwOHggKCVzKVxuIiwKPiAgCQkgICAgIGRybV9mb3JtYXQsIGlndF9m b3JtYXRfc3RyKGRybV9mb3JtYXQpKTsKPiBAQCAtMTk5Miw3ICsxOTkyLDcgQEAgdWludDMyX3Qg aWd0X2RybV9mb3JtYXRfdG9fYnBwKHVpbnQzMl90Cj4gZHJtX2Zvcm1hdCkKPiAgICovCj4gIGNv bnN0IGNoYXIgKmlndF9mb3JtYXRfc3RyKHVpbnQzMl90IGRybV9mb3JtYXQpCj4gIHsKPiAtCXN0 cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmYgPQo+IGxvb2t1cF9kcm1fZm9ybWF0KGRybV9mb3Jt YXQpOwo+ICsJY29uc3Qgc3RydWN0IGZvcm1hdF9kZXNjX3N0cnVjdCAqZiA9Cj4gbG9va3VwX2Ry bV9mb3JtYXQoZHJtX2Zvcm1hdCk7Cj4gIAo+ICAJcmV0dXJuIGYgPyBmLT5uYW1lIDogImludmFs aWQiOwo+ICB9Cj4gQEAgLTIwMDYsNyArMjAwNiw3IEBAIGNvbnN0IGNoYXIgKmlndF9mb3JtYXRf c3RyKHVpbnQzMl90IGRybV9mb3JtYXQpCj4gICAqLwo+ICBib29sIGlndF9mYl9zdXBwb3J0ZWRf Zm9ybWF0KHVpbnQzMl90IGRybV9mb3JtYXQpCj4gIHsKPiAtCXN0cnVjdCBmb3JtYXRfZGVzY19z dHJ1Y3QgKmY7Cj4gKwljb25zdCBzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmOwo+ICAKPiAg CWZvcl9lYWNoX2Zvcm1hdChmKQo+ICAJCWlmIChmLT5kcm1faWQgPT0gZHJtX2Zvcm1hdCkKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWls aW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==