From: Luca Boccassi <bluca@debian.org>
To: Thomas Monjalon <thomas@monjalon.net>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] acl: fix invalid results for rule with zero priority
Date: Tue, 25 Sep 2018 13:22:47 +0100 [thread overview]
Message-ID: <1537878167.10481.46.camel@debian.org> (raw)
In-Reply-To: <1912621.YvyjYky8PI@xps>
On Sun, 2018-09-16 at 11:56 +0200, Thomas Monjalon wrote:
> 24/08/2018 18:47, Konstantin Ananyev:
> > If user specifies priority=0 for some of ACL rules
> > that can cause rte_acl_classify to return wrong results.
> > The reason is that priority zero is used internally for no-match
> > nodes.
> > See more details at: https://bugs.dpdk.org/show_bug.cgi?id=79.
> > The simplest way to overcome the issue is just not allow zero
> > to be a valid priority for the rule.
> >
> > Fixes: dc276b5780c2 ("acl: new library")
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
> Cc: stable@dpdk.org
>
> Applied with below title, thanks
> acl: forbid rule with priority zero
Hi,
This patch is marked for stable, but it changes an enum in a public
header so it looks like an ABI breakage? Have I got it wrong?
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2018-09-25 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 16:47 [PATCH] acl: fix invalid results for rule with zero priority Konstantin Ananyev
2018-09-16 9:56 ` Thomas Monjalon
2018-09-25 12:22 ` Luca Boccassi [this message]
2018-09-25 12:57 ` Thomas Monjalon
2018-09-25 14:34 ` Ananyev, Konstantin
2018-10-03 16:18 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537878167.10481.46.camel@debian.org \
--to=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.