From: Bart Van Assche <bvanassche@acm.org>
To: Johannes Thumshirn <jthumshirn@suse.de>, Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended
Date: Wed, 26 Sep 2018 11:24:55 -0700 [thread overview]
Message-ID: <1537986295.209118.0.camel@acm.org> (raw)
In-Reply-To: <20180926150634.GD13588@linux-x5ow.site>
On Wed, 2018-09-26 at 17:06 +0200, Johannes Thumshirn wrote:
> On Wed, Sep 26, 2018 at 04:57:32PM +0200, Christoph Hellwig wrote:
> > I don't think this actually works given that rpm_status only exists
> > if CONFIG_PM is set.
>
> I think it'll work as GCC does constant propagation. There are
> actually some places in the kernel that follow this pattern.
This is what gcc on my development system thinks about that proposal:
In file included from ./arch/x86/include/asm/bug.h:83:0,
from ./include/linux/bug.h:5,
from ./include/linux/thread_info.h:12,
from ./arch/x86/include/asm/preempt.h:7,
from ./include/linux/preempt.h:81,
from ./include/linux/spinlock.h:51,
from ./include/linux/seqlock.h:36,
from ./include/linux/time.h:6,
from ./include/linux/stat.h:19,
from ./include/linux/module.h:10,
from block/blk-core.c:15:
block/blk-core.c: In function ‘elv_next_request’:
block/blk-core.c:2795:44: error: ‘struct request_queue’ has no member named ‘rpm_status’; did you mean ‘stats’?
WARN_ON_ONCE(q->rpm_status == RPM_SUSPENDED);
^
./include/asm-generic/bug.h:69:25: note: in definition of macro ‘WARN_ON_ONCE’
int __ret_warn_on = !!(condition); \
^~~~~~~~~
scripts/Makefile.build:305: recipe for target 'block/blk-core.o' failed
Bart.
next prev parent reply other threads:[~2018-09-26 18:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 20:31 [PATCH v10 0/8] blk-mq: Implement runtime power management Bart Van Assche
2018-09-21 20:31 ` [PATCH v10 1/8] block: Move power management code into a new source file Bart Van Assche
2018-09-26 14:22 ` Christoph Hellwig
2018-09-21 20:31 ` [PATCH v10 2/8] block, scsi: Change the preempt-only flag into a counter Bart Van Assche
2018-09-26 1:33 ` Martin K. Petersen
2018-09-21 20:31 ` [PATCH v10 3/8] block: Split blk_pm_add_request() and blk_pm_put_request() Bart Van Assche
2018-09-26 14:23 ` Christoph Hellwig
2018-09-21 20:31 ` [PATCH v10 4/8] block: Schedule runtime resume earlier Bart Van Assche
2018-09-26 14:25 ` Christoph Hellwig
2018-09-21 20:31 ` [PATCH v10 5/8] percpu-refcount: Introduce percpu_ref_resurrect() Bart Van Assche
2018-09-24 18:01 ` Tejun Heo
2018-09-24 20:43 ` Bart Van Assche
2018-09-26 16:59 ` Tejun Heo
2018-09-26 18:48 ` Bart Van Assche
2018-09-21 20:31 ` [PATCH v10 6/8] block: Allow unfreezing of a queue while requests are in progress Bart Van Assche
2018-09-26 14:25 ` Christoph Hellwig
2018-09-21 20:31 ` [PATCH v10 7/8] block: Make blk_get_request() block for non-PM requests while suspended Bart Van Assche
2018-09-26 14:27 ` Christoph Hellwig
2018-09-26 14:43 ` Johannes Thumshirn
2018-09-26 14:57 ` Christoph Hellwig
2018-09-26 15:06 ` Johannes Thumshirn
2018-09-26 18:24 ` Bart Van Assche [this message]
2018-09-27 6:54 ` Johannes Thumshirn
2018-09-21 20:31 ` [PATCH v10 8/8] blk-mq: Enable support for runtime power management Bart Van Assche
2018-09-26 14:28 ` Christoph Hellwig
2018-09-22 2:32 ` [PATCH v10 0/8] blk-mq: Implement " Jens Axboe
2018-09-26 2:55 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537986295.209118.0.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.