From: Johannes Berg <johannes@sipsolutions.net>
To: Siva Rebbagondla <siva8118@gmail.com>
Cc: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>,
sushant kumar mishra <sushant2k1513@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
Linux Wireless <linux-wireless@vger.kernel.org>,
Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>,
Sushant Mishra <sushant.mishra@redpinesignals.com>
Subject: Re: [PATCH v3 1/2] mac80211: invoke sw_scan if hw_scan returns EPERM
Date: Fri, 28 Sep 2018 09:21:13 +0200 [thread overview]
Message-ID: <1538119273.14416.59.camel@sipsolutions.net> (raw)
In-Reply-To: <CANGSkXQ3Yo21vf+mqk+CpQ7z7rUtRi__eHoyFtbM3YBARuY8TQ@mail.gmail.com> (sfid-20180922_072928_899822_92639F6C)
Hi,
> Actually, we have missed this in code. Our module supports scanning on
> both bands at the same time.
Yeah, but we still have to support drivers that don't support this.
> Thanks for the info.
> And also we ran the scan on our dual band module by setting
> "SINGLE_SCAN_ON_ALL_BANDS" flag in
> driver and removing SCAN_HW_CANCELLED bit in mac80211 stack. We didn't
> see any issues in scan and
> as i mentioned earlier, I didn't observe "scan aborted".
> Can i resubmit patch with these changes?.
Were you able to try my patch instead? I tend to like the structure of
it better - i.e. how we fall back after cleaning up the state, rather
than directly in the middle.
Like I said above, I don't think we should take your patch - you've seen
a bug there, and if we just work around it by making your driver do
both-bands-at-once, we still have the bug...
johannes
prev parent reply other threads:[~2018-09-28 7:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 3:30 [PATCH v3 1/2] mac80211: invoke sw_scan if hw_scan returns EPERM Sushant Kumar Mishra
2018-08-02 3:30 ` [PATCH v3 2/2] rsi: add support for hardware scan offload Sushant Kumar Mishra
2018-08-14 11:33 ` [PATCH v3 1/2] mac80211: invoke sw_scan if hw_scan returns EPERM Johannes Berg
[not found] ` <5B83C2FE.90000@redpinesignals.com>
2018-08-29 7:24 ` Johannes Berg
2018-08-31 13:34 ` Siva Rebbagondla
[not found] ` <1535970059.3437.39.camel@sipsolutions.net>
[not found] ` <CANGSkXTPejV11TVpauXn+t6g+rUQ8cYik8KAz7W1P-2Y-8XebA@mail.gmail.com>
[not found] ` <CANGSkXR11ZxFoiZ7sbKTu8BnXSpTsiAhH=DOD=e9Zh8bquDC0A@mail.gmail.com>
2018-09-11 12:25 ` Johannes Berg
2018-09-11 13:20 ` Siva Rebbagondla
2018-09-22 5:29 ` Siva Rebbagondla
2018-09-28 7:21 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538119273.14416.59.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sanjay.konduri@redpinesignals.com \
--cc=siva.rebbagondla@redpinesignals.com \
--cc=siva8118@gmail.com \
--cc=sushant.mishra@redpinesignals.com \
--cc=sushant2k1513@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.