From mboxrd@z Thu Jan 1 00:00:00 1970 From: eugeniy.paltsev@synopsys.com (Eugeniy Paltsev) Date: Fri, 28 Sep 2018 14:32:01 +0000 Subject: [PATCH] DRM: VBLANK: provide valid timestamp for EVENT_FLIP In-Reply-To: <20180926163723.GW9144@intel.com> References: <20180926142535.17997-1-Eugeniy.Paltsev@synopsys.com> <20180926163723.GW9144@intel.com> List-ID: Message-ID: <1538145120.5186.6.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org On Wed, 2018-09-26@19:37 +0300, Ville Syrj?l? wrote: > On Wed, Sep 26, 2018@05:25:35PM +0300, Eugeniy Paltsev wrote: > > If driver/HW doesn't support vblank functionality (for example > > UDL driver, ARCPGU driver, ...) we always have vblank->time == 0. > > In result we always provide zero timestamp for > > DRM_EVENT_FLIP_COMPLETE. This breaks userspace apps (for example > > weston) which relies on timestamp value. > > > > Setup time to provide valid timestamp for DRM_EVENT_FLIP_COMPLETE > > event. > > > > Signed-off-by: Eugeniy Paltsev > > --- > > drivers/gpu/drm/drm_vblank.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c > > index 28cdcf76b6f9..0d19aca48782 100644 > > --- a/drivers/gpu/drm/drm_vblank.c > > +++ b/drivers/gpu/drm/drm_vblank.c > > @@ -911,6 +911,15 @@ void drm_crtc_send_vblank_event(struct drm_crtc *crtc, > > > > if (dev->num_crtcs > 0) { > > If those drivers don't support vblank stuff why are they calling > bldrm_vank_init() w/ num_crtcs > 0? If they didn't they'd take the > else branch which already does what you want. Hmm... As I can see UDL call drm_vblank_init() with num_crtcs = 1 but UDL HW doesn't support vblank at all. I guess I need to fix it. > > seq = drm_vblank_count_and_time(dev, pipe, &now); > > + > > + /* > > + * If driver/HW doesn't support vblank functionality we > > + * always have vblank->time == 0. Setup time to provide valid > > + * timestamp for DRM_EVENT_FLIP_COMPLETE event. > > + */ > > + if (!now && e->event.base.type == DRM_EVENT_FLIP_COMPLETE) > > + now = ktime_get(); > > + > > } else { > > seq = 0; > > > > -- > > 2.14.4 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel at lists.freedesktop.org > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_dri-2Ddevel&d=DwIDAw&c=DPL6_X_6JkXFx7AXWqB0tg&r=ZlJN1M > > riPUTkBKCrPSx67GmaplEUGcAEk9yPtCLdUXI&m=5bbb9SeVXTMPDa1bXQxqlBIOnSdKaKY5W0BkMCgwijE&s=50EhApCZAeMMDUEd6FVpXf5owd1Bi3vn5GaBt0KE2Cw&e= > > -- Eugeniy Paltsev From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniy Paltsev Subject: Re: [PATCH] DRM: VBLANK: provide valid timestamp for EVENT_FLIP Date: Fri, 28 Sep 2018 14:32:01 +0000 Message-ID: <1538145120.5186.6.camel@synopsys.com> References: <20180926142535.17997-1-Eugeniy.Paltsev@synopsys.com> <20180926163723.GW9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180926163723.GW9144@intel.com> Content-Language: en-US Content-ID: <43575F86C0A4944BAA17EC090EFB7CF6@internal.synopsys.com> Sender: linux-kernel-owner@vger.kernel.org To: "ville.syrjala@linux.intel.com" , "Eugeniy.Paltsev@synopsys.com" Cc: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "alexey.brodkin@synopsys.com" , "sean@poorly.run" , "airlied@linux.ie" , "linux-snps-arc@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyMDE4LTA5LTI2IGF0IDE5OjM3ICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 DQo+IE9uIFdlZCwgU2VwIDI2LCAyMDE4IGF0IDA1OjI1OjM1UE0gKzAzMDAsIEV1Z2VuaXkgUGFs dHNldiB3cm90ZToNCj4gPiBJZiBkcml2ZXIvSFcgZG9lc24ndCBzdXBwb3J0IHZibGFuayBmdW5j dGlvbmFsaXR5IChmb3IgZXhhbXBsZQ0KPiA+IFVETCBkcml2ZXIsIEFSQ1BHVSBkcml2ZXIsIC4u Likgd2UgYWx3YXlzIGhhdmUgdmJsYW5rLT50aW1lID09IDAuDQo+ID4gSW4gcmVzdWx0IHdlIGFs d2F5cyBwcm92aWRlIHplcm8gdGltZXN0YW1wIGZvcg0KPiA+IERSTV9FVkVOVF9GTElQX0NPTVBM RVRFLiBUaGlzIGJyZWFrcyB1c2Vyc3BhY2UgYXBwcyAoZm9yIGV4YW1wbGUNCj4gPiB3ZXN0b24p IHdoaWNoIHJlbGllcyBvbiB0aW1lc3RhbXAgdmFsdWUuDQo+ID4gDQo+ID4gU2V0dXAgdGltZSB0 byBwcm92aWRlIHZhbGlkIHRpbWVzdGFtcCBmb3IgRFJNX0VWRU5UX0ZMSVBfQ09NUExFVEUNCj4g PiBldmVudC4NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBFdWdlbml5IFBhbHRzZXYgPEV1Z2Vu aXkuUGFsdHNldkBzeW5vcHN5cy5jb20+DQo+ID4gLS0tDQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9k cm1fdmJsYW5rLmMgfCA5ICsrKysrKysrKw0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRp b25zKCspDQo+ID4gDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fdmJsYW5r LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3ZibGFuay5jDQo+ID4gaW5kZXggMjhjZGNmNzZiNmY5 Li4wZDE5YWNhNDg3ODIgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV92Ymxh bmsuYw0KPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fdmJsYW5rLmMNCj4gPiBAQCAtOTEx LDYgKzkxMSwxNSBAQCB2b2lkIGRybV9jcnRjX3NlbmRfdmJsYW5rX2V2ZW50KHN0cnVjdCBkcm1f Y3J0YyAqY3J0YywNCj4gPiAgDQo+ID4gIAlpZiAoZGV2LT5udW1fY3J0Y3MgPiAwKSB7DQo+IA0K PiBJZiB0aG9zZSBkcml2ZXJzIGRvbid0IHN1cHBvcnQgdmJsYW5rIHN0dWZmIHdoeSBhcmUgdGhl eSBjYWxsaW5nDQo+IGJsZHJtX3ZhbmtfaW5pdCgpIHcvIG51bV9jcnRjcyA+IDA/IElmIHRoZXkg ZGlkbid0IHRoZXknZCB0YWtlIHRoZQ0KPiBlbHNlIGJyYW5jaCB3aGljaCBhbHJlYWR5IGRvZXMg d2hhdCB5b3Ugd2FudC4NCg0KSG1tLi4uDQpBcyBJIGNhbiBzZWUgVURMIGNhbGwgZHJtX3ZibGFu a19pbml0KCkgd2l0aCBudW1fY3J0Y3MgPSAxIGJ1dCBVREwgSFcNCmRvZXNuJ3Qgc3VwcG9ydCB2 YmxhbmsgYXQgYWxsLg0KSSBndWVzcyBJIG5lZWQgdG8gZml4IGl0Lg0KDQo+ID4gIAkJc2VxID0g ZHJtX3ZibGFua19jb3VudF9hbmRfdGltZShkZXYsIHBpcGUsICZub3cpOw0KPiA+ICsNCj4gPiAr CQkvKg0KPiA+ICsJCSAqIElmIGRyaXZlci9IVyBkb2Vzbid0IHN1cHBvcnQgdmJsYW5rIGZ1bmN0 aW9uYWxpdHkgd2UNCj4gPiArCQkgKiBhbHdheXMgaGF2ZSB2YmxhbmstPnRpbWUgPT0gMC4gU2V0 dXAgdGltZSB0byBwcm92aWRlIHZhbGlkDQo+ID4gKwkJICogdGltZXN0YW1wIGZvciBEUk1fRVZF TlRfRkxJUF9DT01QTEVURSBldmVudC4NCj4gPiArCQkgKi8NCj4gPiArCQlpZiAoIW5vdyAmJiBl LT5ldmVudC5iYXNlLnR5cGUgPT0gRFJNX0VWRU5UX0ZMSVBfQ09NUExFVEUpDQo+ID4gKwkJCW5v dyA9IGt0aW1lX2dldCgpOw0KPiA+ICsNCj4gPiAgCX0gZWxzZSB7DQo+ID4gIAkJc2VxID0gMDsN Cj4gPiAgDQo+ID4gLS0gDQo+ID4gMi4xNC40DQo+ID4gDQo+ID4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCj4gPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0 DQo+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZw0KPiA+IGh0dHBzOi8vdXJsZGVm ZW5zZS5wcm9vZnBvaW50LmNvbS92Mi91cmw/dT1odHRwcy0zQV9fbGlzdHMuZnJlZWRlc2t0b3Au b3JnX21haWxtYW5fbGlzdGluZm9fZHJpLTJEZGV2ZWwmZD1Ed0lEQXcmYz1EUEw2X1hfNkprWEZ4 N0FYV3FCMHRnJnI9WmxKTjFNDQo+ID4gcmlQVVRrQktDclBTeDY3R21hcGxFVUdjQUVrOXlQdENM ZFVYSSZtPTViYmI5U2VWWFRNUERhMWJYUXhxbEJJT25TZEthS1k1VzBCa01DZ3dpakUmcz01MEVo QXBDWkFlTU1EVUVkNkZWcFhmNW93ZDFCaTN2bjVHYUJ0MEtFMkN3JmU9DQo+IA0KPiANCi0tIA0K IEV1Z2VuaXkgUGFsdHNldg==