diff for duplicates of <1539033512.15382.133.camel@linux.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 5b0d526..949321c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -33,7 +33,7 @@ On Mon, 2018-10-08 at 10:30 -0500, Goldwyn Rodrigues wrote: > > > > > + if (IS_ERR(f)) > > > > > + return PTR_ERR(f); > > -> > It's late in the release cycle to be making this change. Would it +> > It's late in the release cycle to be making this change. Would it > > make sense for now to fallback to modifying the original file > > descriptor on failure and emit a message? > @@ -43,8 +43,8 @@ On Mon, 2018-10-08 at 10:30 -0500, Goldwyn Rodrigues wrote: > original file->f_flags on failure. Just not sure about the error > message. -The message should be an indication that the dentry_open() failed. So -it needs to be in ima_calc_file_hash. Perhaps use either +The message should be an indication that the dentry_open() failed. So +it needs to be in ima_calc_file_hash. Perhaps use either pr_info_ratelimited or even pr_info_once() to limit the number of messages. diff --git a/a/content_digest b/N1/content_digest index c397b91..90179f9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -49,7 +49,7 @@ "> > > > > +\t\tif (IS_ERR(f))\n" "> > > > > +\t\t\treturn PTR_ERR(f);\n" "> > \n" - "> > It's late in the release cycle to be making this change. Would it\n" + "> > It's late in the release cycle to be making this change. \302\240Would it\n" "> > make sense for now to fallback to modifying the original file\n" "> > descriptor on failure and emit a message?\n" "> \n" @@ -59,8 +59,8 @@ "> original file->f_flags on failure. Just not sure about the error\n" "> message.\n" "\n" - "The message should be an indication that the dentry_open() failed. So\n" - "it needs to be in ima_calc_file_hash. Perhaps use either\n" + "The message should be an indication that the dentry_open() failed. \302\240So\n" + "it needs to be in ima_calc_file_hash. \302\240Perhaps use either\n" "pr_info_ratelimited or even pr_info_once() to limit the number of\n" "messages.\n" "\n" @@ -73,4 +73,4 @@ "\n" Mimi -73439037c57103e429d2a3796806628aacd0f57285ab0c167f519e9d5252b176 +2fd77d36d81c9bca39328420189dea55f219a9f8637cfdffec5b22292a123bfe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.