All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lothar Felten <lothar.felten@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/dtc: fix include guards for older kernel/u-boot
Date: Tue, 09 Oct 2018 10:07:34 +0200	[thread overview]
Message-ID: <1539072454.1603.11.camel@gmail.com> (raw)
In-Reply-To: <20181008180230.53ab7972@windsurf>

Hello,

On Mon, 2018-10-08 at 18:02 +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon,??8 Oct 2018 13:51:46 +0200, Lothar Felten wrote:
> > Patch dtc to accept libfdt include guards with and without leading
> > underscore.
> > A compiler warning is added to notify the user.
> > 
> > Signed-off-by: Lothar Felten <lothar.felten@gmail.com>
> 
> So I guess this would fix the problem when host-dtc is built before
> some old Linux/U-Boot version.
> 
> However, I suppose it doesn't fix the problem when you have a
> recent version of libfdt installed on your system (through your
> distribution), that doesn't play well with those older Linux/U-Boot
> versions. Correct ?

Maybe. I have no libfdt headers on my host. This patch fixes the
failures caused by host-dtc (ver 1.4.7) and older u-boot or kernel
versions.
Building an older kernel without libfdt headers on the host works (it
uses the libfdt from the kernel) as long as host-dtc is not selected.

Just creating a /usr/include/[libfdt/]libfdt_env.h with a single #error
does not  prevent a u-boot-2016.09.01 build, so I suppose the include
paths are ok.

I expect this to be a temporary fix until all targets use a recent u-
boot and kernel.


> Thomas

Lothar

  parent reply	other threads:[~2018-10-09  8:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 11:51 [Buildroot] [PATCH 1/1] package/dtc: fix include guards for older kernel/u-boot Lothar Felten
2018-10-08 13:10 ` Matthew Weber
2018-10-08 14:35   ` Lothar Felten
2018-10-08 15:54   ` Arnout Vandecappelle
2018-10-08 15:58 ` Yann E. MORIN
2018-10-08 16:02 ` Thomas Petazzoni
2018-10-08 16:32   ` Yann E. MORIN
2018-10-08 19:21     ` Arnout Vandecappelle
2018-10-08 19:31       ` Yann E. MORIN
2018-10-09  8:22         ` Arnout Vandecappelle
2018-10-09  8:07   ` Lothar Felten [this message]
2018-10-20 11:37 ` Arnout Vandecappelle
2018-10-24 12:17 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539072454.1603.11.camel@gmail.com \
    --to=lothar.felten@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.