All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: linux-block@vger.kernel.org, axboe@kernel.dk
Cc: linux-m68k@vger.kernel.org, geert@linux-m68k.org
Subject: [PATCH v7 0/2] Amiga RDB partition support fixes
Date: Mon, 15 Oct 2018 15:32:25 +1300	[thread overview]
Message-ID: <1539570747-19906-1-git-send-email-schmitzmic@gmail.com> (raw)

(hopefully) final version of the Amiga RDB partition table patch follows.
 
I've split off the part fixing the incorrect use of signed int
for partition start address and size as separate patch. It does fix the
bug that Martin Steigerwald reported six years ago for a 2 TB disk.
I have tested this patch with the identical RDB partition data that
Martin saw the bug with. I have incorporated Andreas' feedback on proper
use of casts to avoid integer overflow in this version.

The simple fix still leaves ample room for overflows in calculating start
address and size of a RDB partition, though such overflows should only be 
seen in rather unusual cases. To address these potential overflows, checks
are added in the second patch of this series. Comments by Geert have been   
addressed in full. 

Both patches now reviewed by Geert - Reviewed-by tags added. 

Cheers,

        Michael

             reply	other threads:[~2018-10-15  2:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-15  2:32 Michael Schmitz [this message]
2018-10-15  2:32 ` [PATCH v7 1/2] block: fix signed int overflow in Amiga partition support Michael Schmitz
2018-10-15  2:32 ` [PATCH v7 2/2] block: add overflow checks for " Michael Schmitz
2022-07-25 12:36   ` Martin Steigerwald
2022-07-25 23:03     ` Jens Axboe
2022-07-26  1:53       ` Michael Schmitz
2022-07-26  3:40         ` Jens Axboe
2022-07-26  3:58           ` Michael Schmitz
2022-08-21 20:59             ` Martin Steigerwald
2022-08-22  5:46               ` Michael Schmitz
2022-08-22 13:57                 ` Jens Axboe
2022-08-22 20:39                   ` Michael Schmitz
2022-08-22 20:41                     ` Jens Axboe
2022-08-22 20:56                       ` Michael Schmitz
2023-06-13  7:25                         ` Martin Steigerwald
2023-06-13  8:18                           ` Michael Schmitz
2023-06-13 10:57                             ` Martin Steigerwald
2023-06-13 22:11                               ` Michael Schmitz
2023-06-14  0:07                                 ` Finn Thain
2023-06-14  1:20                                   ` Michael Schmitz
2023-06-14  7:19                                 ` Martin Steigerwald
2023-06-14  8:43                                   ` Michael Schmitz
     [not found]                                     ` <05bd2c1b-a985-d935-a955-06a048d54c18@earthlink.net>
2023-06-14 19:46                                       ` Michael Schmitz
2023-06-15  0:13                                     ` Finn Thain
2023-06-15  1:06                                       ` Michael Schmitz
2023-06-15  4:28                                       ` Christoph Hellwig
2019-01-31  0:40 ` [PATCH v7 0/2] Amiga RDB partition support fixes Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539570747-19906-1-git-send-email-schmitzmic@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=geert@linux-m68k.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.