From mboxrd@z Thu Jan 1 00:00:00 1970 From: eugeniy.paltsev@synopsys.com (Eugeniy Paltsev) Date: Tue, 23 Oct 2018 11:01:14 +0000 Subject: [PATCH] DRM: UDL: get rid of useless vblank initialization In-Reply-To: <20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com> References: <20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com> List-ID: Message-ID: <1540292472.19916.13.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi David, Maybe you have any comments or remarks about this patch? And if you don't could you please apply it. Thanks! On Fri, 2018-09-28@17:41 +0300, Eugeniy Paltsev wrote: > UDL doesn't support vblank functionality so we don't need to > initialize vblank here (we are able to send page flip > completion events even without vblank initialization) > > Moreover current drm_vblank_init call with num_crtcs > 0 causes > sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every > time. This breaks userspace apps (for example weston) which > relies on timestamp value. > > Reviewed-by: Daniel Vetter > Cc: stable at vger.kernel.org > Signed-off-by: Eugeniy Paltsev > --- > drivers/gpu/drm/udl/udl_main.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c > index f455f095a146..1b014d92855b 100644 > --- a/drivers/gpu/drm/udl/udl_main.c > +++ b/drivers/gpu/drm/udl/udl_main.c > @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags) > if (ret) > goto err; > > - ret = drm_vblank_init(dev, 1); > - if (ret) > - goto err_fb; > - > drm_kms_helper_poll_init(dev); > > return 0; > -err_fb: > - udl_fbdev_cleanup(dev); > + > err: > if (udl->urbs.count) > udl_free_urb_list(dev); -- Eugeniy Paltsev From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniy Paltsev Subject: Re: [PATCH] DRM: UDL: get rid of useless vblank initialization Date: Tue, 23 Oct 2018 11:01:14 +0000 Message-ID: <1540292472.19916.13.camel@synopsys.com> References: <20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com> Content-Language: en-US Content-ID: Sender: stable-owner@vger.kernel.org To: "dri-devel@lists.freedesktop.org" , "airlied@linux.ie" Cc: "linux-kernel@vger.kernel.org" , "daniel.vetter@ffwll.ch" , "linux-snps-arc@lists.infradead.org" , "stable@vger.kernel.org" , "marcheu@chromium.org" , Alexey Brodkin , "maarten.lankhorst@linux.intel.com" , "gustavo@padovan.org" , "sean@poorly.run" List-Id: dri-devel@lists.freedesktop.org SGkgRGF2aWQsDQoNCk1heWJlIHlvdSBoYXZlIGFueSBjb21tZW50cyBvciByZW1hcmtzIGFib3V0 IHRoaXMgcGF0Y2g/DQpBbmQgaWYgeW91IGRvbid0IGNvdWxkIHlvdSBwbGVhc2UgYXBwbHkgaXQu IFRoYW5rcyENCg0KT24gRnJpLCAyMDE4LTA5LTI4IGF0IDE3OjQxICswMzAwLCBFdWdlbml5IFBh bHRzZXYgd3JvdGU6DQo+IFVETCBkb2Vzbid0IHN1cHBvcnQgdmJsYW5rIGZ1bmN0aW9uYWxpdHkg c28gd2UgZG9uJ3QgbmVlZCB0bw0KPiBpbml0aWFsaXplIHZibGFuayBoZXJlICh3ZSBhcmUgYWJs ZSB0byBzZW5kIHBhZ2UgZmxpcA0KPiBjb21wbGV0aW9uIGV2ZW50cyBldmVuIHdpdGhvdXQgdmJs YW5rIGluaXRpYWxpemF0aW9uKQ0KPiANCj4gTW9yZW92ZXIgY3VycmVudCBkcm1fdmJsYW5rX2lu aXQgY2FsbCB3aXRoIG51bV9jcnRjcyA+IDAgY2F1c2VzDQo+IHNlbmRpbmcgRFJNX0VWRU5UX0ZM SVBfQ09NUExFVEUgZXZlbnQgd2l0aCB6ZXJvIHRpbWVzdGFtcCBldmVyeQ0KPiB0aW1lLiBUaGlz IGJyZWFrcyB1c2Vyc3BhY2UgYXBwcyAoZm9yIGV4YW1wbGUgd2VzdG9uKSB3aGljaA0KPiByZWxp ZXMgb24gdGltZXN0YW1wIHZhbHVlLg0KPiANCj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIg PGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+DQo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnDQo+ IFNpZ25lZC1vZmYtYnk6IEV1Z2VuaXkgUGFsdHNldiA8RXVnZW5peS5QYWx0c2V2QHN5bm9wc3lz LmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9tYWluLmMgfCA3ICstLS0t LS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgNiBkZWxldGlvbnMoLSkNCj4g DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9tYWluLmMgYi9kcml2ZXJz L2dwdS9kcm0vdWRsL3VkbF9tYWluLmMNCj4gaW5kZXggZjQ1NWYwOTVhMTQ2Li4xYjAxNGQ5Mjg1 NWIgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS91ZGwvdWRsX21haW4uYw0KPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9tYWluLmMNCj4gQEAgLTM1MCwxNSArMzUwLDEwIEBA IGludCB1ZGxfZHJpdmVyX2xvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgbG9u ZyBmbGFncykNCj4gIAlpZiAocmV0KQ0KPiAgCQlnb3RvIGVycjsNCj4gIA0KPiAtCXJldCA9IGRy bV92YmxhbmtfaW5pdChkZXYsIDEpOw0KPiAtCWlmIChyZXQpDQo+IC0JCWdvdG8gZXJyX2ZiOw0K PiAtDQo+ICAJZHJtX2ttc19oZWxwZXJfcG9sbF9pbml0KGRldik7DQo+ICANCj4gIAlyZXR1cm4g MDsNCj4gLWVycl9mYjoNCj4gLQl1ZGxfZmJkZXZfY2xlYW51cChkZXYpOw0KPiArDQo+ICBlcnI6 DQo+ICAJaWYgKHVkbC0+dXJicy5jb3VudCkNCj4gIAkJdWRsX2ZyZWVfdXJiX2xpc3QoZGV2KTsN Ci0tIA0KIEV1Z2VuaXkgUGFsdHNldg==