From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: keyrings@vger.kernel.org
Subject: Re: [PATCH v2 4/4] sign-file: add explicit engine specification
Date: Tue, 23 Oct 2018 11:10:57 +0000 [thread overview]
Message-ID: <1540293057.2881.2.camel@HansenPartnership.com> (raw)
In-Reply-To: <1540205281.2815.12.camel@HansenPartnership.com>
On Mon, 2018-10-22 at 12:38 +0100, David Woodhouse wrote:
> On Mon, 2018-10-22 at 11:48 +0100, James Bottomley wrote:
> > This commit adds an optional -e <engine> argument to sign
> > file. Now that we have the explicit engine addition, the original
> > pkcs11 token implementation can also be merged into this code
> > (using UI methods for getting the key instead of the engine control
> > command). To keep the code functioning the same way (no need to
> > specify the pkcs11 engine if the key file begins pkcs11:) an
> > explicit check will set the engine to pkcs11 if a pkcs11 key
> > specifier is detected.
> >
> > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.c
> > om>
>
> Acked-if-you-tested-it-with-PKCS#11-by: David Woodhouse <dwmw@amazon.
> co.uk>
It was a right royal pain, but I have tested it with softhsm+p11lib
engine and it all (amazingly) seems to work with correct pkcs11 URLs
... just don't ask me to do it again.
James
next prev parent reply other threads:[~2018-10-23 11:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 10:48 [PATCH v2 4/4] sign-file: add explicit engine specification James Bottomley
2018-10-22 11:38 ` David Woodhouse
2018-10-22 14:02 ` Mark J Cox
2018-10-23 11:10 ` James Bottomley [this message]
2018-10-23 11:37 ` David Woodhouse
2018-10-23 11:42 ` James Bottomley
2018-10-23 11:56 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540293057.2881.2.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=keyrings@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.