Re: [PATCH RESEND qemu-xen-traditional] xen/pt: allow QEMU to request MSI unmasking at bind time - Paraschiv, Andra-Irina

From: "Paraschiv, Andra-Irina" <andraprs@amazon.com>
To: "Pasi Kärkkäinen" <pasik@iki.fi>, "Ian Jackson" <ian.jackson@citrix.com>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Woodhouse, David" <dwmw@amazon.co.uk>,
	"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: Re: [PATCH RESEND qemu-xen-traditional] xen/pt: allow QEMU to request MSI unmasking at bind time
Date: Mon, 29 Oct 2018 20:55:09 +0000	[thread overview]
Message-ID: <1540846506816.50601@amazon.com> (raw)
In-Reply-To: <20181029145815.GB31019@reaktio.net>

On Mon, Oct 29, 2018 at 04:58:22PM +0200, Pasi Kärkkäinen wrote:
> Hi,
>
> On Wed, Oct 24, 2018 at 04:20:35PM +0100, Ian Jackson wrote:
> > Andra Paraschiv writes ("[PATCH RESEND qemu-xen-traditional] xen/pt: allow QEMU to request MSI unmasking at bind time"):
> > > When a MSI interrupt is bound to a guest using
> > > xc_domain_update_msi_irq (XEN_DOMCTL_bind_pt_irq) the interrupt is
> > > left masked by default.
> >
> > Applied, and pushed the corresponding update to QEMU_TAG in
> > qemu-xen-unstable.
> >
> > Does this patch need to be backported to earlier Xen releases ?  It
> > wasn't clear to me whether there is new Xen code in this area without
> > which the problem (which the patch solves) does not arise; or whether,
> > conversely, simply running a new guest is sufficient.
> >
> 
> Good question. In the earlier thread about this patch it was mentioned
> the bug happens with latest stable version of Xen, which sounds like
> this patch should be backported to stable Xen versions. Is that correct?

Replied later than expected, but I'm back now.

Ian, Pasi,

Right. We have this mail thread where the issue was originally reported:
https://lists.xenproject.org/archives/html/xen-devel/2017-07/msg00915.html

And the follow-up with the patches for Xen and QEMU (not traditional):
https://lists.xenproject.org/archives/html/xen-devel/2018-05/msg01238.html

"Hm, I think I might have fixed this issue, see:

https://git.qemu.org/?p=qemu.git;a=commit;h=a8036336609d2e184fc3543a4c439c0ba7d7f3a2

And the Xen side:

http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=69d99d1b223fc5082400374698ddd7486e5ea953"

The Xen patch above is present in the tree from 4.10.0-rc1 tag forward.

Thanks for feedback. Anything I can help further, we can discuss about it.

Andra

> Thanks,
> 
> -- Pasi
>
> > Regards,
> > Ian.
> >

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel