From: Bart Van Assche <bvanassche@acm.org>
To: Theodore Ts'o <tytso@mit.edu>, linux-block@vger.kernel.org
Subject: Re: [PATCH blktests -v2] Fix build failure for discontiguous-io on 32-bit platforms
Date: Tue, 30 Oct 2018 08:02:55 -0700 [thread overview]
Message-ID: <1540911775.196084.110.camel@acm.org> (raw)
In-Reply-To: <20181030143649.28246-1-tytso@mit.edu>
On Tue, 2018-10-30 at 10:36 -0400, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> src/discontiguous-io.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/discontiguous-io.cpp b/src/discontiguous-io.cpp
> index 5e0ee0f..f51a305 100644
> --- a/src/discontiguous-io.cpp
> +++ b/src/discontiguous-io.cpp
> @@ -251,7 +251,7 @@ int main(int argc, char **argv)
> const char *dev;
> int c;
> std::vector<uint8_t> buf;
> - size_t len = 512;
> + unsigned long len = 512;
>
> while ((c = getopt(argc, argv, "hl:o:sw")) != EOF) {
> switch (c) {
Details about how the build fails on 32-bit systems would have been welcome
in the commit message. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2018-10-30 23:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 14:36 [PATCH blktests -v2] Fix build failure for discontiguous-io on 32-bit platforms Theodore Ts'o
2018-10-30 15:02 ` Bart Van Assche [this message]
2018-10-30 16:02 ` Theodore Y. Ts'o
2018-10-30 17:19 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540911775.196084.110.camel@acm.org \
--to=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.