All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leslie Monis <lesliemonis@gmail.com>
To: jhs@mojatatu.com
Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in,
	dhavaljkhandla26@gmail.com, hrishihiraskar@gmail.com,
	bmanish15597@gmail.com, sdp.sachin@gmail.com
Subject: [PATCH net-next 5/8] net: sched: pie: add more conditions to auto-tune alpha and beta
Date: Wed, 31 Oct 2018 21:49:29 +0530	[thread overview]
Message-ID: <1541002772-28040-6-git-send-email-lesliemonis@gmail.com> (raw)
In-Reply-To: <1541002772-28040-1-git-send-email-lesliemonis@gmail.com>

From: "Mohit P. Tahiliani" <tahiliani@nitk.edu.in>

The update in drop probability depends on the parameters
alpha and beta, which in turn reflect the current congestion
level. However, the previous if-else cases were recommended
when the supported bandwidth was up to 12 Mbps but, current
data links support a much higher bandwidth, and the
requirement for more bandwidth is in never-ending demand.
Hence, RFC 8033 suggests using more if-else cases for better
fine-tuning of parameters alpha and beta in order to control
the congestion as much as possible.

Signed-off-by: Mohit P. Tahiliani <tahiliani@nitk.edu.in>
Signed-off-by: Dhaval Khandla <dhavaljkhandla26@gmail.com>
Signed-off-by: Hrishikesh Hiraskar <hrishihiraskar@gmail.com>
Signed-off-by: Manish Kumar B <bmanish15597@gmail.com>
Signed-off-by: Sachin D. Patil <sdp.sachin@gmail.com>
Signed-off-by: Leslie Monis <lesliemonis@gmail.com>
---
 net/sched/sch_pie.c | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
index f4e189a..c84e91e 100644
--- a/net/sched/sch_pie.c
+++ b/net/sched/sch_pie.c
@@ -343,10 +343,30 @@ static void calculate_probability(struct Qdisc *sch)
 	 * appropriately 2) scaling down by 16 to come to 0-2 range.
 	 * Please see paper for details.
 	 *
-	 * We scale alpha and beta differently depending on whether we are in
-	 * light, medium or high dropping mode.
+	 * We scale alpha and beta differently depending on how heavy the
+	 * congestion is.
 	 */
-	if (q->vars.prob < MAX_PROB / 100) {
+	if (q->vars.prob < MAX_PROB / 1000000) {
+		alpha =
+		    (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 15;
+		beta =
+		    (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 15;
+	} else if (q->vars.prob < MAX_PROB / 100000) {
+		alpha =
+		    (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 13;
+		beta =
+		    (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 13;
+	} else if (q->vars.prob < MAX_PROB / 10000) {
+		alpha =
+		    (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 11;
+		beta =
+		    (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 11;
+	} else if (q->vars.prob < MAX_PROB / 1000) {
+		alpha =
+		    (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 9;
+		beta =
+		    (q->params.beta * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 9;
+	} else if (q->vars.prob < MAX_PROB / 100) {
 		alpha =
 		    (q->params.alpha * (MAX_PROB / PSCHED_TICKS_PER_SEC)) >> 7;
 		beta =
-- 
2.7.4

  parent reply	other threads:[~2018-11-01  1:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 16:19 [PATCH net-next 0/8] net: sched: pie: align PIE implementation with RFC 8033 Leslie Monis
2018-10-31 16:19 ` [PATCH net-next 1/8] net: sched: pie: change value of QUEUE_THRESHOLD Leslie Monis
2018-10-31 16:19 ` [PATCH net-next 2/8] net: sched: pie: change default value of pie_params->target Leslie Monis
2018-10-31 16:19 ` [PATCH net-next 3/8] net: sched: pie: change default value of pie_params->tupdate Leslie Monis
2018-10-31 16:19 ` [PATCH net-next 4/8] net: sched: pie: change initial value of pie_vars->burst_time Leslie Monis
2018-10-31 16:19 ` Leslie Monis [this message]
2018-10-31 16:40   ` [PATCH net-next 5/8] net: sched: pie: add more conditions to auto-tune alpha and beta Stephen Hemminger
2018-10-31 16:19 ` [PATCH net-next 6/8] net: sched: pie: add mechanism to set PIE active/inactive Leslie Monis
2018-10-31 16:41   ` Stephen Hemminger
2018-10-31 16:19 ` [PATCH net-next 7/8] net: sched: pie: add derandomization mechanism Leslie Monis
2018-10-31 16:38   ` Stephen Hemminger
2018-10-31 16:19 ` [PATCH net-next 8/8] net: sched: pie: update references Leslie Monis
2018-10-31 16:36 ` [PATCH net-next 0/8] net: sched: pie: align PIE implementation with RFC 8033 Stephen Hemminger
2018-10-31 17:43 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541002772-28040-6-git-send-email-lesliemonis@gmail.com \
    --to=lesliemonis@gmail.com \
    --cc=bmanish15597@gmail.com \
    --cc=dhavaljkhandla26@gmail.com \
    --cc=hrishihiraskar@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=sdp.sachin@gmail.com \
    --cc=tahiliani@nitk.edu.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.