All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Belal, Awais" <Awais_Belal@mentor.com>
To: "bitbake-devel@lists.openembedded.org"
	<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] bitbake: toaster: allow OE_ROOT to be	provided through environment
Date: Thu, 1 Nov 2018 13:36:43 +0000	[thread overview]
Message-ID: <1541079403214.48441@mentor.com> (raw)
In-Reply-To: <1541079270-28297-1-git-send-email-awais_belal@mentor.com>

This should be applied to master as well as sumo.

BR,
Awais

________________________________________
From: bitbake-devel-bounces@lists.openembedded.org <bitbake-devel-bounces@lists.openembedded.org> on behalf of Belal, Awais
Sent: Thursday, November 1, 2018 6:34 PM
To: bitbake-devel@lists.openembedded.org
Subject: [bitbake-devel] [PATCH] bitbake: toaster: allow OE_ROOT to be  provided through environment

Updates for YOCTO #12891 allowed a user to have a directory
structure different to that of yocto (bitbake isn't inside
oe-core) whereas the definition of OE_ROOT in the main toaster
binary still assumes the same while checking for .templateconf
and hence we see an error on the cmdline in such cases:
bash: <repo-path>/bitbake/bin/../../.templateconf: No such file or directory
The change here now allows the user to provide OE_ROOT through
the environment in such cases and otherwise defaults to the older
mechanism to fix this issue.

Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
 bin/toaster | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/toaster b/bin/toaster
index 9fffbc6..4e227cc 100755
--- a/bin/toaster
+++ b/bin/toaster
@@ -161,7 +161,7 @@ fi

 export BBBASEDIR=`dirname $TOASTER`/..
 MANAGE="python3 $BBBASEDIR/lib/toaster/manage.py"
-OE_ROOT=`dirname $TOASTER`/../..
+OE_ROOT=${OE_ROOT:-`dirname $TOASTER`/../..}

 # this is the configuraton file we are using for toaster
 # we are using the same logic that oe-setup-builddir uses
--
2.7.4

--
_______________________________________________
bitbake-devel mailing list
bitbake-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/bitbake-devel


  reply	other threads:[~2018-11-01 13:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 13:34 [PATCH] bitbake: toaster: allow OE_ROOT to be provided through environment Awais Belal
2018-11-01 13:36 ` Belal, Awais [this message]
2018-11-01 18:07 ` Reyna, David
  -- strict thread matches above, loose matches on Subject: below --
2018-11-02  8:49 Peter Kjellerstedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541079403214.48441@mentor.com \
    --to=awais_belal@mentor.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.