From: osalvador <osalvador@suse.de>
To: Michal Hocko <mhocko@kernel.org>, Balbir Singh <bsingharora@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm, memory_hotplug: check zone_movable in has_unmovable_pages
Date: Wed, 07 Nov 2018 08:55:26 +0100 [thread overview]
Message-ID: <1541577326.3089.2.camel@suse.de> (raw)
In-Reply-To: <20181107073548.GU27423@dhcp22.suse.cz>
On Wed, 2018-11-07 at 08:35 +0100, Michal Hocko wrote:
> On Wed 07-11-18 07:35:18, Balbir Singh wrote:
> > The check seems to be quite aggressive and in a loop that iterates
> > pages, but has nothing to do with the page, did you mean to make
> > the check
> >
> > zone_idx(page_zone(page)) == ZONE_MOVABLE
>
> Does it make any difference? Can we actually encounter a page from a
> different zone here?
AFAIK, test_pages_in_a_zone() called from offline_pages() should ensure
that the range belongs to a unique zone, so we should not encounter
pages from other zones there, right?
---
Oscar
Suse L3
next prev parent reply other threads:[~2018-11-07 7:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 9:55 [PATCH] mm, memory_hotplug: check zone_movable in has_unmovable_pages Michal Hocko
2018-11-06 9:55 ` Michal Hocko
2018-11-06 11:00 ` osalvador
2018-11-06 20:35 ` Balbir Singh
2018-11-07 7:35 ` Michal Hocko
2018-11-07 7:40 ` Michal Hocko
2018-11-07 7:55 ` osalvador [this message]
2018-11-07 8:14 ` Michal Hocko
2018-11-07 12:53 ` Balbir Singh
2018-11-07 13:06 ` Michal Hocko
2018-11-09 10:45 ` Balbir Singh
2018-11-15 3:13 ` Baoquan He
2018-11-15 3:18 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541577326.3089.2.camel@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bsingharora@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.