From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] blk-mq: provide a helper to check if a queue is busy
Date: Thu, 08 Nov 2018 08:30:26 -0800 [thread overview]
Message-ID: <1541694626.196084.220.camel@acm.org> (raw)
In-Reply-To: <20181108160609.27568-4-axboe@kernel.dk>
On Thu, 2018-11-08 at 09:06 -0700, Jens Axboe wrote:
> +static bool blk_mq_check_busy(struct blk_mq_hw_ctx *hctx, struct request *rq,
> + void *priv, bool reserved)
> +{
> + /*
> + * If we find a request, we know the queue is busy. Return false
> + * to stop the iteration.
> + */
> + if (rq->q == hctx->queue) {
> + bool *busy = (bool *) priv;
I think the "(bool *)" cast can be left out. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2018-11-08 16:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 16:06 [PATCHSET v2 0/2] Add queue_is_busy helper Jens Axboe
2018-11-08 16:06 ` [PATCH] blk-mq: provide a helper to check if a queue is busy Jens Axboe
2018-11-08 16:06 ` [PATCH 1/2] blk-mq-tag: change busy_iter_fn to return whether to continue or not Jens Axboe
2018-11-08 16:28 ` Bart Van Assche
2018-11-08 16:31 ` Jens Axboe
2018-11-08 17:35 ` Bart Van Assche
2018-11-08 17:47 ` Jens Axboe
2018-11-08 17:50 ` Jens Axboe
2018-11-08 18:04 ` Bart Van Assche
2018-11-08 16:06 ` [PATCH 2/2] blk-mq: provide a helper to check if a queue is busy Jens Axboe
2018-11-08 16:30 ` Bart Van Assche [this message]
2018-11-08 16:32 ` Jens Axboe
2018-11-09 1:53 ` [PATCHSET v2 0/2] Add queue_is_busy helper jianchao.wang
2018-11-09 2:08 ` jianchao.wang
-- strict thread matches above, loose matches on Subject: below --
2018-11-08 15:42 [PATCHSET " Jens Axboe
2018-11-08 15:42 ` [PATCH 2/2] blk-mq: provide a helper to check if a queue is busy Jens Axboe
2018-11-08 15:49 ` Mike Snitzer
2018-11-08 15:54 ` Laurence Oberman
2018-11-08 15:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541694626.196084.220.camel@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.