diff for duplicates of <1541695681.2091.10.camel@analog.com> diff --git a/a/1.txt b/N1/1.txt index fb2cc75..0c6458c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,56 +1,94 @@ -T24gSm8sIDIwMTgtMTEtMDggYXQgMTA6MzQgLTA2MDAsIFJvYiBIZXJyaW5nIHdyb3RlOg0KPiBP -biBUaHUsIE5vdiA4LCAyMDE4IGF0IDk6MDIgQU0gUG9wYSwgU3RlZmFuIFNlcmJhbg0KPiA8U3Rl -ZmFuU2VyYmFuLlBvcGFAYW5hbG9nLmNvbT4gd3JvdGU6DQo+ID4gDQo+ID4gDQo+ID4gT24gU2Is -IDIwMTgtMTEtMDMgYXQgMTI6MTYgKzAwMDAsIEpvbmF0aGFuIENhbWVyb24gd3JvdGU6DQo+ID4g -PiANCj4gPiA+IE9uIE1vbiwgMjkgT2N0IDIwMTggMTg6Mzg6MzEgKzAyMDANCj4gPiA+IFN0ZWZh -biBQb3BhIDxzdGVmYW4ucG9wYUBhbmFsb2cuY29tPiB3cm90ZToNCj4gPiA+IA0KPiA+ID4gPiAN -Cj4gPiA+ID4gDQo+ID4gPiA+IFRoZSBhZDcxMjQtNCBhbmQgYWQ3MTI0LTggYXJlIGEgZmFtaWx5 -IG9mIDQgYW5kIDggY2hhbm5lbCBzaWdtYS0NCj4gPiA+ID4gZGVsdGENCj4gPiA+ID4gQURDcw0K -PiA+ID4gPiB3aXRoIDI0LWJpdCBwcmVjaXNpb24gYW5kIHJlZmVyZW5jZS4NCj4gPiA+ID4gDQo+ -ID4gPiA+IFRocmVlIHBvd2VyIG1vZGVzIGFyZSBhdmFpbGFibGUgd2hpY2ggaW4gdHVybiBhZmZl -Y3QgdGhlIG91dHB1dA0KPiA+ID4gPiBkYXRhDQo+ID4gPiA+IHJhdGU6DQo+ID4gPiA+IMKgKiBG -dWxsIHBvd2VyOiA5LjM4IFNQUyB0byAxOSwyMDAgU1BTDQo+ID4gPiA+IMKgKiBNaWQgcG93ZXI6 -IDIuMzQgU1BTIHRvIDQ4MDAgU1BTDQo+ID4gPiA+IMKgKiBMb3cgcG93ZXI6IDEuMTcgU1BTIHRv -IDI0MDAgU1BTDQo+ID4gPiA+IA0KPiA+ID4gPiBUaGUgYWQ3MTI0LTQgY2FuIGJlIGNvbmZpZ3Vy -ZWQgdG8gaGF2ZSBmb3VyIGRpZmZlcmVudGlhbCBpbnB1dHMsDQo+ID4gPiA+IHdoaWxlDQo+ID4g -PiA+IGFkNzEyNC04IGNhbiBoYXZlIDguIE1vcmVvdmVyLCBhZDcxMjQgYWxzbyBzdXBwb3J0cyBw -ZXIgY2hhbm5lbA0KPiA+ID4gPiBjb25maWd1cmF0aW9uLiBFYWNoIGNvbmZpZ3VyYXRpb24gY29u -c2lzdHMgb2YgZ2FpbiwgcmVmZXJlbmNlDQo+ID4gPiA+IHNvdXJjZSwNCj4gPiA+ID4gb3V0cHV0 -IGRhdGEgcmF0ZSBhbmQgYmlwb2xhci91bmlwb2xhciBjb25maWd1cmF0aW9uLg0KPiA+ID4gPiAN -Cj4gPiA+ID4gRGF0YXNoZWV0czoNCj4gPiA+ID4gTGluazogaHR0cDovL3d3dy5hbmFsb2cuY29t -L21lZGlhL2VuL3RlY2huaWNhbC1kb2N1bWVudGF0aW9uL2RhdGEtcw0KPiA+ID4gPiBoZWV0DQo+ -ID4gPiA+IHMvQUQ3MTI0LTQucGRmDQo+ID4gPiA+IExpbms6IGh0dHA6Ly93d3cuYW5hbG9nLmNv -bS9tZWRpYS9lbi90ZWNobmljYWwtZG9jdW1lbnRhdGlvbi9kYXRhLXMNCj4gPiA+ID4gaGVldA0K -PiA+ID4gPiBzL2FkNzEyNC04LnBkZg0KPiA+ID4gPiANCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTog -U3RlZmFuIFBvcGEgPHN0ZWZhbi5wb3BhQGFuYWxvZy5jb20+DQo+ID4gPiBIaSBTdGVmYW4sDQo+ -ID4gPiANCj4gPiA+IFRoZSBkaXNjdXNzaW9uIGFyb3VuZCB0aGUgRFQgYmluZGluZyBoYXMgZ290 -dGVuIG1lIGxvb2tpbmcgYXQgYml0DQo+ID4gPiBtb3JlIGNsb3NlbHkgYXQgdGhhdCBmb3IgdGhp -cyB2ZXJzaW9uLg0KPiA+ID4gDQo+ID4gPiBTb21lIG1vc3QgY29tbWVudHMgaW4gdGhhdCBzZWN0 -aW9uLsKgwqBBbHNvIGEgcmVhbGx5IG1pbm9yIG9yZGVyaW5nDQo+ID4gPiBpc3N1ZQ0KPiA+ID4g -aW4NCj4gPiA+IHJlbW92ZSB3aGljaCBJJ2QganVzdCBoYXZlIGZpeGVkIGlmIHdlIHdlcmVuJ3Qg -Z29pbmcgYXJvdW5kIGFnYWluIGZvcg0KPiA+ID4gdGhlIGJpbmRpbmcuDQo+ID4gPiANCj4gPiA+ -IE1haW4gYmluZGluZyB0aGluZyBpcyBJIGRvbid0IHRoaW5rIHRoZSBvZHIgdmFsdWUgYmVsb25n -cyBpbiBEVC4NCj4gPiA+IEdhaW4gaXMgbW9yZSBtYXJnaW5hbCAodW5sZXNzIHRoZSBwYXJ0IGNh -biBhY3R1YWxseSBiZSBkYW1hZ2VkIGJ5DQo+ID4gPiBhIHdyb25nIHZhbHVlIC0gd2hpY2ggSSBo -b3BlIGl0IGNhbid0ISkuwqDCoEknbSBub3QgdGhhdCBmdXNzZWQNCj4gPiA+IGFzIHRoZXJlIGFy -ZSBkZWZpbml0ZWx5IHJlYXNvbnMgdG8gc3BlY2lmeSBhIGRlZmF1bHQgc2NhbGUgdG8NCj4gPiA+ -IGNvdmVyIHRoZSByZWFzb25hYmxlIHJhbmdlIG9uIGEgcGluLg0KPiA+ID4gDQo+ID4gPiBUaGFu -a3MsDQo+ID4gPiANCj4gPiA+IEpvbmF0aGFuDQo+ID4gSGkgSm9uYXRoYW4sDQo+ID4gDQo+ID4g -VGhhbmsgeW91IGZvciB0aGUgcmV2aWV3ISBTbywgaG93IHNob3VsZCBJIHByb2NlZWQ/DQo+ID4g -DQo+ID4gRmlyc3QsIHdlIG5lZWQgYW4gYWRjLnR4dCBmaWxlIHdoZXJlICJiaXBvbGFyIiBhbmQg -c29tZXRoaW5nIGxpa2UNCj4gPiAiZGlmZi0NCj4gPiBjaGFubmVscyIgc2hvdWxkIGJlIGRvY3Vt -ZW50ZWQuIFNob3VsZCB0aGUgZmlsZSBiZSBwbGFjZWQgdW5kZXINCj4gPiBEb2N1bWVudGF0aW9u -L2RldmljZXRyZWUvYmluZGluZ3MvaWlvL2FkYz8NCj4gWWVzLg0KPiANCj4gPiANCj4gPiBSZWdh -cmRpbmcgdGhlICJvZHItaHoiIHByb3BlcnR5LCBpdCB0b3RhbGx5IG1ha2VzIHNlbnNlIHRvIHJl -bW92ZSBpdA0KPiA+IGZyb20NCj4gPiB0aGUgRFQuIEhvdyBhYm91dCB0aGUgImdhaW4iPyBTaG91 -bGQgd2UgbGVhdmUgaXQgaW4gdGhlIERUIGFuZCBhbHNvIGFkZA0KPiA+IHRoZQ0KPiA+IHBvc3Np -YmlsaXR5IHRvIGJlIGNvbmZpZ3VyZWQgZnJvbSB1c2VyIHNwYWNlPw0KPiBMb29rIGF0IG90aGVy -IGJpbmRpbmdzLiBJIHRoaW5rIHRoZXJlIGFyZSBvdGhlcnMgaGF2aW5nIGdhaW4uIElmIG5vdCwN -Cj4gdGhlbiBpdCBwcm9iYWJseSBzaG91bGQgb25seSBiZSB1c2VyIHNwYWNlIGNvbmZpZ3VyYWJs -ZS4gSWYgc28sIHRoZW4NCj4gY2FuIGl0IGJlIGEgY29tbW9uIHByb3BlcnR5IHRvby4NCj4gDQo+ -IFJvYg0KPiANCg0KSGkgUm9iLA0KDQpJIGZvdW5kIG9ubHkgYSBjb3VwbGUgb2YgZXhhbXBsZXMg -dXNpbmcgZ2FpbiBpbiBvdGhlciBiaW5kaW5ncywgc28gSSBndWVzcw0KaXQncyBub3QgY29tbW9u -IHByYWN0aWNlLiBJIHdpbGwgcmVtb3ZlIHRoZSBnYWluIGFzIHdlbGwgZnJvbSB0aGUgRFQgYW5k -DQpzZXQgaXQgd2l0aCB0aGUgZGVmYXVsdCBvZiAxLg0KDQpASm9uYXRoYW46IEkgdGhpbmsgdGhh -dMKgSUlPX0NIQU5fSU5GT19IQVJEV0FSRUdBSU4gaXMgdGhlIGF0dHJpYnV0ZSB0aGF0DQpjYW4g -YmUgdXNlZCBpbiB1c2VyIHNwYWNlPw0KDQpUaGFuayB5b3UhDQotU3RlZmFu +On Jo, 2018-11-08 at 10:34 -0600, Rob Herring wrote: +> On Thu, Nov 8, 2018 at 9:02 AM Popa, Stefan Serban +> <StefanSerban.Popa@analog.com> wrote: +> > +> > +> > On Sb, 2018-11-03 at 12:16 +0000, Jonathan Cameron wrote: +> > > +> > > On Mon, 29 Oct 2018 18:38:31 +0200 +> > > Stefan Popa <stefan.popa@analog.com> wrote: +> > > +> > > > +> > > > +> > > > The ad7124-4 and ad7124-8 are a family of 4 and 8 channel sigma- +> > > > delta +> > > > ADCs +> > > > with 24-bit precision and reference. +> > > > +> > > > Three power modes are available which in turn affect the output +> > > > data +> > > > rate: +> > > > * Full power: 9.38 SPS to 19,200 SPS +> > > > * Mid power: 2.34 SPS to 4800 SPS +> > > > * Low power: 1.17 SPS to 2400 SPS +> > > > +> > > > The ad7124-4 can be configured to have four differential inputs, +> > > > while +> > > > ad7124-8 can have 8. Moreover, ad7124 also supports per channel +> > > > configuration. Each configuration consists of gain, reference +> > > > source, +> > > > output data rate and bipolar/unipolar configuration. +> > > > +> > > > Datasheets: +> > > > Link: http://www.analog.com/media/en/technical-documentation/data-s +> > > > heet +> > > > s/AD7124-4.pdf +> > > > Link: http://www.analog.com/media/en/technical-documentation/data-s +> > > > heet +> > > > s/ad7124-8.pdf +> > > > +> > > > Signed-off-by: Stefan Popa <stefan.popa@analog.com> +> > > Hi Stefan, +> > > +> > > The discussion around the DT binding has gotten me looking at bit +> > > more closely at that for this version. +> > > +> > > Some most comments in that section. Also a really minor ordering +> > > issue +> > > in +> > > remove which I'd just have fixed if we weren't going around again for +> > > the binding. +> > > +> > > Main binding thing is I don't think the odr value belongs in DT. +> > > Gain is more marginal (unless the part can actually be damaged by +> > > a wrong value - which I hope it can't!). I'm not that fussed +> > > as there are definitely reasons to specify a default scale to +> > > cover the reasonable range on a pin. +> > > +> > > Thanks, +> > > +> > > Jonathan +> > Hi Jonathan, +> > +> > Thank you for the review! So, how should I proceed? +> > +> > First, we need an adc.txt file where "bipolar" and something like +> > "diff- +> > channels" should be documented. Should the file be placed under +> > Documentation/devicetree/bindings/iio/adc? +> Yes. +> +> > +> > Regarding the "odr-hz" property, it totally makes sense to remove it +> > from +> > the DT. How about the "gain"? Should we leave it in the DT and also add +> > the +> > possibility to be configured from user space? +> Look at other bindings. I think there are others having gain. If not, +> then it probably should only be user space configurable. If so, then +> can it be a common property too. +> +> Rob +> + +Hi Rob, + +I found only a couple of examples using gain in other bindings, so I guess +it's not common practice. I will remove the gain as well from the DT and +set it with the default of 1. + +@Jonathan: I think that IIO_CHAN_INFO_HARDWAREGAIN is the attribute that +can be used in user space? + +Thank you! +-Stefan diff --git a/a/content_digest b/N1/content_digest index 0624eff..6fee288 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -17,61 +17,99 @@ " linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gSm8sIDIwMTgtMTEtMDggYXQgMTA6MzQgLTA2MDAsIFJvYiBIZXJyaW5nIHdyb3RlOg0KPiBP\n" - "biBUaHUsIE5vdiA4LCAyMDE4IGF0IDk6MDIgQU0gUG9wYSwgU3RlZmFuIFNlcmJhbg0KPiA8U3Rl\n" - "ZmFuU2VyYmFuLlBvcGFAYW5hbG9nLmNvbT4gd3JvdGU6DQo+ID4gDQo+ID4gDQo+ID4gT24gU2Is\n" - "IDIwMTgtMTEtMDMgYXQgMTI6MTYgKzAwMDAsIEpvbmF0aGFuIENhbWVyb24gd3JvdGU6DQo+ID4g\n" - "PiANCj4gPiA+IE9uIE1vbiwgMjkgT2N0IDIwMTggMTg6Mzg6MzEgKzAyMDANCj4gPiA+IFN0ZWZh\n" - "biBQb3BhIDxzdGVmYW4ucG9wYUBhbmFsb2cuY29tPiB3cm90ZToNCj4gPiA+IA0KPiA+ID4gPiAN\n" - "Cj4gPiA+ID4gDQo+ID4gPiA+IFRoZSBhZDcxMjQtNCBhbmQgYWQ3MTI0LTggYXJlIGEgZmFtaWx5\n" - "IG9mIDQgYW5kIDggY2hhbm5lbCBzaWdtYS0NCj4gPiA+ID4gZGVsdGENCj4gPiA+ID4gQURDcw0K\n" - "PiA+ID4gPiB3aXRoIDI0LWJpdCBwcmVjaXNpb24gYW5kIHJlZmVyZW5jZS4NCj4gPiA+ID4gDQo+\n" - "ID4gPiA+IFRocmVlIHBvd2VyIG1vZGVzIGFyZSBhdmFpbGFibGUgd2hpY2ggaW4gdHVybiBhZmZl\n" - "Y3QgdGhlIG91dHB1dA0KPiA+ID4gPiBkYXRhDQo+ID4gPiA+IHJhdGU6DQo+ID4gPiA+IMKgKiBG\n" - "dWxsIHBvd2VyOiA5LjM4IFNQUyB0byAxOSwyMDAgU1BTDQo+ID4gPiA+IMKgKiBNaWQgcG93ZXI6\n" - "IDIuMzQgU1BTIHRvIDQ4MDAgU1BTDQo+ID4gPiA+IMKgKiBMb3cgcG93ZXI6IDEuMTcgU1BTIHRv\n" - "IDI0MDAgU1BTDQo+ID4gPiA+IA0KPiA+ID4gPiBUaGUgYWQ3MTI0LTQgY2FuIGJlIGNvbmZpZ3Vy\n" - "ZWQgdG8gaGF2ZSBmb3VyIGRpZmZlcmVudGlhbCBpbnB1dHMsDQo+ID4gPiA+IHdoaWxlDQo+ID4g\n" - "PiA+IGFkNzEyNC04IGNhbiBoYXZlIDguIE1vcmVvdmVyLCBhZDcxMjQgYWxzbyBzdXBwb3J0cyBw\n" - "ZXIgY2hhbm5lbA0KPiA+ID4gPiBjb25maWd1cmF0aW9uLiBFYWNoIGNvbmZpZ3VyYXRpb24gY29u\n" - "c2lzdHMgb2YgZ2FpbiwgcmVmZXJlbmNlDQo+ID4gPiA+IHNvdXJjZSwNCj4gPiA+ID4gb3V0cHV0\n" - "IGRhdGEgcmF0ZSBhbmQgYmlwb2xhci91bmlwb2xhciBjb25maWd1cmF0aW9uLg0KPiA+ID4gPiAN\n" - "Cj4gPiA+ID4gRGF0YXNoZWV0czoNCj4gPiA+ID4gTGluazogaHR0cDovL3d3dy5hbmFsb2cuY29t\n" - "L21lZGlhL2VuL3RlY2huaWNhbC1kb2N1bWVudGF0aW9uL2RhdGEtcw0KPiA+ID4gPiBoZWV0DQo+\n" - "ID4gPiA+IHMvQUQ3MTI0LTQucGRmDQo+ID4gPiA+IExpbms6IGh0dHA6Ly93d3cuYW5hbG9nLmNv\n" - "bS9tZWRpYS9lbi90ZWNobmljYWwtZG9jdW1lbnRhdGlvbi9kYXRhLXMNCj4gPiA+ID4gaGVldA0K\n" - "PiA+ID4gPiBzL2FkNzEyNC04LnBkZg0KPiA+ID4gPiANCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTog\n" - "U3RlZmFuIFBvcGEgPHN0ZWZhbi5wb3BhQGFuYWxvZy5jb20+DQo+ID4gPiBIaSBTdGVmYW4sDQo+\n" - "ID4gPiANCj4gPiA+IFRoZSBkaXNjdXNzaW9uIGFyb3VuZCB0aGUgRFQgYmluZGluZyBoYXMgZ290\n" - "dGVuIG1lIGxvb2tpbmcgYXQgYml0DQo+ID4gPiBtb3JlIGNsb3NlbHkgYXQgdGhhdCBmb3IgdGhp\n" - "cyB2ZXJzaW9uLg0KPiA+ID4gDQo+ID4gPiBTb21lIG1vc3QgY29tbWVudHMgaW4gdGhhdCBzZWN0\n" - "aW9uLsKgwqBBbHNvIGEgcmVhbGx5IG1pbm9yIG9yZGVyaW5nDQo+ID4gPiBpc3N1ZQ0KPiA+ID4g\n" - "aW4NCj4gPiA+IHJlbW92ZSB3aGljaCBJJ2QganVzdCBoYXZlIGZpeGVkIGlmIHdlIHdlcmVuJ3Qg\n" - "Z29pbmcgYXJvdW5kIGFnYWluIGZvcg0KPiA+ID4gdGhlIGJpbmRpbmcuDQo+ID4gPiANCj4gPiA+\n" - "IE1haW4gYmluZGluZyB0aGluZyBpcyBJIGRvbid0IHRoaW5rIHRoZSBvZHIgdmFsdWUgYmVsb25n\n" - "cyBpbiBEVC4NCj4gPiA+IEdhaW4gaXMgbW9yZSBtYXJnaW5hbCAodW5sZXNzIHRoZSBwYXJ0IGNh\n" - "biBhY3R1YWxseSBiZSBkYW1hZ2VkIGJ5DQo+ID4gPiBhIHdyb25nIHZhbHVlIC0gd2hpY2ggSSBo\n" - "b3BlIGl0IGNhbid0ISkuwqDCoEknbSBub3QgdGhhdCBmdXNzZWQNCj4gPiA+IGFzIHRoZXJlIGFy\n" - "ZSBkZWZpbml0ZWx5IHJlYXNvbnMgdG8gc3BlY2lmeSBhIGRlZmF1bHQgc2NhbGUgdG8NCj4gPiA+\n" - "IGNvdmVyIHRoZSByZWFzb25hYmxlIHJhbmdlIG9uIGEgcGluLg0KPiA+ID4gDQo+ID4gPiBUaGFu\n" - "a3MsDQo+ID4gPiANCj4gPiA+IEpvbmF0aGFuDQo+ID4gSGkgSm9uYXRoYW4sDQo+ID4gDQo+ID4g\n" - "VGhhbmsgeW91IGZvciB0aGUgcmV2aWV3ISBTbywgaG93IHNob3VsZCBJIHByb2NlZWQ/DQo+ID4g\n" - "DQo+ID4gRmlyc3QsIHdlIG5lZWQgYW4gYWRjLnR4dCBmaWxlIHdoZXJlICJiaXBvbGFyIiBhbmQg\n" - "c29tZXRoaW5nIGxpa2UNCj4gPiAiZGlmZi0NCj4gPiBjaGFubmVscyIgc2hvdWxkIGJlIGRvY3Vt\n" - "ZW50ZWQuIFNob3VsZCB0aGUgZmlsZSBiZSBwbGFjZWQgdW5kZXINCj4gPiBEb2N1bWVudGF0aW9u\n" - "L2RldmljZXRyZWUvYmluZGluZ3MvaWlvL2FkYz8NCj4gWWVzLg0KPiANCj4gPiANCj4gPiBSZWdh\n" - "cmRpbmcgdGhlICJvZHItaHoiIHByb3BlcnR5LCBpdCB0b3RhbGx5IG1ha2VzIHNlbnNlIHRvIHJl\n" - "bW92ZSBpdA0KPiA+IGZyb20NCj4gPiB0aGUgRFQuIEhvdyBhYm91dCB0aGUgImdhaW4iPyBTaG91\n" - "bGQgd2UgbGVhdmUgaXQgaW4gdGhlIERUIGFuZCBhbHNvIGFkZA0KPiA+IHRoZQ0KPiA+IHBvc3Np\n" - "YmlsaXR5IHRvIGJlIGNvbmZpZ3VyZWQgZnJvbSB1c2VyIHNwYWNlPw0KPiBMb29rIGF0IG90aGVy\n" - "IGJpbmRpbmdzLiBJIHRoaW5rIHRoZXJlIGFyZSBvdGhlcnMgaGF2aW5nIGdhaW4uIElmIG5vdCwN\n" - "Cj4gdGhlbiBpdCBwcm9iYWJseSBzaG91bGQgb25seSBiZSB1c2VyIHNwYWNlIGNvbmZpZ3VyYWJs\n" - "ZS4gSWYgc28sIHRoZW4NCj4gY2FuIGl0IGJlIGEgY29tbW9uIHByb3BlcnR5IHRvby4NCj4gDQo+\n" - "IFJvYg0KPiANCg0KSGkgUm9iLA0KDQpJIGZvdW5kIG9ubHkgYSBjb3VwbGUgb2YgZXhhbXBsZXMg\n" - "dXNpbmcgZ2FpbiBpbiBvdGhlciBiaW5kaW5ncywgc28gSSBndWVzcw0KaXQncyBub3QgY29tbW9u\n" - "IHByYWN0aWNlLiBJIHdpbGwgcmVtb3ZlIHRoZSBnYWluIGFzIHdlbGwgZnJvbSB0aGUgRFQgYW5k\n" - "DQpzZXQgaXQgd2l0aCB0aGUgZGVmYXVsdCBvZiAxLg0KDQpASm9uYXRoYW46IEkgdGhpbmsgdGhh\n" - "dMKgSUlPX0NIQU5fSU5GT19IQVJEV0FSRUdBSU4gaXMgdGhlIGF0dHJpYnV0ZSB0aGF0DQpjYW4g\n" - YmUgdXNlZCBpbiB1c2VyIHNwYWNlPw0KDQpUaGFuayB5b3UhDQotU3RlZmFu + "On Jo, 2018-11-08 at 10:34 -0600, Rob Herring wrote:\n" + "> On Thu, Nov 8, 2018 at 9:02 AM Popa, Stefan Serban\n" + "> <StefanSerban.Popa@analog.com> wrote:\n" + "> > \n" + "> > \n" + "> > On Sb, 2018-11-03 at 12:16 +0000, Jonathan Cameron wrote:\n" + "> > > \n" + "> > > On Mon, 29 Oct 2018 18:38:31 +0200\n" + "> > > Stefan Popa <stefan.popa@analog.com> wrote:\n" + "> > > \n" + "> > > > \n" + "> > > > \n" + "> > > > The ad7124-4 and ad7124-8 are a family of 4 and 8 channel sigma-\n" + "> > > > delta\n" + "> > > > ADCs\n" + "> > > > with 24-bit precision and reference.\n" + "> > > > \n" + "> > > > Three power modes are available which in turn affect the output\n" + "> > > > data\n" + "> > > > rate:\n" + "> > > > \302\240* Full power: 9.38 SPS to 19,200 SPS\n" + "> > > > \302\240* Mid power: 2.34 SPS to 4800 SPS\n" + "> > > > \302\240* Low power: 1.17 SPS to 2400 SPS\n" + "> > > > \n" + "> > > > The ad7124-4 can be configured to have four differential inputs,\n" + "> > > > while\n" + "> > > > ad7124-8 can have 8. Moreover, ad7124 also supports per channel\n" + "> > > > configuration. Each configuration consists of gain, reference\n" + "> > > > source,\n" + "> > > > output data rate and bipolar/unipolar configuration.\n" + "> > > > \n" + "> > > > Datasheets:\n" + "> > > > Link: http://www.analog.com/media/en/technical-documentation/data-s\n" + "> > > > heet\n" + "> > > > s/AD7124-4.pdf\n" + "> > > > Link: http://www.analog.com/media/en/technical-documentation/data-s\n" + "> > > > heet\n" + "> > > > s/ad7124-8.pdf\n" + "> > > > \n" + "> > > > Signed-off-by: Stefan Popa <stefan.popa@analog.com>\n" + "> > > Hi Stefan,\n" + "> > > \n" + "> > > The discussion around the DT binding has gotten me looking at bit\n" + "> > > more closely at that for this version.\n" + "> > > \n" + "> > > Some most comments in that section.\302\240\302\240Also a really minor ordering\n" + "> > > issue\n" + "> > > in\n" + "> > > remove which I'd just have fixed if we weren't going around again for\n" + "> > > the binding.\n" + "> > > \n" + "> > > Main binding thing is I don't think the odr value belongs in DT.\n" + "> > > Gain is more marginal (unless the part can actually be damaged by\n" + "> > > a wrong value - which I hope it can't!).\302\240\302\240I'm not that fussed\n" + "> > > as there are definitely reasons to specify a default scale to\n" + "> > > cover the reasonable range on a pin.\n" + "> > > \n" + "> > > Thanks,\n" + "> > > \n" + "> > > Jonathan\n" + "> > Hi Jonathan,\n" + "> > \n" + "> > Thank you for the review! So, how should I proceed?\n" + "> > \n" + "> > First, we need an adc.txt file where \"bipolar\" and something like\n" + "> > \"diff-\n" + "> > channels\" should be documented. Should the file be placed under\n" + "> > Documentation/devicetree/bindings/iio/adc?\n" + "> Yes.\n" + "> \n" + "> > \n" + "> > Regarding the \"odr-hz\" property, it totally makes sense to remove it\n" + "> > from\n" + "> > the DT. How about the \"gain\"? Should we leave it in the DT and also add\n" + "> > the\n" + "> > possibility to be configured from user space?\n" + "> Look at other bindings. I think there are others having gain. If not,\n" + "> then it probably should only be user space configurable. If so, then\n" + "> can it be a common property too.\n" + "> \n" + "> Rob\n" + "> \n" + "\n" + "Hi Rob,\n" + "\n" + "I found only a couple of examples using gain in other bindings, so I guess\n" + "it's not common practice. I will remove the gain as well from the DT and\n" + "set it with the default of 1.\n" + "\n" + "@Jonathan: I think that\302\240IIO_CHAN_INFO_HARDWAREGAIN is the attribute that\n" + "can be used in user space?\n" + "\n" + "Thank you!\n" + -Stefan -6738da3f9f34a6419eadb0a431d71dc4f9d33adc1c7921df78b1f7dea08fe456 +289ea875a00a14de42cf2c5010f72b614de84bfbb3b1c38817eb0ff2fee88f30
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.