All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 2/2] imx: mkimage: add size check to the u-boot.imx make target
Date: Fri, 9 Nov 2018 14:35:34 +0000	[thread overview]
Message-ID: <1541774132.6873.30.camel@toradex.com> (raw)
In-Reply-To: <2db259f4-4e40-cbdc-8b6d-f0f571659eb9@denx.de>

Hi Stefano

On Thu, 2018-11-08 at 15:07 +0100, Stefano Babic wrote:
> Hi Marcel,
> 
> On 08/11/18 02:55, Fabio Estevam wrote:
> > [Adding Stefano]
> > 
> > On Wed, Nov 7, 2018 at 8:41 PM Marcel Ziswiler <marcel@ziswiler.com
> > > wrote:
> > > 
> > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > > 
> > > The make macro to check if the binary exceeds the board size
> > > limit is
> > > taken straight from the root Makefile.
> > > 
> > > Without this and e.g. enabled EFI Vybrid fails booting as the
> > > regular
> > > size limit check does not take the final u-boot.imx binary size
> > > into
> > > account which is bigger due to alignment as well as IMX header
> > > stuff.
> > > 
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > Reviewed-by: Fabio Estevam <festevam@gmail.com>
> > 
> > Hi Stefano, maybe this could be material for 2018.11?
> > 
> 
> Added both patches to u-boot-imx, check is effective, now size is too
> much and build fails:
> 
> 
> Building current source for 1 boards (1 thread, 8 jobs per thread)
>        arm:  +   colibri_vf
> +u-boot.imx exceeds file size limit:
> +  limit:  520192 bytes
> +  actual: 526104 bytes
> +  excess: 5912 bytes
> +make[2]: *** [u-boot.imx] Error 1
> +make[1]: *** [u-boot.imx] Error 2
> +make: *** [sub-make] Error 2
>     0    0    1 /1      colibri_vf
> 
> Can you take a look ?

I sent a v2 additionally dropping CONFIG_CMDLINE_EDITING and SPI
support saving another 8 Kb which for me makes it work right back to
GCC 6.1.1 which I believe is anyway about as far back as one can go
even compiling U-Boot. Can you please give that another go?

> Best regards,
> Stefeano

Cheers

Marcel

  parent reply	other threads:[~2018-11-09 14:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 22:39 [U-Boot] [PATCH v1 1/2] board: toradex: colibri_vf: efi_loader: unset CONFIG_EFI_UNICODE_CAPITALIZATION Marcel Ziswiler
2018-11-07 22:39 ` [U-Boot] [PATCH v1 2/2] imx: mkimage: add size check to the u-boot.imx make target Marcel Ziswiler
2018-11-08  1:55   ` Fabio Estevam
2018-11-08  8:43     ` Stefano Babic
2018-11-08 12:13       ` Tom Rini
2018-11-08 14:07     ` Stefano Babic
2018-11-09  9:18       ` Marcel Ziswiler
2018-11-09  9:41         ` Alexander Graf
2018-11-09 10:23           ` Marcel Ziswiler
2018-11-09 14:35       ` Marcel Ziswiler [this message]
2018-11-12 11:57         ` Stefano Babic
2018-11-07 23:37 ` [U-Boot] [PATCH v1 1/2] board: toradex: colibri_vf: efi_loader: unset CONFIG_EFI_UNICODE_CAPITALIZATION Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541774132.6873.30.camel@toradex.com \
    --to=marcel.ziswiler@toradex.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.