From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH 3/3] drm/i915: add ICP support to cnp_rawclk() and kill icp_rawclk() Date: Mon, 12 Nov 2018 10:17:22 -0800 Message-ID: <1542046642.2702.3.camel@intel.com> References: <20181012004045.13535-1-paulo.r.zanoni@intel.com> <20181110002350.24362-1-paulo.r.zanoni@intel.com> <20181110002350.24362-3-paulo.r.zanoni@intel.com> <20181112145454.GP9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 047616E105 for ; Mon, 12 Nov 2018 18:17:22 +0000 (UTC) In-Reply-To: <20181112145454.GP9144@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org RW0gU2VnLCAyMDE4LTExLTEyIMOgcyAxNjo1NCArMDIwMCwgVmlsbGUgU3lyasOkbMOkIGVzY3Jl dmV1Ogo+IE9uIEZyaSwgTm92IDA5LCAyMDE4IGF0IDA0OjIzOjUwUE0gLTA4MDAsIFBhdWxvIFph bm9uaSB3cm90ZToKPiA+IEkgdGhpbmsgSSdtIHByb2JhYmx5IHRoZSBvbmUgd2hvIGFyZ3VlZCBp biBmYXZvciBvZiBoYXZpbmcgc2VwYXJhdGUKPiA+IGltcGxlbWVudGF0aW9ucyBmb3IgYm90aCBQ Q0hzLCBidXQgdGhlIGNhbGN1bGF0aW9ucyBhcmUgYWN0dWFsbHkKPiA+IHRoZQo+ID4gc2FtZSwg dGhlIGNsb2NrcyBhcmUgdGhlIHNhbWUgYW5kIHRoZSBvbmx5IGRpZmZlcmVuY2UgaXMgdGhhdCBv bgo+ID4gSUNQCj4gPiB3ZSB3cml0ZSB0aGUgbnVtZXJhdG9yIHRvIHRoZSByZWdpc3Rlci4KPiA+ IAo+ID4gSSBoYXZlIHByZXZpb3VzbHkgc3VnZ2VzdGVkIHRvIGtpbGwgY25wX3Jhd2NsaygpIGFu ZCBrZWVwIHRoZQo+ID4gaWNwX3Jhd2NsaygpIHN0eWxlLCBidXQgVmlsbGUgZ2F2ZSBzb21lIGdv b2QgYXJndW1lbnRzIHRoYXQgd2hhdCdzCj4gPiBpbgo+ID4gdGhpcyBwYXRjaCBtYXkgYmUgdGhl IGJldHRlciBjaG9pY2UuCj4gPiAKPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogUGF1bG8gWmFub25pIDxwYXVs by5yLnphbm9uaUBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9jZGNsay5jIHwgMzcgKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gPiAtLS0tLS0tLS0t LS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMjkgZGVsZXRpb25zKC0p Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5j Cj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiA+IGluZGV4IDkyODY3 MTkzNjI4Ni4uNjA0Mzc2NzUzNTRlIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfY2RjbGsuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2Rj bGsuYwo+ID4gQEAgLTI2NjEsMzYgKzI2NjEsMTcgQEAgc3RhdGljIGludCBjbnBfcmF3Y2xrKHN0 cnVjdAo+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgCX0KPiA+ICAKPiA+ICAJ cmF3Y2xrID0gQ05QX1JBV0NMS19ESVYoZGl2aWRlciAvIDEwMDApOwo+ID4gLQlpZiAoZnJhY3Rp b24pCj4gPiAtCQlyYXdjbGsgfD0gQ05QX1JBV0NMS19ERU4oRElWX1JPVU5EX0NMT1NFU1QoMTAw MCwKPiA+IC0JCQkJCQkJICAgZnJhY3Rpbwo+ID4gbikgLSAxKTsKPiA+ICsJaWYgKGZyYWN0aW9u KSB7Cj4gPiArCQlpbnQgbnVtZXJhdG9yID0gMTAwMDsKPiA+ICAKPiA+IC0JSTkxNV9XUklURShQ Q0hfUkFXQ0xLX0ZSRVEsIHJhd2Nsayk7Cj4gPiAtCXJldHVybiBkaXZpZGVyICsgZnJhY3Rpb247 Cj4gPiAtfQo+ID4gLQo+ID4gLXN0YXRpYyBpbnQgaWNwX3Jhd2NsayhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAtewo+ID4gLQl1MzIgcmF3Y2xrOwo+ID4gLQlpbnQgZGl2 aWRlciwgbnVtZXJhdG9yLCBkZW5vbWluYXRvciwgZnJlcXVlbmN5Owo+ID4gLQo+ID4gLQlpZiAo STkxNV9SRUFEKFNGVVNFX1NUUkFQKSAmIFNGVVNFX1NUUkFQX1JBV19GUkVRVUVOQ1kpIHsKPiA+ IC0JCWZyZXF1ZW5jeSA9IDI0MDAwOwo+ID4gLQkJZGl2aWRlciA9IDI0Owo+ID4gLQkJbnVtZXJh dG9yID0gMDsKPiA+IC0JCWRlbm9taW5hdG9yID0gMDsKPiA+IC0JfSBlbHNlIHsKPiA+IC0JCWZy ZXF1ZW5jeSA9IDE5MjAwOwo+ID4gLQkJZGl2aWRlciA9IDE5Owo+ID4gLQkJbnVtZXJhdG9yID0g MTsKPiA+IC0JCWRlbm9taW5hdG9yID0gNDsKPiA+ICsJCXJhd2NsayB8PQo+ID4gQ05QX1JBV0NM S19ERU4oRElWX1JPVU5EX0NMT1NFU1QobnVtZXJhdG9yLAo+ID4gKwkJCQkJCQkgICBmcmFjdGlv Cj4gPiBuKSAtIDEpOwo+ID4gKwkJaWYgKEhBU19QQ0hfSUNQKGRldl9wcml2KSkKPiA+ICsJCQly YXdjbGsgfD0gSUNQX1JBV0NMS19OVU0obnVtZXJhdG9yIC8KPiA+IDEwMDApOwo+IAo+IE1heWJl Cj4gaW50IG51bWVyYXRvciA9IDE7Cj4gLi4uCj4gRElWX1JPVU5EX0NMT1NFU1QobnVtZXJhdG9y ICogMTAwMCwgLi4uID8KCldpbGwgZG8uIEkgZ3Vlc3MgSSB0cmllZCB0byBrZWVwIHRoZSBsb2dp YyBvZiAibG9jYWwgdmFyaWFibGVzIHNob3VsZApiZSBpbiBLSHogYW5kIGNvbnZlcnNpb24gdG8g TUh6IGdvZXMgaW5zaWRlIHRoZSByZWctd3JpdGluZyBtYWNyb3MiLApidXQgSSBkb24ndCBmZWVs IGl0IGlzIGJldHRlciBvciB3b3JzZSB0aGFuIHRoZSBzdWdnZXN0aW9uLgoKCj4gCj4gVGhlIGZp eGVkIG51bWVyYXRvciBpcyBPSyBzaW5jZSB3ZSBvbmx5IGhhdmUgdG8gc3VwcG9ydCAxOS4yIGZv cgo+IG5vdy4gSWYgaW4gdGhlIGZ1dHVyZSB3ZSBnZXQgbW9yZSBmcmVxdWVuY2llcyB3ZSBtYXkg d2FudCB0byBtYWtlCj4gdGhpcyBtb3JlIGZsZXhpYmxlLiBCdXQgbm90IG11Y2ggcG9pbnQgaW4g d29ycnlpbmcgYWJvdXQgdGhhdCBub3cuCj4gCj4gU2VyaWVzIGlzCj4gUmV2aWV3ZWQtYnk6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpUaGFua3MgYSBs b3QuIFNvcnJ5IGZvciB0aGUgaHVnZSBkZWxheSBpbiB0aGUgZm9sbG93LXVwLgoKPiAKPiA+ICAJ fQo+ID4gIAo+ID4gLQlyYXdjbGsgPSBDTlBfUkFXQ0xLX0RJVihkaXZpZGVyKSB8Cj4gPiBJQ1Bf UkFXQ0xLX05VTShudW1lcmF0b3IpIHwKPiA+IC0JCSBDTlBfUkFXQ0xLX0RFTihkZW5vbWluYXRv cik7Cj4gPiAtCj4gPiAgCUk5MTVfV1JJVEUoUENIX1JBV0NMS19GUkVRLCByYXdjbGspOwo+ID4g LQlyZXR1cm4gZnJlcXVlbmN5Owo+ID4gKwlyZXR1cm4gZGl2aWRlciArIGZyYWN0aW9uOwo+ID4g IH0KPiA+ICAKPiA+ICBzdGF0aWMgaW50IHBjaF9yYXdjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ID4gQEAgLTI3NDAsOSArMjcyMSw3IEBAIHN0YXRpYyBpbnQgZzR4X2hy YXdjbGsoc3RydWN0Cj4gPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAgKi8KPiA+ ICB2b2lkIGludGVsX3VwZGF0ZV9yYXdjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ID4gIHsKPiA+IC0JaWYgKEhBU19QQ0hfSUNQKGRldl9wcml2KSkKPiA+IC0JCWRldl9w cml2LT5yYXdjbGtfZnJlcSA9IGljcF9yYXdjbGsoZGV2X3ByaXYpOwo+ID4gLQllbHNlIGlmIChI QVNfUENIX0NOUChkZXZfcHJpdikpCj4gPiArCWlmIChIQVNfUENIX0NOUChkZXZfcHJpdikgfHwg SEFTX1BDSF9JQ1AoZGV2X3ByaXYpKQo+ID4gIAkJZGV2X3ByaXYtPnJhd2Nsa19mcmVxID0gY25w X3Jhd2NsayhkZXZfcHJpdik7Cj4gPiAgCWVsc2UgaWYgKEhBU19QQ0hfU1BMSVQoZGV2X3ByaXYp KQo+ID4gIAkJZGV2X3ByaXYtPnJhd2Nsa19mcmVxID0gcGNoX3Jhd2NsayhkZXZfcHJpdik7Cj4g PiAtLSAKPiA+IDIuMTQuNAo+IAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK