From: Philipp Zabel <p.zabel@pengutronix.de>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4] reset: socfpga: add an early reset driver for SoCFPGA
Date: Thu, 15 Nov 2018 16:34:47 +0100 [thread overview]
Message-ID: <1542296087.4915.28.camel@pengutronix.de> (raw)
In-Reply-To: <20181113185048.8538-1-dinguyen@kernel.org>
Hi Dinh,
On Tue, 2018-11-13 at 12:50 -0600, Dinh Nguyen wrote:
> @@ -120,7 +120,8 @@ static const struct reset_simple_devdata reset_simple_active_low = {
> };
>
> static const struct of_device_id reset_simple_dt_ids[] = {
> - { .compatible = "altr,rst-mgr", .data = &reset_simple_socfpga },
> + { .compatible = "altr,stratix10-rst-mgr", "altr,rst-mgr",
This should be
+ { .compatible = "altr,stratix10-rst-mgr",
instead. The rest looks good to me. If you are ok with this change, I
can fix it up when applying.
regards
Philipp
next prev parent reply other threads:[~2018-11-15 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 18:50 [PATCHv4] reset: socfpga: add an early reset driver for SoCFPGA Dinh Nguyen
2018-11-15 15:34 ` Philipp Zabel [this message]
2018-11-15 16:23 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542296087.4915.28.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.