From: osalvador <osalvador@suse.com>
To: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Baoquan He <bhe@redhat.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure
Date: Fri, 16 Nov 2018 11:38:41 +0100 [thread overview]
Message-ID: <1542364721.3020.5.camel@suse.com> (raw)
In-Reply-To: <20181116083020.20260-5-mhocko@kernel.org>
On Fri, 2018-11-16 at 09:30 +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> The memory offlining failure reporting is inconsistent and
> insufficient.
> Some error paths simply do not report the failure to the log at all.
> When we do report there are no details about the reason of the
> failure
> and there are several of them which makes memory offlining failures
> hard to debug.
>
> Make sure that the
> memory offlining [mem %#010llx-%#010llx] failed
> message is printed for all failures and also provide a short textual
> reason for the failure e.g.
>
> [ 1984.506184] rac1 kernel: memory offlining [mem 0x82600000000-
> 0x8267fffffff] failed due to signal backoff
>
> this tells us that the offlining has failed because of a signal
> pending
> aka user intervention.
>
> [akpm: tweak messages a bit]
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
next prev parent reply other threads:[~2018-11-16 10:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 8:30 [PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Michal Hocko
2018-11-16 8:30 ` Michal Hocko
2018-11-16 8:30 ` [PATCH 1/5] mm: print more information about mapping in __dump_page Michal Hocko
2018-11-16 8:30 ` Michal Hocko
2018-11-16 11:55 ` Anshuman Khandual
2018-11-16 13:50 ` William Kucharski
2018-11-16 8:30 ` [PATCH 2/5] mm: lower the printk loglevel for __dump_page messages Michal Hocko
2018-11-16 8:30 ` Michal Hocko
2018-11-16 11:57 ` Anshuman Khandual
2018-11-16 8:30 ` [PATCH 3/5] mm, memory_hotplug: drop pointless block alignment checks from __offline_pages Michal Hocko
2018-11-16 8:30 ` Michal Hocko
2018-11-16 10:34 ` osalvador
2018-11-16 11:19 ` Michal Hocko
2018-11-16 11:56 ` Anshuman Khandual
2018-11-16 8:30 ` [PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure Michal Hocko
2018-11-16 8:30 ` Michal Hocko
2018-11-16 10:38 ` osalvador [this message]
2018-11-16 12:04 ` Anshuman Khandual
2018-11-16 8:30 ` [PATCH 5/5] mm, memory_hotplug: be more verbose for memory offline failures Michal Hocko
2018-11-16 8:30 ` Michal Hocko
2018-11-16 10:47 ` osalvador
2018-11-16 11:22 ` Michal Hocko
2018-11-16 12:29 ` osalvador
2018-11-16 12:07 ` Anshuman Khandual
2018-11-16 11:55 ` [PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542364721.3020.5.camel@suse.com \
--to=osalvador@suse.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.