All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Qiang <liq3ea@gmail.com>
To: armbru@redhat.com, pbonzini@redhat.com, kraxel@redhat.com,
	lersek@redhat.com, philmd@redhat.com
Cc: qemu-devel@nongnu.org, liq3ea@gmail.com
Subject: [Qemu-devel] [PATCH v2 3/3] fw_cfg: make qemu_extra_params_fw locally
Date: Tue, 20 Nov 2018 21:10:26 -0800	[thread overview]
Message-ID: <1542777026-2788-4-git-send-email-liq3ea@gmail.com> (raw)
In-Reply-To: <1542777026-2788-1-git-send-email-liq3ea@gmail.com>

qemu_extra_params_fw[] has external linkage, but is used
only in fw_cfg_bootsplash(), it makes sense to make it
locally.

Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
 hw/nvram/fw_cfg.c       | 1 +
 include/sysemu/sysemu.h | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index aafa96721f..a71f043b5d 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -120,6 +120,7 @@ static void fw_cfg_bootsplash(FWCfgState *s)
 {
     const char *boot_splash_filename = NULL;
     const char *boot_splash_time = NULL;
+    uint8_t qemu_extra_params_fw[2];
     char *filename, *file_data;
     gsize file_size;
     int file_type;
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 8d6095d98b..f8608d24d9 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sysemu/sysemu.h
@@ -133,7 +133,6 @@ extern uint8_t *boot_splash_filedata;
 extern size_t boot_splash_filedata_size;
 extern bool enable_mlock;
 extern bool enable_cpu_pm;
-extern uint8_t qemu_extra_params_fw[2];
 extern QEMUClockType rtc_clock;
 extern const char *mem_path;
 extern int mem_prealloc;
-- 
2.11.0

  parent reply	other threads:[~2018-11-21  5:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21  5:10 [Qemu-devel] [PATCH v2 0/3] fw_cfg: fix boot bootsplash and reboot-timeout error checking Li Qiang
2018-11-21  5:10 ` [Qemu-devel] [PATCH v2 1/3] fw_cfg: fix -boot bootsplash " Li Qiang
2018-12-11 16:13   ` Philippe Mathieu-Daudé
2018-11-21  5:10 ` [Qemu-devel] [PATCH v2 2/3] fw_cfg: fix -boot reboot-timeout " Li Qiang
2018-12-11 16:17   ` Philippe Mathieu-Daudé
2018-11-21  5:10 ` Li Qiang [this message]
2018-12-11 16:18   ` [Qemu-devel] [PATCH v2 3/3] fw_cfg: make qemu_extra_params_fw locally Philippe Mathieu-Daudé
2018-12-10 14:33 ` [Qemu-devel] [PATCH v2 0/3] fw_cfg: fix boot bootsplash and reboot-timeout error checking Gerd Hoffmann
2018-12-11 16:19 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1542777026-2788-4-git-send-email-liq3ea@gmail.com \
    --to=liq3ea@gmail.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.