All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: MaxLyubimov <m.lyubimov@aqsi.ru>, ofono@lists.linux.dev
Subject: Re: [PATCH 12/15] Fix PPP LCP Configure-Reject
Date: Wed, 18 Oct 2023 21:08:16 -0500	[thread overview]
Message-ID: <1542d6ef-2ff2-408f-bbd8-3902bf929bba@gmail.com> (raw)
In-Reply-To: <20231017104902.717947-12-m.lyubimov@aqsi.ru>

Hi Maxim,

On 10/17/23 05:48, MaxLyubimov wrote:
> According to RFC 1661 5.4
> 
> If some Configuration Options received in a Configure-Request are
> not recognizable or are not acceptable for negotiation (as
> configured by a network administrator), then the implementation
> MUST transmit a Configure-Reject.  The Options field is filled
> with only the unacceptable Configuration Options from the
> Configure-Request.  All recognizable and negotiable Configuration
> Options are filtered out of the Configure-Reject, but otherwise
> the Configuration Options MUST NOT be reordered or modified in any
> way.
> 
> Therefore, if the authorization type is NONE, then the authorization
> type must be added to the list of not acceptable options.
> ---
>   gatchat/ppp_lcp.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 

Applied after a minor style fix and rewording of the git commit heading.

Regards,
-Denis


  reply	other threads:[~2023-10-19  2:08 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17 10:48 [PATCH 01/15] Skipping AT+CUAD sending for QUECTEL_EC2X vendor MaxLyubimov
2023-10-17 10:48 ` [PATCH 02/15] drivers: adding support for the SIMCom A7605E-H MaxLyubimov
2023-10-19  1:30   ` Denis Kenzior
2023-10-27  7:52     ` Любимов Максим
2023-10-29 21:16       ` Denis Kenzior
2023-10-17 10:48 ` [PATCH 03/15] plugins: " MaxLyubimov
2023-10-19  1:42   ` Denis Kenzior
2023-10-27  9:01     ` Любимов Максим
2023-10-29 20:41       ` Denis Kenzior
2023-10-30  7:11         ` Любимов Максим
2023-10-17 10:48 ` [PATCH 04/15] build: " MaxLyubimov
2023-10-17 10:48 ` [PATCH 05/15] drivers: quectel: Add radio settings MaxLyubimov
2023-10-19  1:49   ` Denis Kenzior
2023-10-17 10:48 ` [PATCH 06/15] build: Add quectel radio settings rules MaxLyubimov
2023-10-17 10:48 ` [PATCH 07/15] plugins: quectel: Add radio settings MaxLyubimov
2023-10-19  2:00   ` Denis Kenzior
2023-10-17 10:48 ` [PATCH 08/15] drivers: gemalto: Add models list MaxLyubimov
2023-10-17 10:48 ` [PATCH 09/15] plugins: gemalto: Include " MaxLyubimov
2023-10-17 10:48 ` [PATCH 10/15] plugins: udevng: Add support gemalto EHS5-E MaxLyubimov
2023-10-17 10:48 ` [PATCH 11/15] gemalto: radio-settings: Add support EHS5-E MaxLyubimov
2023-10-17 10:48 ` [PATCH 12/15] Fix PPP LCP Configure-Reject MaxLyubimov
2023-10-19  2:08   ` Denis Kenzior [this message]
2023-10-17 10:49 ` [PATCH 13/15] atmodem: added context deactivation event handling MaxLyubimov
2023-10-19  2:13   ` Denis Kenzior
2023-10-17 10:49 ` [PATCH 14/15] gatchat: added command completion by timeout MaxLyubimov
2023-10-19  2:21   ` Denis Kenzior
2023-10-27  9:45     ` Любимов Максим
2023-10-29 20:59       ` Denis Kenzior
2023-10-30  7:04         ` Любимов Максим
2023-10-30 14:29           ` Denis Kenzior
2023-10-17 10:49 ` [PATCH 15/15] ppp: message tracing MaxLyubimov
2023-10-19  2:22   ` Denis Kenzior
2023-10-27 10:01     ` Любимов Максим
2023-10-29 21:05       ` Denis Kenzior
2023-10-30  6:34         ` Любимов Максим
2023-10-30 14:30           ` Denis Kenzior
2023-10-19  1:28 ` [PATCH 01/15] Skipping AT+CUAD sending for QUECTEL_EC2X vendor Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1542d6ef-2ff2-408f-bbd8-3902bf929bba@gmail.com \
    --to=denkenz@gmail.com \
    --cc=m.lyubimov@aqsi.ru \
    --cc=ofono@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.