From: Girija Kumar Kasinadhuni <gkumar@neverware.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kailang Yang <kailang@realtek.com>,
Hui Wang <hui.wang@canonical.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: Girija Kumar Kasinadhuni <gkumar@neverware.com>
Subject: [PATCH v3] ALSA: hda/realtek - Add auto-mute quirk for HP Spectre x360 laptop
Date: Mon, 26 Nov 2018 13:40:46 -0500 [thread overview]
Message-ID: <1543257648-105480-1-git-send-email-gkumar@neverware.com> (raw)
In-Reply-To: <s5hefbeax39.wl-tiwai@suse.de>
This device makes a loud buzzing sound when a headphone is inserted while
playing audio at full volume through the speaker.
Signed-off-by: Girija Kumar Kasinadhuni <gkumar@neverware.com>
---
Apologies for the earlier patch not being tested properly. Verified this
time, and on the actual hardware. Here' s the alsa-info output.
http://www.alsa-project.org/db/?f=16bc34d9bf8c9b2536969c125c1721fee570c9b0
sound/pci/hda/patch_realtek.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 970bc44..c39f7f2 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5495,6 +5495,7 @@ enum {
ALC255_FIXUP_DELL_HEADSET_MIC,
ALC295_FIXUP_HP_X360,
ALC221_FIXUP_HP_HEADSET_MIC,
+ ALC295_FIXUP_HP_AUTO_MUTE,
};
static const struct hda_fixup alc269_fixups[] = {
@@ -5659,6 +5660,8 @@ static const struct hda_fixup alc269_fixups[] = {
[ALC269_FIXUP_HP_MUTE_LED_MIC3] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc269_fixup_hp_mute_led_mic3,
+ .chained = true,
+ .chain_id = ALC295_FIXUP_HP_AUTO_MUTE
},
[ALC269_FIXUP_HP_GPIO_LED] = {
.type = HDA_FIXUP_FUNC,
@@ -6362,6 +6365,10 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC269_FIXUP_HEADSET_MIC
},
+ [ALC295_FIXUP_HP_AUTO_MUTE] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc_fixup_auto_mute_via_amp,
+ },
};
static const struct snd_pci_quirk alc269_fixup_tbl[] = {
--
2.7.4
next prev parent reply other threads:[~2018-11-26 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 14:11 [PATCH] ALSA: hda/realtek - Add disable auto-mute quirk for HP Spectre x360 laptop Girija Kumar Kasinadhuni
2018-11-21 16:51 ` Takashi Iwai
2018-11-21 16:51 ` Takashi Iwai
2018-11-21 17:49 ` [PATCH v2] ALSA: hda/realtek - Add " Girija Kumar Kasinadhuni
2018-11-21 22:23 ` Takashi Iwai
2018-11-21 22:23 ` Takashi Iwai
2018-11-26 18:40 ` Girija Kumar Kasinadhuni [this message]
2018-11-27 11:19 ` [PATCH v3] " Takashi Iwai
2018-11-27 11:19 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543257648-105480-1-git-send-email-gkumar@neverware.com \
--to=gkumar@neverware.com \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.