Re: [PATCH] kni: Fix build on RHEL 8

[Mohammed Gamal <mgamal@redhat.com>]

On Tue, 2018-11-27 at 10:55 +0000, Ferruh Yigit wrote:
> On 11/26/2018 8:45 PM, Mohammed Gamal wrote:
> > As RHEL8 beta has been released and is based on recent upstream
> > kernels
> > which don't use ndo_change_mtu_rh74 function. Fix the build so that
> > it
> > doesn't fail because the function is missing
> > 
> > Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
> > ---
> >  kernel/linux/kni/compat.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
> > index 5aadebb..bc81d0c 100644
> > --- a/kernel/linux/kni/compat.h
> > +++ b/kernel/linux/kni/compat.h
> > @@ -103,7 +103,8 @@
> >  #endif
> >  
> >  #if (defined(RHEL_RELEASE_CODE) && \
> > -	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
> > +	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
> > +	(RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)))
> >  #define ndo_change_mtu ndo_change_mtu_rh74
> 
> What RHEL use, can you please confirm it turns back to
> `ndo_change_mtu`, instead
> of something like `ndo_change_mtu_rh8x`?

There are no such functions in the RHEL8 kernel. You may check the
kernel source code from the SRPM available here:
http://ftp.redhat.com/redhat/rhel/rhel-8-beta/baseos/source/Packages/ke
rnel-4.18.0-32.el8.src.rpm

> 
> >  #endif
> >  
> > 
> 
>