All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Vitaly Chikunov <vt@altlinux.org>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	linux-integrity@vger.kernel.org
Subject: Re: [PATCH 2/3] ima-evm-utils: Add --xattr-user option for testing
Date: Tue, 27 Nov 2018 06:55:23 -0500	[thread overview]
Message-ID: <1543319723.3902.132.camel@linux.ibm.com> (raw)
In-Reply-To: <20181126043953.1126-2-vt@altlinux.org>

Hi Vitaly,

On Mon, 2018-11-26 at 07:39 +0300, Vitaly Chikunov wrote:
> Keep ima/evm attributes in user namespace instead of security namespace.
> Would be useful for testing purposes without having root privileges,
> easier to understand, and because --sigfile does not work for evm
> signatures.

The patch looks fine, but the patch description could use some
rewriting.

The IMA/EVM attributes are currently stored in the "security"
namespace, which requires root privileges.  Storing the ima/evm
attributes in the "user" namespace, instead of the "security"
namespace, would be useful for testing purposes. 

Please expand this: "and because --sigfile does not work for evm
signatures."

Conclude with, this patch defines the "--xattr-user" option for
testing.

Mimi


  reply	other threads:[~2018-11-27 11:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26  4:39 [PATCH 1/3] ima-avm-utils: Fix hash buffer overflow in verify_evm Vitaly Chikunov
2018-11-26  4:39 ` [PATCH 2/3] ima-evm-utils: Add --xattr-user option for testing Vitaly Chikunov
2018-11-27 11:55   ` Mimi Zohar [this message]
2018-11-26  4:39 ` [PATCH 3/3] ima-evm-utils: Allow to use Streebog hash function Vitaly Chikunov
2018-11-27 11:56   ` Mimi Zohar
2018-11-27 13:08     ` Vitaly Chikunov
2018-11-27 13:33       ` Mimi Zohar
2018-11-26 13:45 ` [PATCH 1/3] ima-avm-utils: Fix hash buffer overflow in verify_evm Vitaly Chikunov
2018-11-27 11:52 ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1543319723.3902.132.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=vt@altlinux.org \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.